| Message ID | 069eb801bc999ea85c529fa5033121e96b9df06f.1644341635.git.oleksii_moisieiev@epam.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce SCI-mediator feature | expand |
Hi, Oleksii! On 08.02.22 20:00, Oleksii Moisieiev wrote: > libxenhypfs will return blob properties as is. This output can be used > to retrieve information from the hypfs. Caller is responsible for > parsing property value. > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> > --- > tools/libs/hypfs/core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c > index 52b30db8d7..d09bba7d8c 100644 > --- a/tools/libs/hypfs/core.c > +++ b/tools/libs/hypfs/core.c > @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char *path) > errno = EISDIR; > break; > case xenhypfs_type_blob: > - errno = EDOM; > - break; This will need a /* fallthrough */ I guess > case xenhypfs_type_string: > ret_buf = buf; > buf = NULL; Thank you, Oleksandr
On 09.02.2022 14:47, Oleksandr Andrushchenko wrote: > Hi, Oleksii! > > On 08.02.22 20:00, Oleksii Moisieiev wrote: >> libxenhypfs will return blob properties as is. This output can be used >> to retrieve information from the hypfs. Caller is responsible for >> parsing property value. >> >> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> >> --- >> tools/libs/hypfs/core.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c >> index 52b30db8d7..d09bba7d8c 100644 >> --- a/tools/libs/hypfs/core.c >> +++ b/tools/libs/hypfs/core.c >> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char *path) >> errno = EISDIR; >> break; >> case xenhypfs_type_blob: >> - errno = EDOM; >> - break; > This will need a /* fallthrough */ I guess Why? There's no statement left before the next case label. Jan >> case xenhypfs_type_string: >> ret_buf = buf; >> buf = NULL;
On 08.02.22 19:00, Oleksii Moisieiev wrote: > libxenhypfs will return blob properties as is. This output can be used > to retrieve information from the hypfs. Caller is responsible for > parsing property value. > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On 09.02.22 16:01, Jan Beulich wrote: > On 09.02.2022 14:47, Oleksandr Andrushchenko wrote: >> Hi, Oleksii! >> >> On 08.02.22 20:00, Oleksii Moisieiev wrote: >>> libxenhypfs will return blob properties as is. This output can be used >>> to retrieve information from the hypfs. Caller is responsible for >>> parsing property value. >>> >>> Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> >>> --- >>> tools/libs/hypfs/core.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c >>> index 52b30db8d7..d09bba7d8c 100644 >>> --- a/tools/libs/hypfs/core.c >>> +++ b/tools/libs/hypfs/core.c >>> @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char *path) >>> errno = EISDIR; >>> break; >>> case xenhypfs_type_blob: >>> - errno = EDOM; >>> - break; >> This will need a /* fallthrough */ I guess > Why? There's no statement left before the next case label. You are right, no need Sorry > > Jan > >>> case xenhypfs_type_string: >>> ret_buf = buf; >>> buf = NULL; >
diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c index 52b30db8d7..d09bba7d8c 100644 --- a/tools/libs/hypfs/core.c +++ b/tools/libs/hypfs/core.c @@ -307,8 +307,6 @@ char *xenhypfs_read(xenhypfs_handle *fshdl, const char *path) errno = EISDIR; break; case xenhypfs_type_blob: - errno = EDOM; - break; case xenhypfs_type_string: ret_buf = buf; buf = NULL;
libxenhypfs will return blob properties as is. This output can be used to retrieve information from the hypfs. Caller is responsible for parsing property value. Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com> --- tools/libs/hypfs/core.c | 2 -- 1 file changed, 2 deletions(-)