mbox series

[v2,0/7] soc: fsl: guts: cleanups and serial_number support

Message ID 20220209163242.430265-1-michael@walle.cc (mailing list archive)
Headers show
Series soc: fsl: guts: cleanups and serial_number support | expand

Message

Michael Walle Feb. 9, 2022, 4:32 p.m. UTC
This series converts the guts driver from a platform driver to just an
core_initcall. The driver itself cannot (or rather should never) be
unloaded because others depends on detecting the current SoC revision
to apply chip errata. Other SoC drivers do it the same way. Overall I
got rid of all the global static variables.

The last patch finally adds unique id support to the guts driver. But
because the binding [1] for the security fuse processor is still pending,
it is marked as RFC.

[1] https://lore.kernel.org/linux-devicetree/20220127163728.3650648-2-michael@walle.cc/

changes since v1:
 - call kfree() in error case, thanks Dan
 - add missing of_node_put(np), thanks Dan

Michael Walle (7):
  soc: fsl: guts: machine variable might be unset
  soc: fsl: guts: remove module_exit() and fsl_guts_remove()
  soc: fsl: guts: embed fsl_guts_get_svr() in probe()
  soc: fsl: guts: allocate soc_dev_attr on the heap
  soc: fsl: guts: use of_root instead of own reference
  soc: fsl: guts: drop platform driver
  soc: fsl: guts: add serial_number support

 drivers/soc/fsl/guts.c | 219 ++++++++++++++++++++++-------------------
 1 file changed, 118 insertions(+), 101 deletions(-)

Comments

Arnd Bergmann Feb. 10, 2022, 4:20 p.m. UTC | #1
On Wed, Feb 9, 2022 at 5:32 PM Michael Walle <michael@walle.cc> wrote:
>
> This series converts the guts driver from a platform driver to just an
> core_initcall. The driver itself cannot (or rather should never) be
> unloaded because others depends on detecting the current SoC revision
> to apply chip errata. Other SoC drivers do it the same way. Overall I
> got rid of all the global static variables.
>
> The last patch finally adds unique id support to the guts driver. But
> because the binding [1] for the security fuse processor is still pending,
> it is marked as RFC.
>
> [1] https://lore.kernel.org/linux-devicetree/20220127163728.3650648-2-michael@walle.cc/
>
> changes since v1:
>  - call kfree() in error case, thanks Dan
>  - add missing of_node_put(np), thanks Dan

Looks all good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>
Michael Walle Feb. 21, 2022, 10:41 a.m. UTC | #2
Hi,

any news here? Through which tree is this supposed to go?

Am 2022-02-09 17:32, schrieb Michael Walle:
> This series converts the guts driver from a platform driver to just an
> core_initcall. The driver itself cannot (or rather should never) be
> unloaded because others depends on detecting the current SoC revision
> to apply chip errata. Other SoC drivers do it the same way. Overall I
> got rid of all the global static variables.
> 
> The last patch finally adds unique id support to the guts driver. But
> because the binding [1] for the security fuse processor is still 
> pending,
> it is marked as RFC.

As I was about to resend this series without the RFC tag, I noticed
that I forgot to mark patch 7/7 as RFC in v2 anyway. So no need for
resending.

The binding was acked by Rob and already picked up via the nvmem tree.

-michael

> 
> [1] 
> https://lore.kernel.org/linux-devicetree/20220127163728.3650648-2-michael@walle.cc/
> 
> changes since v1:
>  - call kfree() in error case, thanks Dan
>  - add missing of_node_put(np), thanks Dan
> 
> Michael Walle (7):
>   soc: fsl: guts: machine variable might be unset
>   soc: fsl: guts: remove module_exit() and fsl_guts_remove()
>   soc: fsl: guts: embed fsl_guts_get_svr() in probe()
>   soc: fsl: guts: allocate soc_dev_attr on the heap
>   soc: fsl: guts: use of_root instead of own reference
>   soc: fsl: guts: drop platform driver
>   soc: fsl: guts: add serial_number support
> 
>  drivers/soc/fsl/guts.c | 219 ++++++++++++++++++++++-------------------
>  1 file changed, 118 insertions(+), 101 deletions(-)