| Message ID | 20220208051552.13368-1-luizluca@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: dsa: realtek: add compatible strings for RTL8367RB-VB | expand |
On Tue, Feb 08, 2022 at 02:15:52AM -0300, Luiz Angelo Daros de Luca wrote: > RTL8367RB-VB was not mentioned in the compatible table, nor in the > Kconfig help text. > > The driver still detects the variant by itself and ignores which > compatible string was used to select it. So, any compatible string will > work for any compatible model. Please also update the binding documentation: Documentation/devicetree/bindings/net/dsa/realtek-smi.txt Thanks Andrew
> On Tue, Feb 08, 2022 at 02:15:52AM -0300, Luiz Angelo Daros de Luca wrote: > > RTL8367RB-VB was not mentioned in the compatible table, nor in the > > Kconfig help text. > > > > The driver still detects the variant by itself and ignores which > > compatible string was used to select it. So, any compatible string will > > work for any compatible model. > > Please also update the binding documentation: > Documentation/devicetree/bindings/net/dsa/realtek-smi.txt No, I'll do better. I'll send a new yaml version covering both realtek-smi and realtek-mdio. > > Thanks > Andrew
> > On Tue, Feb 08, 2022 at 02:15:52AM -0300, Luiz Angelo Daros de Luca wrote: > > RTL8367RB-VB was not mentioned in the compatible table, nor in the > > Kconfig help text. > > > > The driver still detects the variant by itself and ignores which > > compatible string was used to select it. So, any compatible string will > > work for any compatible model. > > Please also update the binding documentation: > Documentation/devicetree/bindings/net/dsa/realtek-smi.txt Hello Andrew, I just sent the doc update. https://patchwork.kernel.org/project/netdevbpf/list/?series=612748 Thanks,
On Tue, Feb 8, 2022 at 6:16 AM Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote: > RTL8367RB-VB was not mentioned in the compatible table, nor in the > Kconfig help text. > > The driver still detects the variant by itself and ignores which > compatible string was used to select it. So, any compatible string will > work for any compatible model. > > Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
> Please also update the binding documentation: > Documentation/devicetree/bindings/net/dsa/realtek-smi.txt Documentation/devicetree/bindings/net/dsa/realtek.yaml was merged
> > > RTL8367RB-VB was not mentioned in the compatible table, nor in the > > Kconfig help text. > > > > The driver still detects the variant by itself and ignores which > > compatible string was used to select it. So, any compatible string will > > work for any compatible model. > > > > Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij Is there anything else pending I need to do? Docs are already updated (during yaml conversion) Regards, Luiz
diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig index b7427a8292b2..8eb5148bcc00 100644 --- a/drivers/net/dsa/realtek/Kconfig +++ b/drivers/net/dsa/realtek/Kconfig @@ -29,7 +29,8 @@ config NET_DSA_REALTEK_RTL8365MB depends on NET_DSA_REALTEK_SMI || NET_DSA_REALTEK_MDIO select NET_DSA_TAG_RTL8_4 help - Select to enable support for Realtek RTL8365MB-VC and RTL8367S. + Select to enable support for Realtek RTL8365MB-VC, RTL8367RB-VB + and RTL8367S. config NET_DSA_REALTEK_RTL8366RB tristate "Realtek RTL8366RB switch subdriver" diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c index 0c5f2bdced9d..e6e3c1769166 100644 --- a/drivers/net/dsa/realtek/realtek-mdio.c +++ b/drivers/net/dsa/realtek/realtek-mdio.c @@ -206,6 +206,7 @@ static const struct of_device_id realtek_mdio_of_match[] = { #endif #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB) { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, + { .compatible = "realtek,rtl8367rb", .data = &rtl8365mb_variant, }, { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant, }, #endif { /* sentinel */ }, diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c index 946fbbd70153..a849b5cbb4e4 100644 --- a/drivers/net/dsa/realtek/realtek-smi.c +++ b/drivers/net/dsa/realtek/realtek-smi.c @@ -510,6 +510,10 @@ static const struct of_device_id realtek_smi_of_match[] = { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, + { + .compatible = "realtek,rtl8367rb", + .data = &rtl8365mb_variant, + }, { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant,
RTL8367RB-VB was not mentioned in the compatible table, nor in the Kconfig help text. The driver still detects the variant by itself and ignores which compatible string was used to select it. So, any compatible string will work for any compatible model. Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> --- drivers/net/dsa/realtek/Kconfig | 3 ++- drivers/net/dsa/realtek/realtek-mdio.c | 1 + drivers/net/dsa/realtek/realtek-smi.c | 4 ++++ 3 files changed, 7 insertions(+), 1 deletion(-)