| Message ID | 1644318803-14950-1-git-send-email-quic_saluvala@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD | expand |
On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote: > setting the vddio supply for Bluetooth SoC WCN6750 node > on SC7280 crd board > While this does better describe what the change does, as Matthias requested on v1, it fails to provide any information about why this done. Is vddio simply not powered on the IDP? Or did someone forget to add it to the idp.dtsi? Regards, Bjorn > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index cd2755c..53ea3b4 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -23,6 +23,10 @@ > }; > }; > > +&bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. >
-----Original Message----- From: Bjorn Andersson <bjorn.andersson@linaro.org> Sent: Friday, February 11, 2022 6:09 AM To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com> Cc: marcel@holtmann.org; johan.hedberg@gmail.com; mka@chromium.org; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; quic_hbandi <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium.org Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote: > setting the vddio supply for Bluetooth SoC WCN6750 node on SC7280 crd > board > While this does better describe what the change does, as Matthias requested on v1, it fails to provide any information about why this done. Is vddio simply not powered on the IDP? Or did someone forget to add it to the idp.dtsi? [Sai]: Vddio regulator handle is different for IDP and IDP2. So in common dtsi file i.e. sc7280-idp.dtsi we haven't enabled vddio instead we have add the regulator handle in board specific dts file. So for CRD too we are adding it in the sc7280-crd.dts file. Regards, Bjorn > Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > index cd2755c..53ea3b4 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts > @@ -23,6 +23,10 @@ > }; > }; > > +&bluetooth { > + vddio-supply = <&vreg_l18b_1p8>; > +}; > + > ap_tp_i2c: &i2c0 { > status = "okay"; > clock-frequency = <400000>; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. >
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index cd2755c..53ea3b4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -23,6 +23,10 @@ }; }; +&bluetooth { + vddio-supply = <&vreg_l18b_1p8>; +}; + ap_tp_i2c: &i2c0 { status = "okay"; clock-frequency = <400000>;
setting the vddio supply for Bluetooth SoC WCN6750 node on SC7280 crd board Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++ 1 file changed, 4 insertions(+)