[bpf-next,v3,0/2] bpftool: Switch to new versioning scheme (align on libbpf's)

Message

Quentin Monnet Feb. 10, 2022, 10:42 a.m. UTC

Hi, this set aims at updating the way bpftool versions are numbered.
Instead of copying the version from the kernel (given that the sources for
the kernel and bpftool are shipped together), align it on libbpf's version
number, with a fixed offset (6) to avoid going backwards. Please refer to
the description of the second commit for details on the motivations.

The patchset also adds the number of the version of libbpf that was used to
compile to the output of "bpftool version". Bpftool makes such a heavy
usage of libbpf that it makes sense to indicate what version was used to
build it.

v3:
- Compute bpftool's version at compile time, but from the macros exposed by
  libbpf instead of calling a shell to compute $(BPFTOOL_VERSION) in the
  Makefile.
- Drop the commit which would add a "libbpfversion" target to libbpf's
  Makefile. This is no longer necessary.
- Use libbpf's major, minor versions with jsonw_printf() to avoid
  offsetting the version string to skip the "v" prefix.
- Reword documentation change.

v2:
- Align on libbpf's version number instead of creating an independent
  versioning scheme.
- Use libbpf_version_string() to retrieve and display libbpf's version.
- Re-order patches (1 <-> 2).

Quentin Monnet (2):
  bpftool: Add libbpf's version number to "bpftool version" output
  bpftool: Update versioning scheme, align on libbpf's version number

 .../bpftool/Documentation/common_options.rst  | 13 +++++-----
 tools/bpf/bpftool/Makefile                    |  6 ++---
 tools/bpf/bpftool/main.c                      | 25 +++++++++++++++++++
 3 files changed, 34 insertions(+), 10 deletions(-)

Comments

[e-mail] Feb. 11, 2022, 5:20 a.m. UTC | #1

Hello:

This series was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[e-mail]>:

On Thu, 10 Feb 2022 10:42:35 +0000 you wrote:
> Hi, this set aims at updating the way bpftool versions are numbered.
> Instead of copying the version from the kernel (given that the sources for
> the kernel and bpftool are shipped together), align it on libbpf's version
> number, with a fixed offset (6) to avoid going backwards. Please refer to
> the description of the second commit for details on the motivations.
> 
> The patchset also adds the number of the version of libbpf that was used to
> compile to the output of "bpftool version". Bpftool makes such a heavy
> usage of libbpf that it makes sense to indicate what version was used to
> build it.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3,1/2] bpftool: Add libbpf's version number to "bpftool version" output
    https://git.kernel.org/bpf/bpf-next/c/61fce9693f03
  - [bpf-next,v3,2/2] bpftool: Update versioning scheme, align on libbpf's version number
    https://git.kernel.org/bpf/bpf-next/c/9910a74d6ebf

You are awesome, thank you!