Message ID | 20220209081025.2178435-2-o.rempel@pengutronix.de (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | provide yaml schema for some of USB ethernet controllers | expand |
On Wed, 09 Feb 2022 09:10:24 +0100, Oleksij Rempel wrote: > Create initial schema for ASIX USB Ethernet controllers and import all > currently supported USB IDs form drivers/net/usb/asix_devices.c > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1590224 asix@1: $nodename:0: 'asix@1' does not match '^ethernet(@.*)?$' arch/arm/boot/dts/tegra20-colibri-eval-v3.dt.yaml arch/arm/boot/dts/tegra20-colibri-iris.dt.yaml arch/arm/boot/dts/tegra30-colibri-eval-v3.dt.yaml
On Wed, Feb 09, 2022 at 09:10:24AM +0100, Oleksij Rempel wrote: > Create initial schema for ASIX USB Ethernet controllers and import all > currently supported USB IDs form drivers/net/usb/asix_devices.c > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml > > diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml > new file mode 100644 > index 000000000000..2337a1a05bda > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/asix,ax88178.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: The device tree bindings for the USB Ethernet controllers > + > +maintainers: > + - Oleksij Rempel <o.rempel@pengutronix.de> > + > +description: | > + Device tree properties for hard wired USB Ethernet devices. > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - usbb95,1720 # ASIX AX88172 > + - usbb95,172a # ASIX AX88172A > + - usbb95,1780 # ASIX AX88178 > + - usbb95,7720 # ASIX AX88772 > + - usbb95,772a # ASIX AX88772A > + - usbb95,772b # ASIX AX88772B > + - usbb95,7e2b # ASIX AX88772B > + > + reg: true > + local-mac-address: true > + mac-address: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + usb { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet@1 { > + compatible = "usbdb0,a877"; This isn't one of the above compatibles. > + reg = <1>; > + local-mac-address = [00 00 00 00 00 00]; > + }; > + }; > + - | > + usb { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb1@1 { > + compatible = "usb1234,5678"; > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet@1 { > + compatible = "usbdb0,a877"; > + reg = <1>; > + }; > + }; > + }; > -- > 2.30.2 > >
diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml new file mode 100644 index 000000000000..2337a1a05bda --- /dev/null +++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/asix,ax88178.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: The device tree bindings for the USB Ethernet controllers + +maintainers: + - Oleksij Rempel <o.rempel@pengutronix.de> + +description: | + Device tree properties for hard wired USB Ethernet devices. + +allOf: + - $ref: ethernet-controller.yaml# + +properties: + compatible: + items: + - enum: + - usbb95,1720 # ASIX AX88172 + - usbb95,172a # ASIX AX88172A + - usbb95,1780 # ASIX AX88178 + - usbb95,7720 # ASIX AX88772 + - usbb95,772a # ASIX AX88772A + - usbb95,772b # ASIX AX88772B + - usbb95,7e2b # ASIX AX88772B + + reg: true + local-mac-address: true + mac-address: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + usb { + #address-cells = <1>; + #size-cells = <0>; + + ethernet@1 { + compatible = "usbdb0,a877"; + reg = <1>; + local-mac-address = [00 00 00 00 00 00]; + }; + }; + - | + usb { + #address-cells = <1>; + #size-cells = <0>; + + usb1@1 { + compatible = "usb1234,5678"; + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + + ethernet@1 { + compatible = "usbdb0,a877"; + reg = <1>; + }; + }; + };
Create initial schema for ASIX USB Ethernet controllers and import all currently supported USB IDs form drivers/net/usb/asix_devices.c Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml