| Message ID | 20220207062213.235127-1-jhubbard@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mm/gup: some cleanups | expand |
On 2/6/22 22:22, John Hubbard wrote: > Hi, > > Here's an update, mainly just collecting reviewed-by tags: > > Changes since v4: > > * Patch 1: reflowed the commit description to 72 columns. > > * Added reviewed-by's from Christoph and Jan for remaining patches. > > * Rebased onto 5.17-rc3. > Hi Andrew, Is this OK to put in mmotm yet? All the patches here have been reviewed. And this small series also does not conflict with Willy's "[PATCH 00/75] MM folio patches for 5.18" series. thanks, John Hubbard > > Changes since v3: > > * Patch 1: Commit log: removed a reference to an out of tree module, > and updated tags and added a short note to that effect. > > * Patch 2: Fixed up do_move_pages(), to squash -EEXIST returns from > follow_page() into something that move_pages() allows: -EFAULT. > This is from reviews by Jan Kara, Matthew Wilcox, Jason Gunthorpe. > > Removed all Reviewed-by tags for this patch, due to that update. > > * Patch 4: Split into two patches, as recommended by Christoph > Hellwig. Left the Reviewed-by tags intact because no code changes > were required. > > * Added Reviewed-by tags from Claudio Imbrenda. > > Changes since v2: > > * Patch 2: Removed an unnecessary line that was causing a > clang-analyzer complaint, as reported by Lukas Bulwahn > [1] (thanks!), and retested locally. > > Jason: I've boldly left your Reviewed-by tag on this patch, > because I am predicting you'll agree with it... > > * Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and > Jason Gunthorpe that have collected since v2. > > > Changes since v1: > * Patch 4: changed from get_user_pages(), to get_user_pages_fast(). > > * Patch 4: Rewrote the commit description--thanks to Jan Kara for > that feedback. > > * Patch 1: Removed Jerome's Cc from patch 1, due to a stale email > address. > > * Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe. > > Original cover letter, updated as necessary: > > I'm including Peter's patch as the first one in this tiny series. (The > commit description has my r-b tag in place of my Cc, and removes > Jerome's Cc because he is no longer at redhat.com) The second patch is > what I had in mind for a follow-up to that, when we were discussing that > fix [2]. > > Plus, a couple more small removals that I had queued up: > > The third patch removes a completely unused routine: > pin_user_pages_locked(). > > The forth patch removes a similar routine, get_user_pages_locked(), that > only has one caller. It now calls get_user_pages_fast(), instead. > > v1 of this patchset is here: > https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/ > > v2: > https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com > > v3: > https://lore.kernel.org/r/20220203093232.572380-1-jhubbard@nvidia.com > > v4: > https://lore.kernel.org/r/20220204020010.68930-1-jhubbard@nvidia.com > > > [1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com > > [2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/ > > > John Hubbard (4): > mm/gup: follow_pfn_pte(): -EEXIST cleanup > mm/gup: remove unused pin_user_pages_locked() > mm: change lookup_node() to use get_user_pages_fast() > mm/gup: remove unused get_user_pages_locked() > > Peter Xu (1): > mm: Fix invalid page pointer returned with FOLL_PIN gups > > include/linux/mm.h | 4 -- > mm/gup.c | 101 ++++----------------------------------------- > mm/mempolicy.c | 21 ++++------ > mm/migrate.c | 7 ++++ > 4 files changed, 24 insertions(+), 109 deletions(-) > > > base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566
On Fri, 11 Feb 2022 16:24:15 -0800 John Hubbard <jhubbard@nvidia.com> wrote: > On 2/6/22 22:22, John Hubbard wrote: > > Hi, > > > > Here's an update, mainly just collecting reviewed-by tags: > > > > Changes since v4: > > > > * Patch 1: reflowed the commit description to 72 columns. > > > > * Added reviewed-by's from Christoph and Jan for remaining patches. > > > > * Rebased onto 5.17-rc3. > > > > Hi Andrew, > > Is this OK to put in mmotm yet? All the patches here have been reviewed. > And this small series also does not conflict with Willy's "[PATCH 00/75] > MM folio patches for 5.18" series. The v4 series is is -mm. Shall update to v5 soon...
On 2/11/22 16:27, Andrew Morton wrote: ... >> Hi Andrew, >> >> Is this OK to put in mmotm yet? All the patches here have been reviewed. >> And this small series also does not conflict with Willy's "[PATCH 00/75] >> MM folio patches for 5.18" series. > > The v4 series is is -mm. Shall update to v5 soon... Oh, sorry for the noise, then. Somehow I did not see the usual notification emails this time around, I'm not sure what happened there. thanks,
Hi, Here's an update, mainly just collecting reviewed-by tags: Changes since v4: * Patch 1: reflowed the commit description to 72 columns. * Added reviewed-by's from Christoph and Jan for remaining patches. * Rebased onto 5.17-rc3. Changes since v3: * Patch 1: Commit log: removed a reference to an out of tree module, and updated tags and added a short note to that effect. * Patch 2: Fixed up do_move_pages(), to squash -EEXIST returns from follow_page() into something that move_pages() allows: -EFAULT. This is from reviews by Jan Kara, Matthew Wilcox, Jason Gunthorpe. Removed all Reviewed-by tags for this patch, due to that update. * Patch 4: Split into two patches, as recommended by Christoph Hellwig. Left the Reviewed-by tags intact because no code changes were required. * Added Reviewed-by tags from Claudio Imbrenda. Changes since v2: * Patch 2: Removed an unnecessary line that was causing a clang-analyzer complaint, as reported by Lukas Bulwahn [1] (thanks!), and retested locally. Jason: I've boldly left your Reviewed-by tag on this patch, because I am predicting you'll agree with it... * Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and Jason Gunthorpe that have collected since v2. Changes since v1: * Patch 4: changed from get_user_pages(), to get_user_pages_fast(). * Patch 4: Rewrote the commit description--thanks to Jan Kara for that feedback. * Patch 1: Removed Jerome's Cc from patch 1, due to a stale email address. * Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe. Original cover letter, updated as necessary: I'm including Peter's patch as the first one in this tiny series. (The commit description has my r-b tag in place of my Cc, and removes Jerome's Cc because he is no longer at redhat.com) The second patch is what I had in mind for a follow-up to that, when we were discussing that fix [2]. Plus, a couple more small removals that I had queued up: The third patch removes a completely unused routine: pin_user_pages_locked(). The forth patch removes a similar routine, get_user_pages_locked(), that only has one caller. It now calls get_user_pages_fast(), instead. v1 of this patchset is here: https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/ v2: https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com v3: https://lore.kernel.org/r/20220203093232.572380-1-jhubbard@nvidia.com v4: https://lore.kernel.org/r/20220204020010.68930-1-jhubbard@nvidia.com [1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com [2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/ John Hubbard (4): mm/gup: follow_pfn_pte(): -EEXIST cleanup mm/gup: remove unused pin_user_pages_locked() mm: change lookup_node() to use get_user_pages_fast() mm/gup: remove unused get_user_pages_locked() Peter Xu (1): mm: Fix invalid page pointer returned with FOLL_PIN gups include/linux/mm.h | 4 -- mm/gup.c | 101 ++++----------------------------------------- mm/mempolicy.c | 21 ++++------ mm/migrate.c | 7 ++++ 4 files changed, 24 insertions(+), 109 deletions(-) base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566