Message ID | 20220209101530.3442837-8-thuth@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Improve integration of iotests in the meson test harness | expand |
On 2/9/22 11:15, Thomas Huth wrote: > When running in TAP mode, stdout is reserved for the TAP protocol. > To see the "diff" of the failed test, we have to print it to > stderr instead. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > tests/qemu-iotests/testrunner.py | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py > index 9d20f51bb1..1f7ca1f2f9 100644 > --- a/tests/qemu-iotests/testrunner.py > +++ b/tests/qemu-iotests/testrunner.py > @@ -404,7 +404,10 @@ def run_tests(self, tests: List[str], jobs: int = 1) -> bool: > if res.status == 'fail': > failed.append(name) > if res.diff: > - print('\n'.join(res.diff)) > + if self.tap: > + print('\n'.join(res.diff), file=sys.stderr) > + else: > + print('\n'.join(res.diff)) > elif res.status == 'not run': > notrun.append(name) > elif res.status == 'pass': Queued, thanks. Paolo
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py index 9d20f51bb1..1f7ca1f2f9 100644 --- a/tests/qemu-iotests/testrunner.py +++ b/tests/qemu-iotests/testrunner.py @@ -404,7 +404,10 @@ def run_tests(self, tests: List[str], jobs: int = 1) -> bool: if res.status == 'fail': failed.append(name) if res.diff: - print('\n'.join(res.diff)) + if self.tap: + print('\n'.join(res.diff), file=sys.stderr) + else: + print('\n'.join(res.diff)) elif res.status == 'not run': notrun.append(name) elif res.status == 'pass':
When running in TAP mode, stdout is reserved for the TAP protocol. To see the "diff" of the failed test, we have to print it to stderr instead. Signed-off-by: Thomas Huth <thuth@redhat.com> --- tests/qemu-iotests/testrunner.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)