| Message ID | 20220210133115.115967-2-elic@nvidia.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | vdpa tool enhancements | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 2/10/2022 5:31 AM, Eli Cohen wrote: > "-v[erbose]" option is not supported. > Remove it. > > Acked-by: Jason Wang <jasowang@redhat.com> > Reviewed-by: Jianbo Liu <jianbol@mellanox.com> > Signed-off-by: Eli Cohen <elic@nvidia.com> > --- > vdpa/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > index f048e470c929..4ccb564872a0 100644 > --- a/vdpa/vdpa.c > +++ b/vdpa/vdpa.c > @@ -711,7 +711,7 @@ static void help(void) > fprintf(stderr, > "Usage: vdpa [ OPTIONS ] OBJECT { COMMAND | help }\n" > "where OBJECT := { mgmtdev | dev }\n" > - " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n"); > + " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] }\n"); Maybe remove -n option that is also unsupported yet? Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com> > } > > static int vdpa_cmd(struct vdpa *vdpa, int argc, char **argv)
On Fri, Feb 11, 2022 at 04:44:14PM -0800, Si-Wei Liu wrote: > > > On 2/10/2022 5:31 AM, Eli Cohen wrote: > > "-v[erbose]" option is not supported. > > Remove it. > > > > Acked-by: Jason Wang <jasowang@redhat.com> > > Reviewed-by: Jianbo Liu <jianbol@mellanox.com> > > Signed-off-by: Eli Cohen <elic@nvidia.com> > > --- > > vdpa/vdpa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c > > index f048e470c929..4ccb564872a0 100644 > > --- a/vdpa/vdpa.c > > +++ b/vdpa/vdpa.c > > @@ -711,7 +711,7 @@ static void help(void) > > fprintf(stderr, > > "Usage: vdpa [ OPTIONS ] OBJECT { COMMAND | help }\n" > > "where OBJECT := { mgmtdev | dev }\n" > > - " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n"); > > + " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] }\n"); > Maybe remove -n option that is also unsupported yet? I didn't notice this. Will review all help messages and fix in a follow up patch. > > Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com> > > } > > static int vdpa_cmd(struct vdpa *vdpa, int argc, char **argv) >
diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c index f048e470c929..4ccb564872a0 100644 --- a/vdpa/vdpa.c +++ b/vdpa/vdpa.c @@ -711,7 +711,7 @@ static void help(void) fprintf(stderr, "Usage: vdpa [ OPTIONS ] OBJECT { COMMAND | help }\n" "where OBJECT := { mgmtdev | dev }\n" - " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n"); + " OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] }\n"); } static int vdpa_cmd(struct vdpa *vdpa, int argc, char **argv)