| Message ID | 20220214212154.8853-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pwm: dt-bindings: Include generic pwm schema | expand |
Hello, [dropped Anson Huang and Yash Shah from Cc: which were not reachable for my last mail] On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: > Hi, > > Changes since v1: > 1. Add tags. > 2. Adjust subject (Uwe). However you only took a part of my suggestion ... > Krzysztof Kozlowski (15): > dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > dt-bindings: pwm: imx: Include generic pwm schema > dt-bindings: pwm: intel,lgm: Include generic pwm schema > dt-bindings: pwm: iqs620a: Include generic pwm schema > dt-bindings: pwm: mxs: Include generic pwm schema > dt-bindings: pwm: rockchip: Include generic pwm schema > dt-bindings: pwm: sifive: Include generic pwm schema > dt-bindings: pwm: renesas,pwm: Include generic pwm schema > dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice ... The actual patch has a space after the comma, I like this variant without comma better as this is a compatible string. Also a # before pwm-cells would be nice. Best regards Uwe
On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > Hello, > > [dropped Anson Huang and Yash Shah from Cc: which were not reachable for > my last mail] > > On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: > > Hi, > > > > Changes since v1: > > 1. Add tags. > > 2. Adjust subject (Uwe). > > However you only took a part of my suggestion ... > > > Krzysztof Kozlowski (15): > > dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > > dt-bindings: pwm: imx: Include generic pwm schema > > dt-bindings: pwm: intel,lgm: Include generic pwm schema > > dt-bindings: pwm: iqs620a: Include generic pwm schema > > dt-bindings: pwm: mxs: Include generic pwm schema > > dt-bindings: pwm: rockchip: Include generic pwm schema > > dt-bindings: pwm: sifive: Include generic pwm schema > > dt-bindings: pwm: renesas,pwm: Include generic pwm schema > > dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > > dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > > dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice > > ... The actual patch has a space after the comma, I like this variant > without comma better as this is a compatible string. I am confused. My patch does not have comma after space. Your reply had such in the subject, but not in the proposed new subject you wrote in msg, so I left it as is. Without comma. If you still see comma, it is something with your mail client. See: https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u Also reply from Vijayakannan does not have comma: https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec > Also a # before > pwm-cells would be nice. I can add this. Best regards, Krzysztof
On 15/02/2022 08:59, Krzysztof Kozlowski wrote: > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: >> >> Hello, >> >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for >> my last mail] >> >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Changes since v1: >>> 1. Add tags. >>> 2. Adjust subject (Uwe). >> >> However you only took a part of my suggestion ... >> >>> Krzysztof Kozlowski (15): >>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema >>> dt-bindings: pwm: imx: Include generic pwm schema >>> dt-bindings: pwm: intel,lgm: Include generic pwm schema >>> dt-bindings: pwm: iqs620a: Include generic pwm schema >>> dt-bindings: pwm: mxs: Include generic pwm schema >>> dt-bindings: pwm: rockchip: Include generic pwm schema >>> dt-bindings: pwm: sifive: Include generic pwm schema >>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema >>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema >>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice >>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice >> >> ... The actual patch has a space after the comma, I like this variant >> without comma better as this is a compatible string. > > I am confused. My patch does not have comma after space. Your reply > had such in the subject, but not in the proposed new subject you wrote > in msg, so I left it as is. Without comma. If you still see comma, it > is something with your mail client. > > See: > https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u > > Also reply from Vijayakannan does not have comma: > https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec > >> Also a # before >> pwm-cells would be nice. > > I can add this. Just one more clarification - you proposed also to remove "pwm:" middle-prefix. Shall I remove it from every patch and use instead full file name? Best regards, Krzysztof
On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote: > On 15/02/2022 08:59, Krzysztof Kozlowski wrote: > > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König > > <u.kleine-koenig@pengutronix.de> wrote: > >> > >> Hello, > >> > >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for > >> my last mail] > >> > >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: > >>> Hi, > >>> > >>> Changes since v1: > >>> 1. Add tags. > >>> 2. Adjust subject (Uwe). > >> > >> However you only took a part of my suggestion ... > >> > >>> Krzysztof Kozlowski (15): > >>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > >>> dt-bindings: pwm: imx: Include generic pwm schema > >>> dt-bindings: pwm: intel,lgm: Include generic pwm schema > >>> dt-bindings: pwm: iqs620a: Include generic pwm schema > >>> dt-bindings: pwm: mxs: Include generic pwm schema > >>> dt-bindings: pwm: rockchip: Include generic pwm schema > >>> dt-bindings: pwm: sifive: Include generic pwm schema > >>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema > >>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > >>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > >>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice > >> > >> ... The actual patch has a space after the comma, I like this variant > >> without comma better as this is a compatible string. > > > > I am confused. My patch does not have comma after space. Your reply > > had such in the subject, but not in the proposed new subject you wrote > > in msg, so I left it as is. Without comma. If you still see comma, it > > is something with your mail client. > > > > See: > > https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u > > > > Also reply from Vijayakannan does not have comma: > > https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec Strange: I have this mail four times in my mailboxes (via linux-arm-kernel, linux-pwm, kernel@pengutronix.de and directly). In the two latter the Subject line is broken in two: Subject: [PATCH v2 08/15] dt-bindings: pwm: renesas, pwm: Include generic pwm schema So this is indeed a problem near my side. > Just one more clarification - you proposed also to remove "pwm:" > middle-prefix. Shall I remove it from every patch and use instead full > file name? I did that to save some vertical space in the Subject line. I don't feel strong here. Best regards Uwe
On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-König wrote: > On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote: > > On 15/02/2022 08:59, Krzysztof Kozlowski wrote: > > > On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König > > > <u.kleine-koenig@pengutronix.de> wrote: > > >> > > >> Hello, > > >> > > >> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for > > >> my last mail] > > >> > > >> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: > > >>> Hi, > > >>> > > >>> Changes since v1: > > >>> 1. Add tags. > > >>> 2. Adjust subject (Uwe). > > >> > > >> However you only took a part of my suggestion ... > > >> > > >>> Krzysztof Kozlowski (15): > > >>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > > >>> dt-bindings: pwm: imx: Include generic pwm schema > > >>> dt-bindings: pwm: intel,lgm: Include generic pwm schema > > >>> dt-bindings: pwm: iqs620a: Include generic pwm schema > > >>> dt-bindings: pwm: mxs: Include generic pwm schema > > >>> dt-bindings: pwm: rockchip: Include generic pwm schema > > >>> dt-bindings: pwm: sifive: Include generic pwm schema > > >>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema > > >>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > > >>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > > >>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice > > >> > > >> ... The actual patch has a space after the comma, I like this variant > > >> without comma better as this is a compatible string. > > > > > > I am confused. My patch does not have comma after space. Your reply > > > had such in the subject, but not in the proposed new subject you wrote > > > in msg, so I left it as is. Without comma. If you still see comma, it > > > is something with your mail client. > > > > > > See: > > > https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u > > > > > > Also reply from Vijayakannan does not have comma: > > > https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec > > Strange: I have this mail four times in my mailboxes (via > linux-arm-kernel, linux-pwm, kernel@pengutronix.de and directly). In the > two latter the Subject line is broken in two: I was wrong. The ones to kernel@pengutronix.de and the linux-arm-kernel one are the ones with the linebreak. Hmm, http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html has the linebreaks, too. Still I wonder what is different between kernel@pengutronix.de and u.kleine-koenig@pengutronix.de. Best regards Uwe
On 15/02/2022 11:49, Uwe Kleine-König wrote: > On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-König wrote: >> On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote: >>> On 15/02/2022 08:59, Krzysztof Kozlowski wrote: >>>> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König >>>> <u.kleine-koenig@pengutronix.de> wrote: >>>>> >>>>> Hello, >>>>> >>>>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for >>>>> my last mail] >>>>> >>>>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: >>>>>> Hi, >>>>>> >>>>>> Changes since v1: >>>>>> 1. Add tags. >>>>>> 2. Adjust subject (Uwe). >>>>> >>>>> However you only took a part of my suggestion ... >>>>> >>>>>> Krzysztof Kozlowski (15): >>>>>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema >>>>>> dt-bindings: pwm: imx: Include generic pwm schema >>>>>> dt-bindings: pwm: intel,lgm: Include generic pwm schema >>>>>> dt-bindings: pwm: iqs620a: Include generic pwm schema >>>>>> dt-bindings: pwm: mxs: Include generic pwm schema >>>>>> dt-bindings: pwm: rockchip: Include generic pwm schema >>>>>> dt-bindings: pwm: sifive: Include generic pwm schema >>>>>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema >>>>>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema >>>>>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice >>>>>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice >>>>> >>>>> ... The actual patch has a space after the comma, I like this variant >>>>> without comma better as this is a compatible string. >>>> >>>> I am confused. My patch does not have comma after space. Your reply >>>> had such in the subject, but not in the proposed new subject you wrote >>>> in msg, so I left it as is. Without comma. If you still see comma, it >>>> is something with your mail client. >>>> >>>> See: >>>> https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u >>>> >>>> Also reply from Vijayakannan does not have comma: >>>> https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec >> >> Strange: I have this mail four times in my mailboxes (via >> linux-arm-kernel, linux-pwm, kernel@pengutronix.de and directly). In the >> two latter the Subject line is broken in two: > > I was wrong. The ones to kernel@pengutronix.de and the linux-arm-kernel > one are the ones with the linebreak. > > Hmm, > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html > > has the linebreaks, too. Still I wonder what is different between > kernel@pengutronix.de and u.kleine-koenig@pengutronix.de. Other threads - not only mine - are also affected: http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html Best regards, Krzysztof
On Tue, Feb 15, 2022 at 01:41:20PM +0100, Krzysztof Kozlowski wrote: > On 15/02/2022 11:49, Uwe Kleine-König wrote: > > On Tue, Feb 15, 2022 at 10:41:06AM +0100, Uwe Kleine-König wrote: > >> On Tue, Feb 15, 2022 at 09:02:25AM +0100, Krzysztof Kozlowski wrote: > >>> On 15/02/2022 08:59, Krzysztof Kozlowski wrote: > >>>> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König > >>>> <u.kleine-koenig@pengutronix.de> wrote: > >>>>> > >>>>> Hello, > >>>>> > >>>>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for > >>>>> my last mail] > >>>>> > >>>>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote: > >>>>>> Hi, > >>>>>> > >>>>>> Changes since v1: > >>>>>> 1. Add tags. > >>>>>> 2. Adjust subject (Uwe). > >>>>> > >>>>> However you only took a part of my suggestion ... > >>>>> > >>>>>> Krzysztof Kozlowski (15): > >>>>>> dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > >>>>>> dt-bindings: pwm: imx: Include generic pwm schema > >>>>>> dt-bindings: pwm: intel,lgm: Include generic pwm schema > >>>>>> dt-bindings: pwm: iqs620a: Include generic pwm schema > >>>>>> dt-bindings: pwm: mxs: Include generic pwm schema > >>>>>> dt-bindings: pwm: rockchip: Include generic pwm schema > >>>>>> dt-bindings: pwm: sifive: Include generic pwm schema > >>>>>> dt-bindings: pwm: renesas,pwm: Include generic pwm schema > >>>>>> dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > >>>>>> dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > >>>>>> dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice > >>>>> > >>>>> ... The actual patch has a space after the comma, I like this variant > >>>>> without comma better as this is a compatible string. > >>>> > >>>> I am confused. My patch does not have comma after space. Your reply > >>>> had such in the subject, but not in the proposed new subject you wrote > >>>> in msg, so I left it as is. Without comma. If you still see comma, it > >>>> is something with your mail client. > >>>> > >>>> See: > >>>> https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u > >>>> > >>>> Also reply from Vijayakannan does not have comma: > >>>> https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec > >> > >> Strange: I have this mail four times in my mailboxes (via > >> linux-arm-kernel, linux-pwm, kernel@pengutronix.de and directly). In the > >> two latter the Subject line is broken in two: > > > > I was wrong. The ones to kernel@pengutronix.de and the linux-arm-kernel > > one are the ones with the linebreak. > > > > Hmm, > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717310.html > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/717304.html > > > > has the linebreaks, too. Still I wonder what is different between > > kernel@pengutronix.de and u.kleine-koenig@pengutronix.de. > > Other threads - not only mine - are also affected: > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html In the meantime I'm confident that mailman2 is the culprit. Best regards Uwe
Hello, On Tue, Feb 15, 2022 at 01:58:56PM +0100, Uwe Kleine-König wrote: > On Tue, Feb 15, 2022 at 01:41:20PM +0100, Krzysztof Kozlowski wrote: > > On 15/02/2022 11:49, Uwe Kleine-König wrote: > > > [... Something inserted a space in Subject lines ...] > > > > Other threads - not only mine - are also affected: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714311.html > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714316.html > > http://lists.infradead.org/pipermail/linux-arm-kernel/2022-February/714364.html > > In the meantime I'm confident that mailman2 is the culprit. For the record: Using python2 (which is what mailman2 uses): >>> from email.header import Header >>> h = Header('[PATCH v2 08/15] dt-bindings: pwm: renesas,pwm: Include generic pwm schema', maxlinelen=76, header_name='Subject') >>> h.encode() '[PATCH v2 08/15] dt-bindings: pwm: renesas,\n pwm: Include generic pwm schema' This is the inner source of the problem, mailman just does something like: >>> import email >>> a = email.message_from_file(open('message')) >>> open('message-mangled', 'w').write(a.as_string()) So we just have to wait until all mailserver admins migrate away from mailman2. I bet this will happen no later than when Python2 will become EOL. :-\ Best regards Uwe
On Mon, Feb 14, 2022 at 3:22 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Hi, > > Changes since v1: > 1. Add tags. > 2. Adjust subject (Uwe). > > Best regards, > Krzysztof > > Krzysztof Kozlowski (15): > dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema > dt-bindings: pwm: imx: Include generic pwm schema > dt-bindings: pwm: intel,lgm: Include generic pwm schema > dt-bindings: pwm: iqs620a: Include generic pwm schema > dt-bindings: pwm: mxs: Include generic pwm schema > dt-bindings: pwm: rockchip: Include generic pwm schema > dt-bindings: pwm: sifive: Include generic pwm schema > dt-bindings: pwm: renesas,pwm: Include generic pwm schema > dt-bindings: pwm: toshiba,visconti: Include generic pwm schema > dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice > dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice > dt-bindings: pwm: samsung: Do not require pwm-cells twice > dt-bindings: pwm: tiecap: Do not require pwm-cells twice > dt-bindings: pwm: tiehrpwm: Do not require pwm-cells twice > dt-bindings: pwm: renesas,tpu: Do not require pwm-cells twice For the series: Reviewed-by: Rob Herring <robh@kernel.org>
On 14/02/2022 22:21, Krzysztof Kozlowski wrote: > Hi, > > Changes since v1: > 1. Add tags. > 2. Adjust subject (Uwe). > Hi Thierry, Uwe and Lee, Any comments here? Rob acked all these, so these are clear to go via PWM tree. Best regards, Krzysztof
Hello, (dropped Anson Huang and Yash Shah from Cc, their addresses bounced last time I used them.) On Wed, Mar 02, 2022 at 08:04:45PM +0100, Krzysztof Kozlowski wrote: > On 14/02/2022 22:21, Krzysztof Kozlowski wrote: > > Hi, > > > > Changes since v1: > > 1. Add tags. > > 2. Adjust subject (Uwe). > > > > Hi Thierry, Uwe and Lee, > > Any comments here? Rob acked all these, so these are clear to go via PWM > tree. They are fine from my side: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> It's Thierry who is reponsible to pick these up and it seems he marked the series as accepted: https://patchwork.ozlabs.org/project/linux-pwm/list/?series=286150&state=* So I would expect that it turns up in next after Thierry is done with his testing. Best regards Uwe