| Message ID | 20220216115947.85220-1-jianchao.wan9@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [[RFC,blktests] ] test/block/032: add test cases for switching queue qos | expand |
On 2/16/22 03:59, Wang Jianchao (Kuaishou) wrote: > Signed-off-by: Wang Jianchao (Kuaishou) <jianchao.wan9@gmail.com> > --- > tests/block/032 | 62 +++++++++++++++++++++++++++++++++++++++++++++ > tests/block/032.out | 2 ++ > 2 files changed, 64 insertions(+) > create mode 100644 tests/block/032 > create mode 100644 tests/block/032.out > > diff --git a/tests/block/032 b/tests/block/032 Can you please add some comments to make it easier to read for someone who's new to the blktests framework ? -ck
On 2022/2/17 1:34 上午, Chaitanya Kulkarni wrote: > On 2/16/22 03:59, Wang Jianchao (Kuaishou) wrote: >> Signed-off-by: Wang Jianchao (Kuaishou) <jianchao.wan9@gmail.com> >> --- >> tests/block/032 | 62 +++++++++++++++++++++++++++++++++++++++++++++ >> tests/block/032.out | 2 ++ >> 2 files changed, 64 insertions(+) >> create mode 100644 tests/block/032 >> create mode 100644 tests/block/032.out >> >> diff --git a/tests/block/032 b/tests/block/032 > > > Can you please add some comments to make it easier to read for someone > who's new to the blktests framework ? > I will add some comment to explain what does the test case do in next version. Thanks Jianchao
diff --git a/tests/block/032 b/tests/block/032 new file mode 100644 index 0000000..bb10506 --- /dev/null +++ b/tests/block/032 @@ -0,0 +1,62 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-3.0+ +# Copyright (C) 2022 Wang Jianchao +# +# Threads doing IO to a device, while we switch rqos + +. tests/block/rc + +DESCRIPTION="switch rqos while doing IO" +TIMED=1 +CAN_BE_ZONED=1 + +requires() { + _have_fio +} + +test_device() { + echo "Running ${TEST_NAME}" + + local rqos=("wbt" "iolat" "iocost" "io-prio") + + if _test_dev_is_rotational; then + size="32m" + else + size="1g" + fi + + # start fio job + _run_fio_rand_io --filename="$TEST_DEV" --size="$size" & + + start_time=$(date +%s) + timeout=${TIMEOUT:=900} + while kill -0 $! 2>/dev/null; do + idx=$((RANDOM % ${#rqos[@]})) + pol=${rqos[$idx]} + cat ${TEST_DEV_SYSFS}/queue/qos | grep "\[$pol\]" > /dev/null + if [ $? -eq 0 ];then + echo "-$pol" > ${TEST_DEV_SYSFS}/queue/qos + if [ $? -ne 0 ];then + echo "$pol" + cat ${TEST_DEV_SYSFS}/queue/qos + fi + else + echo "+$pol" > ${TEST_DEV_SYSFS}/queue/qos + if [ $? -ne 0 ];then + echo "$pol" + cat ${TEST_DEV_SYSFS}/queue/qos + fi + fi + sleep .2 + end_time=$(date +%s) + if (( end_time - start_time > timeout + 15 )); then + echo "fio did not finish after $timeout seconds!" + break + fi + done + + FIO_PERF_FIELDS=("read iops") + _fio_perf_report + + echo "Test complete" +} diff --git a/tests/block/032.out b/tests/block/032.out new file mode 100644 index 0000000..3604e9e --- /dev/null +++ b/tests/block/032.out @@ -0,0 +1,2 @@ +Running block/032 +Test complete
Signed-off-by: Wang Jianchao (Kuaishou) <jianchao.wan9@gmail.com> --- tests/block/032 | 62 +++++++++++++++++++++++++++++++++++++++++++++ tests/block/032.out | 2 ++ 2 files changed, 64 insertions(+) create mode 100644 tests/block/032 create mode 100644 tests/block/032.out