diff mbox series

[v1,net-next] teaming: deliver link-local packets with the link they arrive on

Message ID 20220215220517.2498751-1-jeffreyji@google.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [v1,net-next] teaming: deliver link-local packets with the link they arrive on | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: jiri@resnulli.us
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch warning WARNING: networking block comments don't use an empty /* line, use /* Comment...
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Jeffrey Ji Feb. 15, 2022, 10:05 p.m. UTC 
From: jeffreyji <jeffreyji@google.com>

skb is ignored if team port is disabled. We want the skb to be delivered
if it's an LLDP packet.

Issue is already fixed for bonding in commit
b89f04c61efe3b7756434d693b9203cc0cce002e

Signed-off-by: jeffreyji <jeffreyji@google.com>
---
 drivers/net/team/team.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jakub Kicinski Feb. 17, 2022, 4:44 a.m. UTC | #1 
On Tue, 15 Feb 2022 22:05:17 +0000 Jeffrey Ji wrote:
> From: jeffreyji <jeffreyji@google.com>
> 
> skb is ignored if team port is disabled. We want the skb to be delivered
> if it's an LLDP packet.
> 
> Issue is already fixed for bonding in commit
> b89f04c61efe3b7756434d693b9203cc0cce002e

This is not the correct way to quote a commit.  It should be
commit <12+ chars of sha1> ("title line").

> Signed-off-by: jeffreyji <jeffreyji@google.com>

You must CC maintainers. scripts/get_maintainer.pl is your friend.
You don't have to CC linux-kernel, tho, nobody reads that. Please
resend.

> diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
> index 8b2adc56b92a..24d66dfbb2e1 100644
> --- a/drivers/net/team/team.c
> +++ b/drivers/net/team/team.c
> @@ -734,6 +734,12 @@ static rx_handler_result_t team_handle_frame(struct sk_buff **pskb)
>  	port = team_port_get_rcu(skb->dev);
>  	team = port->team;
>  	if (!team_port_enabled(port)) {
> +		if (is_link_local_ether_addr(eth_hdr(skb)->h_dest))
> +			/*

Please run checkpatch --strict on your submissions

> +			 * link-local packets are mostly useful when stack
> +			 * receives them with the link they arrive on.
> +			 */
> +			return RX_HANDLER_PASS;
>  		/* allow exact match delivery for disabled ports */
>  		res = RX_HANDLER_EXACT;
>  	} else {
diff mbox series

Patch

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 8b2adc56b92a..24d66dfbb2e1 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -734,6 +734,12 @@  static rx_handler_result_t team_handle_frame(struct sk_buff **pskb)
 	port = team_port_get_rcu(skb->dev);
 	team = port->team;
 	if (!team_port_enabled(port)) {
+		if (is_link_local_ether_addr(eth_hdr(skb)->h_dest))
+			/*
+			 * link-local packets are mostly useful when stack
+			 * receives them with the link they arrive on.
+			 */
+			return RX_HANDLER_PASS;
 		/* allow exact match delivery for disabled ports */
 		res = RX_HANDLER_EXACT;
 	} else {