| Message ID | 20220208124034.414635-11-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | clk: mediatek: Cleanups and Improvements - Part 1 | expand |
On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > struct mtk_clk_mux is an implementation detail of the mux clk type, > and is not used outside of the implementation. > > Internalize the definition to minimize leakage of details and shrink > the header file. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> > --- > drivers/clk/mediatek/clk-mux.c | 8 ++++++++ > drivers/clk/mediatek/clk-mux.h | 8 -------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-mux.c > b/drivers/clk/mediatek/clk-mux.c > index 6f0c22a699c3..2d4d8dc0120a 100644 > --- a/drivers/clk/mediatek/clk-mux.c > +++ b/drivers/clk/mediatek/clk-mux.c > @@ -13,6 +13,14 @@ > #include "clk-mtk.h" > #include "clk-mux.h" > > +struct mtk_clk_mux { > + struct clk_hw hw; > + struct regmap *regmap; > + const struct mtk_mux *data; > + spinlock_t *lock; > + bool reparent; > +}; > + > static inline struct mtk_clk_mux *to_mtk_clk_mux(struct clk_hw *hw) > { > return container_of(hw, struct mtk_clk_mux, hw); > diff --git a/drivers/clk/mediatek/clk-mux.h > b/drivers/clk/mediatek/clk-mux.h > index cb2ac4f04c58..38a2b6014b08 100644 > --- a/drivers/clk/mediatek/clk-mux.h > +++ b/drivers/clk/mediatek/clk-mux.h > @@ -9,14 +9,6 @@ > > #include <linux/clk-provider.h> > > -struct mtk_clk_mux { > - struct clk_hw hw; > - struct regmap *regmap; > - const struct mtk_mux *data; > - spinlock_t *lock; > - bool reparent; > -}; > - > struct mtk_mux { > int id; > const char *name;
Quoting Chen-Yu Tsai (2022-02-08 04:40:13) > struct mtk_clk_mux is an implementation detail of the mux clk type, > and is not used outside of the implementation. > > Internalize the definition to minimize leakage of details and shrink > the header file. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Applied to clk-next
diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c index 6f0c22a699c3..2d4d8dc0120a 100644 --- a/drivers/clk/mediatek/clk-mux.c +++ b/drivers/clk/mediatek/clk-mux.c @@ -13,6 +13,14 @@ #include "clk-mtk.h" #include "clk-mux.h" +struct mtk_clk_mux { + struct clk_hw hw; + struct regmap *regmap; + const struct mtk_mux *data; + spinlock_t *lock; + bool reparent; +}; + static inline struct mtk_clk_mux *to_mtk_clk_mux(struct clk_hw *hw) { return container_of(hw, struct mtk_clk_mux, hw); diff --git a/drivers/clk/mediatek/clk-mux.h b/drivers/clk/mediatek/clk-mux.h index cb2ac4f04c58..38a2b6014b08 100644 --- a/drivers/clk/mediatek/clk-mux.h +++ b/drivers/clk/mediatek/clk-mux.h @@ -9,14 +9,6 @@ #include <linux/clk-provider.h> -struct mtk_clk_mux { - struct clk_hw hw; - struct regmap *regmap; - const struct mtk_mux *data; - spinlock_t *lock; - bool reparent; -}; - struct mtk_mux { int id; const char *name;