Message ID | 1645112566-115804-1-git-send-email-john.garry@huawei.com (mailing list archive) |
---|---|
Headers | show |
Series | scsi: libsas and users: Factor out LLDD TMF code | expand |
On 2/18/22 00:42, John Garry wrote: > The LLDD TMF code is almost identical between hisi_sas, pm8001, and mvsas > drivers. > > This series factors out that code into libsas, thus reducing much > duplication and giving a net reduction of ~350 LoC. > > There are some subtle differences between the core TMF handler and each > of the LLDDs old implementation, so any review and testing is appreciated. > > Some other minor patches are thrown in: > - Delete unused macro in hisi_sas driver > - Delete unused libsas callback > - Delete unused SAS_SG_ERR > - Add enum for response frame datapres field > - Handle unrecognised errors in sas_scsi_find_task() > > I have another follow-up series to factor out the internal abort code, > which is common to hisi_sas and pm8001 drivers. > > Based on mkp-scsi 5.18 staging queue at commit ac2beb4e3bd7 I tested this series with my pm8001 v5 series on top. Everything looks good, no problems detected with both SAS and SATA drives tests. So feel free to add: Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> Martin, This series and my pm8001 series have a conflict. When applying the pm8001 patches on top of these libsas changes, patch 28 has a fairly easy to resolve conflict. Let me know if you want me to send a v6 rebased on top of this. Thanks !
Damien, > This series and my pm8001 series have a conflict. When applying the > pm8001 patches on top of these libsas changes, patch 28 has a fairly > easy to resolve conflict. Let me know if you want me to send a v6 > rebased on top of this. I'll fix it up.
Damien, > This series and my pm8001 series have a conflict. When applying the > pm8001 patches on top of these libsas changes, patch 28 has a fairly > easy to resolve conflict. Let me know if you want me to send a v6 > rebased on top of this. "fairly easy to resolve", huh? Sure, if you manually rework the entire patch. Please send me an updated version of #28. The rest of the series is fine... Thanks!
John, > The LLDD TMF code is almost identical between hisi_sas, pm8001, and > mvsas drivers. > > This series factors out that code into libsas, thus reducing much > duplication and giving a net reduction of ~350 LoC. Applied to 5.18/scsi-staging, thanks!
On 2/20/22 06:53, Martin K. Petersen wrote: > > Damien, > >> This series and my pm8001 series have a conflict. When applying the >> pm8001 patches on top of these libsas changes, patch 28 has a fairly >> easy to resolve conflict. Let me know if you want me to send a v6 >> rebased on top of this. > > "fairly easy to resolve", huh? Sure, if you manually rework the entire > patch. Sorry about that. It is easy to resolve once you have been staring at the code for days :) Sending v6 for patch 28. > > Please send me an updated version of #28. The rest of the series is > fine... > > Thanks! >
On 2/20/22 06:55, Martin K. Petersen wrote: > > John, > >> The LLDD TMF code is almost identical between hisi_sas, pm8001, and >> mvsas drivers. >> >> This series factors out that code into libsas, thus reducing much >> duplication and giving a net reduction of ~350 LoC. > > Applied to 5.18/scsi-staging, thanks! Did you push this ? I do not see John series in the branch...
Damien, >> Applied to 5.18/scsi-staging, thanks! > > Did you push this ? I do not see John series in the branch... It's there now.
On 2/20/22 10:31, Martin K. Petersen wrote: > > Damien, > >>> Applied to 5.18/scsi-staging, thanks! >> >> Did you push this ? I do not see John series in the branch... > > It's there now. > Got it. Thanks !
On 19/02/2022 21:53, Martin K. Petersen wrote: > Damien, > >> This series and my pm8001 series have a conflict. When applying the >> pm8001 patches on top of these libsas changes, patch 28 has a fairly >> easy to resolve conflict. Let me know if you want me to send a v6 >> rebased on top of this. > "fairly easy to resolve", huh? Sure, if you manually rework the entire > patch. > > Please send me an updated version of #28. The rest of the series is > fine... Thanks Martin and Damien. I'll mention potential conflicts in my cover letters in future to help co-ordinate things better. John