| Message ID | 20220218015136.1.I5dbf50eb1a7a6734ee727bda4a8573358c6d3ec0@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] HID: Add mapping for KEY_DICTATE | expand |
On Fri, Feb 18, 2022 at 01:51:45AM +0000, William Mahon wrote: > Numerous keyboards are adding dictate keys which allows for text > messages to be dicated by a microphone. > > This patch adds a new key definition KEY_DICTATE and maps 0x0c/0x0d8 > usage code to this new keycode. Additionally hid-debug is adjusted to > recognize this new usage code as well. > > Signed-off-by: William Mahon <wmahon@google.com> > --- > > drivers/hid/hid-debug.c | 1 + > drivers/hid/hid-input.c | 1 + > include/uapi/linux/input-event-codes.h | 2 ++ > 3 files changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index 26c31d759914..8aa68416b1d7 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -969,6 +969,7 @@ static const char *keys[KEY_MAX + 1] = { > [KEY_ASSISTANT] = "Assistant", > [KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext", > [KEY_EMOJI_PICKER] = "EmojiPicker", > + [KEY_DICTATE] = "Dictate", > [KEY_BRIGHTNESS_MIN] = "BrightnessMin", > [KEY_BRIGHTNESS_MAX] = "BrightnessMax", > [KEY_BRIGHTNESS_AUTO] = "BrightnessAuto", > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index 112901d2d8d2..ce2b75a67cb8 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -992,6 +992,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel > case 0x0cd: map_key_clear(KEY_PLAYPAUSE); break; > case 0x0cf: map_key_clear(KEY_VOICECOMMAND); break; > > + case 0x0d8: map_key_clear(KEY_DICTATE); break; > case 0x0d9: map_key_clear(KEY_EMOJI_PICKER); break; > > case 0x0e0: map_abs_clear(ABS_VOLUME); break; > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 225ec87d4f22..9aa994cbcd60 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -660,6 +660,8 @@ > /* Select an area of screen to be copied */ > #define KEY_SELECTIVE_SCREENSHOT 0x27a > > +#define KEY_DICTATE 0x27b Please use 0x24a keycode, move after KEY_EMOJI_PICKER definition, and add a comment: /* Start or Stop Voice Dictation Session (HUTRR99) */ Thanks.
Hi On Fri, Feb 18, 2022 at 2:55 AM William Mahon <wmahon@chromium.org> wrote: > > Numerous keyboards are adding dictate keys which allows for text > messages to be dicated by a microphone. You have missed one typo here, s/dicated/dictated/. Cheers, Silvan
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c index 26c31d759914..8aa68416b1d7 100644 --- a/drivers/hid/hid-debug.c +++ b/drivers/hid/hid-debug.c @@ -969,6 +969,7 @@ static const char *keys[KEY_MAX + 1] = { [KEY_ASSISTANT] = "Assistant", [KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext", [KEY_EMOJI_PICKER] = "EmojiPicker", + [KEY_DICTATE] = "Dictate", [KEY_BRIGHTNESS_MIN] = "BrightnessMin", [KEY_BRIGHTNESS_MAX] = "BrightnessMax", [KEY_BRIGHTNESS_AUTO] = "BrightnessAuto", diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index 112901d2d8d2..ce2b75a67cb8 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -992,6 +992,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel case 0x0cd: map_key_clear(KEY_PLAYPAUSE); break; case 0x0cf: map_key_clear(KEY_VOICECOMMAND); break; + case 0x0d8: map_key_clear(KEY_DICTATE); break; case 0x0d9: map_key_clear(KEY_EMOJI_PICKER); break; case 0x0e0: map_abs_clear(ABS_VOLUME); break; diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h index 225ec87d4f22..9aa994cbcd60 100644 --- a/include/uapi/linux/input-event-codes.h +++ b/include/uapi/linux/input-event-codes.h @@ -660,6 +660,8 @@ /* Select an area of screen to be copied */ #define KEY_SELECTIVE_SCREENSHOT 0x27a +#define KEY_DICTATE 0x27b + /* * Some keyboards have keys which do not have a defined meaning, these keys * are intended to be programmed / bound to macros by the user. For most
Numerous keyboards are adding dictate keys which allows for text messages to be dicated by a microphone. This patch adds a new key definition KEY_DICTATE and maps 0x0c/0x0d8 usage code to this new keycode. Additionally hid-debug is adjusted to recognize this new usage code as well. Signed-off-by: William Mahon <wmahon@google.com> --- drivers/hid/hid-debug.c | 1 + drivers/hid/hid-input.c | 1 + include/uapi/linux/input-event-codes.h | 2 ++ 3 files changed, 4 insertions(+)