diff mbox series

[v2,17/23] arm64: dts: mt8192: Add vcodec lat and core nodes

Message ID 20220218091633.9368-18-allen-kh.cheng@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Add driver nodes for MT8192 SoC | expand

Commit Message

Allen-KH Cheng Feb. 18, 2022, 9:16 a.m. UTC
Add vcodec lat and core nodes for mt8192 SoC.

Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

Comments

AngeloGioacchino Del Regno Feb. 18, 2022, 12:56 p.m. UTC | #1
Il 18/02/22 10:16, Allen-KH Cheng ha scritto:
> Add vcodec lat and core nodes for mt8192 SoC.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++
>   1 file changed, 58 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 936aa788664f..543a80252ce5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -1291,6 +1291,64 @@
>   			power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>;
>   		};
>   
> +		vcodec_dec: vcodec_dec@16000000 {
> +			compatible = "mediatek,mt8192-vcodec-dec";
> +			reg = <0 0x16000000 0 0x1000>;		/* VDEC_SYS */
> +			mediatek,scp = <&scp>;
> +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
> +		};
> +
> +		vcodec_lat: vcodec_lat@0x16010000 {
> +			compatible = "mediatek,mtk-vcodec-lat";
> +			reg = <0 0x16010000 0 0x800>;		/* VDEC_MISC */
> +			interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
> +			iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,

Please fix indentation!

			iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,

				 <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,

				 <&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,

... etc.

> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
> +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_VDEC>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_LAT>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_LARB1>,
> +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> +			clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec",
> +				      "vdec-top";
> +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> +			assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
> +			power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
> +		};
> +
> +		vcodec_core: vcodec_core@0x16025000 {
> +			compatible = "mediatek,mtk-vcodec-core";
> +			reg = <0 0x16025000 0 0x1000>;		/* VDEC_CORE_MISC */
> +			interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>;
> +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_UFO_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_PP_EXT>,

ditto.

> +				<&iommu0 M4U_PORT_L4_VDEC_PRED_RD_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_PRED_WR_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_PPWRAP_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_TILE_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_VLD_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_VLD2_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_AVC_MV_EXT>,
> +				<&iommu0 M4U_PORT_L4_VDEC_RG_CTRL_DMA_EXT>;
> +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> +				 <&vdecsys CLK_VDEC_VDEC>,
> +				 <&vdecsys CLK_VDEC_LAT>,
> +				 <&vdecsys CLK_VDEC_LARB1>,
> +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> +			clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec",
> +				      "vdec-top";
> +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> +			assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
> +			power-domains = <&spm MT8192_POWER_DOMAIN_VDEC2>;
> +		};
> +
>   		larb5: larb@1600d000 {
>   			compatible = "mediatek,mt8192-smi-larb";
>   			reg = <0 0x1600d000 0 0x1000>;
Allen-KH Cheng Feb. 21, 2022, 1:10 p.m. UTC | #2
On Fri, 2022-02-18 at 13:56 +0100, AngeloGioacchino Del Regno wrote:
> Il 18/02/22 10:16, Allen-KH Cheng ha scritto:
> > Add vcodec lat and core nodes for mt8192 SoC.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58
> > ++++++++++++++++++++++++
> >   1 file changed, 58 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index 936aa788664f..543a80252ce5 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > @@ -1291,6 +1291,64 @@
> >   			power-domains = <&spm
> > MT8192_POWER_DOMAIN_ISP2>;
> >   		};
> >   
> > +		vcodec_dec: vcodec_dec@16000000 {
> > +			compatible = "mediatek,mt8192-vcodec-dec";
> > +			reg = <0 0x16000000 0 0x1000>;		/*
> > VDEC_SYS */
> > +			mediatek,scp = <&scp>;
> > +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
> > +		};
> > +
> > +		vcodec_lat: vcodec_lat@0x16010000 {
> > +			compatible = "mediatek,mtk-vcodec-lat";
> > +			reg = <0 0x16010000 0 0x800>;		/*
> > VDEC_MISC */
> > +			interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > +			iommus = <&iommu0
> > M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
> 
> Please fix indentation!
> 
> 			iommus = <&iommu0
> M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
> 
> 				 <&iommu0
> M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
> 
> 				 <&iommu0
> M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
> 
> ... etc.
> 

Hi Angelo,

My neglect for indentation. 

I will fix this in next versionn.

Many thanks,
Allen

> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
> > +				<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
> > +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_VDEC>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_LAT>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_LARB1>,
> > +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> > +			clock-names = "vdec-sel", "vdec-soc-vdec",
> > "vdec-soc-lat", "vdec-vdec",
> > +				      "vdec-top";
> > +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> > +			assigned-clock-parents = <&topckgen
> > CLK_TOP_MAINPLL_D4>;
> > +			power-domains = <&spm
> > MT8192_POWER_DOMAIN_VDEC>;
> > +		};
> > +
> > +		vcodec_core: vcodec_core@0x16025000 {
> > +			compatible = "mediatek,mtk-vcodec-core";
> > +			reg = <0 0x16025000 0 0x1000>;		/*
> > VDEC_CORE_MISC */
> > +			interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_UFO_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_PP_EXT>,
> 
> ditto.
> 
> > +				<&iommu0 M4U_PORT_L4_VDEC_PRED_RD_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_PRED_WR_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_PPWRAP_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_TILE_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_VLD_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_VLD2_EXT>,
> > +				<&iommu0 M4U_PORT_L4_VDEC_AVC_MV_EXT>,
> > +				<&iommu0
> > M4U_PORT_L4_VDEC_RG_CTRL_DMA_EXT>;
> > +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> > +				 <&vdecsys CLK_VDEC_VDEC>,
> > +				 <&vdecsys CLK_VDEC_LAT>,
> > +				 <&vdecsys CLK_VDEC_LARB1>,
> > +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> > +			clock-names = "vdec-sel", "vdec-soc-vdec",
> > "vdec-soc-lat", "vdec-vdec",
> > +				      "vdec-top";
> > +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> > +			assigned-clock-parents = <&topckgen
> > CLK_TOP_MAINPLL_D4>;
> > +			power-domains = <&spm
> > MT8192_POWER_DOMAIN_VDEC2>;
> > +		};
> > +
> >   		larb5: larb@1600d000 {
> >   			compatible = "mediatek,mt8192-smi-larb";
> >   			reg = <0 0x1600d000 0 0x1000>;
> 
>
Nícolas F. R. A. Prado Feb. 22, 2022, 10:33 p.m. UTC | #3
On Fri, Feb 18, 2022 at 05:16:27PM +0800, Allen-KH Cheng wrote:
> Add vcodec lat and core nodes for mt8192 SoC.
> 
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58 ++++++++++++++++++++++++
>  1 file changed, 58 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 936aa788664f..543a80252ce5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -1291,6 +1291,64 @@
>  			power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>;
>  		};
>  
> +		vcodec_dec: vcodec_dec@16000000 {

It's usually preferred to use '-' instead of '_' in the node name, like:

		vcodec_dec: vcodec-dec@16000000 {

Same thing for the other vcodec nodes below.

But more importantly, the Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
dt-binding shows the mtk-vcodec-lat and mtk-vcodec-core as subnodes of
vcodec-dec. So I would follow that same structure here. Unless it does make more
sense to have the nodes separate like this, but in that case the dt-binding
should be updated.

> +			compatible = "mediatek,mt8192-vcodec-dec";
> +			reg = <0 0x16000000 0 0x1000>;		/* VDEC_SYS */
> +			mediatek,scp = <&scp>;
> +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
> +		};
> +
> +		vcodec_lat: vcodec_lat@0x16010000 {

Again, please drop the '0x' prefix.

> +			compatible = "mediatek,mtk-vcodec-lat";
> +			reg = <0 0x16010000 0 0x800>;		/* VDEC_MISC */
> +			interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
> +			iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
> +				<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
> +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_VDEC>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_LAT>,
> +				 <&vdecsys_soc CLK_VDEC_SOC_LARB1>,
> +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> +			clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec",
> +				      "vdec-top";
> +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> +			assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
> +			power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
> +		};
> +
> +		vcodec_core: vcodec_core@0x16025000 {

Ditto.
Allen-KH Cheng Feb. 23, 2022, 1:39 p.m. UTC | #4
On Tue, 2022-02-22 at 17:33 -0500, Nícolas F. R. A. Prado wrote:
> On Fri, Feb 18, 2022 at 05:16:27PM +0800, Allen-KH Cheng wrote:
> > Add vcodec lat and core nodes for mt8192 SoC.
> > 
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 58
> > ++++++++++++++++++++++++
> >  1 file changed, 58 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index 936aa788664f..543a80252ce5 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > @@ -1291,6 +1291,64 @@
> >  			power-domains = <&spm
> > MT8192_POWER_DOMAIN_ISP2>;
> >  		};
> >  
> > +		vcodec_dec: vcodec_dec@16000000 {
> 
> It's usually preferred to use '-' instead of '_' in the node name,
> like:
> 
> 		vcodec_dec: vcodec-dec@16000000 {
> 
> Same thing for the other vcodec nodes below.
> 
> But more importantly, the
> Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> decoder.yaml
> dt-binding shows the mtk-vcodec-lat and mtk-vcodec-core as subnodes
> of
> vcodec-dec. So I would follow that same structure here. Unless it
> does make more
> sense to have the nodes separate like this, but in that case the dt-
> binding
> should be updated.
> 
Hi Nícolas

I think it's ok set mtk-vcodec-lat and mtk-vcodec-core as subnodes of
vcodec-dec.

I will retest in mt8192 product and make sure this works.

Many thanks,
Allen

> > +			compatible = "mediatek,mt8192-vcodec-dec";
> > +			reg = <0 0x16000000 0 0x1000>;		/*
> > VDEC_SYS */
> > +			mediatek,scp = <&scp>;
> > +			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
> > +		};
> > +
> > +		vcodec_lat: vcodec_lat@0x16010000 {
> 
> Again, please drop the '0x' prefix.
> 
> > +			compatible = "mediatek,mtk-vcodec-lat";
> > +			reg = <0 0x16010000 0 0x800>;		/*
> > VDEC_MISC */
> > +			interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH
> > 0>;
> > +			iommus = <&iommu0
> > M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
> > +				<&iommu0
> > M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
> > +				<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
> > +			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_VDEC>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_LAT>,
> > +				 <&vdecsys_soc CLK_VDEC_SOC_LARB1>,
> > +				 <&topckgen CLK_TOP_MAINPLL_D4>;
> > +			clock-names = "vdec-sel", "vdec-soc-vdec",
> > "vdec-soc-lat", "vdec-vdec",
> > +				      "vdec-top";
> > +			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
> > +			assigned-clock-parents = <&topckgen
> > CLK_TOP_MAINPLL_D4>;
> > +			power-domains = <&spm
> > MT8192_POWER_DOMAIN_VDEC>;
> > +		};
> > +
> > +		vcodec_core: vcodec_core@0x16025000 {
> 
> Ditto.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index 936aa788664f..543a80252ce5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -1291,6 +1291,64 @@ 
 			power-domains = <&spm MT8192_POWER_DOMAIN_ISP2>;
 		};
 
+		vcodec_dec: vcodec_dec@16000000 {
+			compatible = "mediatek,mt8192-vcodec-dec";
+			reg = <0 0x16000000 0 0x1000>;		/* VDEC_SYS */
+			mediatek,scp = <&scp>;
+			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>;
+		};
+
+		vcodec_lat: vcodec_lat@0x16010000 {
+			compatible = "mediatek,mtk-vcodec-lat";
+			reg = <0 0x16010000 0 0x800>;		/* VDEC_MISC */
+			interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH 0>;
+			iommus = <&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_VLD2_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_AVC_MV_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_PRED_RD_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_TILE_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_WDMA_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_LAT0_RG_CTRL_DMA_EXT>,
+				<&iommu0 M4U_PORT_L5_VDEC_UFO_ENC_EXT>;
+			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
+				 <&vdecsys_soc CLK_VDEC_SOC_VDEC>,
+				 <&vdecsys_soc CLK_VDEC_SOC_LAT>,
+				 <&vdecsys_soc CLK_VDEC_SOC_LARB1>,
+				 <&topckgen CLK_TOP_MAINPLL_D4>;
+			clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec",
+				      "vdec-top";
+			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
+			assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
+			power-domains = <&spm MT8192_POWER_DOMAIN_VDEC>;
+		};
+
+		vcodec_core: vcodec_core@0x16025000 {
+			compatible = "mediatek,mtk-vcodec-core";
+			reg = <0 0x16025000 0 0x1000>;		/* VDEC_CORE_MISC */
+			interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH 0>;
+			iommus = <&iommu0 M4U_PORT_L4_VDEC_MC_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_UFO_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_PP_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_PRED_RD_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_PRED_WR_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_PPWRAP_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_TILE_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_VLD_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_VLD2_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_AVC_MV_EXT>,
+				<&iommu0 M4U_PORT_L4_VDEC_RG_CTRL_DMA_EXT>;
+			clocks = <&topckgen CLK_TOP_VDEC_SEL>,
+				 <&vdecsys CLK_VDEC_VDEC>,
+				 <&vdecsys CLK_VDEC_LAT>,
+				 <&vdecsys CLK_VDEC_LARB1>,
+				 <&topckgen CLK_TOP_MAINPLL_D4>;
+			clock-names = "vdec-sel", "vdec-soc-vdec", "vdec-soc-lat", "vdec-vdec",
+				      "vdec-top";
+			assigned-clocks = <&topckgen CLK_TOP_VDEC_SEL>;
+			assigned-clock-parents = <&topckgen CLK_TOP_MAINPLL_D4>;
+			power-domains = <&spm MT8192_POWER_DOMAIN_VDEC2>;
+		};
+
 		larb5: larb@1600d000 {
 			compatible = "mediatek,mt8192-smi-larb";
 			reg = <0 0x1600d000 0 0x1000>;