| Message ID | 20220220040718.532866-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: simple: Fix Innolux G070Y2-L01 BPP settings | expand |
Hi Marek, Thank you for the patch. On Sun, Feb 20, 2022 at 05:07:18AM +0100, Marek Vasut wrote: > The Innolux G070Y2-L01 supports two modes of operation: > 1) FRC=Low/NC ... MEDIA_BUS_FMT_RGB666_1X7X3_SPWG ... BPP=6 > 2) FRC=High ..... MEDIA_BUS_FMT_RGB888_1X7X4_SPWG ... BPP=8 > > Currently the panel description mixes both, BPP from 1) and bus > format from 2), which triggers a warning at panel-simple.c:615. > > Pick the later, set bpp=8, fix the warning. > > Fixes: a5d2ade627dca ("drm/panel: simple: Add support for Innolux G070Y2-L01") > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Christoph Fritz <chf.fritz@googlemail.com> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Maxime Ripard <maxime@cerno.tech> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 49e56adff6226..4405a9dc7574f 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2137,7 +2137,7 @@ static const struct display_timing innolux_g070y2_l01_timing = { > static const struct panel_desc innolux_g070y2_l01 = { > .timings = &innolux_g070y2_l01_timing, > .num_timings = 1, > - .bpc = 6, > + .bpc = 8, > .size = { > .width = 152, > .height = 91,
On 2/20/22 05:52, Laurent Pinchart wrote: > Hi Marek, > > Thank you for the patch. > > On Sun, Feb 20, 2022 at 05:07:18AM +0100, Marek Vasut wrote: >> The Innolux G070Y2-L01 supports two modes of operation: >> 1) FRC=Low/NC ... MEDIA_BUS_FMT_RGB666_1X7X3_SPWG ... BPP=6 >> 2) FRC=High ..... MEDIA_BUS_FMT_RGB888_1X7X4_SPWG ... BPP=8 >> >> Currently the panel description mixes both, BPP from 1) and bus >> format from 2), which triggers a warning at panel-simple.c:615. >> >> Pick the later, set bpp=8, fix the warning. >> >> Fixes: a5d2ade627dca ("drm/panel: simple: Add support for Innolux G070Y2-L01") >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Christoph Fritz <chf.fritz@googlemail.com> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> >> Cc: Maxime Ripard <maxime@cerno.tech> >> Cc: Sam Ravnborg <sam@ravnborg.org> >> Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Applied to drm-misc-next-fixes
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 49e56adff6226..4405a9dc7574f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2137,7 +2137,7 @@ static const struct display_timing innolux_g070y2_l01_timing = { static const struct panel_desc innolux_g070y2_l01 = { .timings = &innolux_g070y2_l01_timing, .num_timings = 1, - .bpc = 6, + .bpc = 8, .size = { .width = 152, .height = 91,
The Innolux G070Y2-L01 supports two modes of operation: 1) FRC=Low/NC ... MEDIA_BUS_FMT_RGB666_1X7X3_SPWG ... BPP=6 2) FRC=High ..... MEDIA_BUS_FMT_RGB888_1X7X4_SPWG ... BPP=8 Currently the panel description mixes both, BPP from 1) and bus format from 2), which triggers a warning at panel-simple.c:615. Pick the later, set bpp=8, fix the warning. Fixes: a5d2ade627dca ("drm/panel: simple: Add support for Innolux G070Y2-L01") Signed-off-by: Marek Vasut <marex@denx.de> Cc: Christoph Fritz <chf.fritz@googlemail.com> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)