| Message ID | 20220218091633.9368-20-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add driver nodes for MT8192 SoC | expand |
Il 18/02/22 10:16, Allen-KH Cheng ha scritto: > Add i2c aliases for mt8192 SoC > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 55bcbf72a366..e3314cdc7c1a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -21,6 +21,19 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > + i2c9 = &i2c9; > + }; > + > clk26m: oscillator0 { > compatible = "fixed-clock"; > #clock-cells = <0>;
Hi, On Fri, Feb 18, 2022 at 5:16 PM Allen-KH Cheng <allen-kh.cheng@mediatek.com> wrote: > > Add i2c aliases for mt8192 SoC > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index 55bcbf72a366..e3314cdc7c1a 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > @@ -21,6 +21,19 @@ > #address-cells = <2>; > #size-cells = <2>; > > + aliases { > + i2c0 = &i2c0; > + i2c1 = &i2c1; > + i2c2 = &i2c2; > + i2c3 = &i2c3; > + i2c4 = &i2c4; > + i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > + i2c9 = &i2c9; AFAIK, maintainers have suggested against [1] having aliases in the .dtsi. If the numbering isn't an issue, I suggest just dropping it altogether. If it is, then the aliases should be added at the board level, and only for the interfaces that are actually enabled. ChenYu [1] https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@mail.gmail.com/ > + }; > + > clk26m: oscillator0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > -- > 2.18.0 >
On Mon, 2022-02-21 at 12:50 +0800, Chen-Yu Tsai wrote: > Hi, > > On Fri, Feb 18, 2022 at 5:16 PM Allen-KH Cheng > <allen-kh.cheng@mediatek.com> wrote: > > > > Add i2c aliases for mt8192 SoC > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 55bcbf72a366..e3314cdc7c1a 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -21,6 +21,19 @@ > > #address-cells = <2>; > > #size-cells = <2>; > > > > + aliases { > > + i2c0 = &i2c0; > > + i2c1 = &i2c1; > > + i2c2 = &i2c2; > > + i2c3 = &i2c3; > > + i2c4 = &i2c4; > > + i2c5 = &i2c5; > > + i2c6 = &i2c6; > > + i2c7 = &i2c7; > > + i2c8 = &i2c8; > > + i2c9 = &i2c9; > > AFAIK, maintainers have suggested against [1] having aliases in the > .dtsi. > > If the numbering isn't an issue, I suggest just dropping it > altogether. > If it is, then the aliases should be added at the board level, and > only > for the interfaces that are actually enabled. > > ChenYu > > [1] > https://urldefense.com/v3/__https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@mail.gmail.com/__;!!CTRNKA9wMg0ARbw!xXnhgMJXr_7T7q0dG965vVaZ-J2bDtpVWRouWVk5SjGO2f53HHesM8fhh1srbsWobbPCJrG-mqx6_dVs1Cfs2Njl4w$ > Hi ChenYu, Thanks for suggestion. I will move this part to board level. Best regards, Allen > > > + }; > > + > > clk26m: oscillator0 { > > compatible = "fixed-clock"; > > #clock-cells = <0>; > > -- > > 2.18.0 > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 55bcbf72a366..e3314cdc7c1a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi @@ -21,6 +21,19 @@ #address-cells = <2>; #size-cells = <2>; + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; + i2c9 = &i2c9; + }; + clk26m: oscillator0 { compatible = "fixed-clock"; #clock-cells = <0>;
Add i2c aliases for mt8192 SoC Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)