| Message ID | 20220216225304.53911-7-djrscally@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add multiple-consumer support to int3472-tps68470 driver | expand |
Hi, On 2/16/22 23:53, Daniel Scally wrote: > Add the board data describing the regulators for the Microsoft > Surface Go line's IR camera. > > Signed-off-by: Daniel Scally <djrscally@gmail.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > .../x86/intel/int3472/tps68470_board_data.c | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 442a8a2de224..49a3591c6d85 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -30,6 +30,15 @@ static struct regulator_consumer_supply int347a_vcm_consumer_supplies[] = { > static struct regulator_consumer_supply int347a_vsio_consumer_supplies[] = { > REGULATOR_SUPPLY("dovdd", "i2c-INT347A:00"), > REGULATOR_SUPPLY("vsio", "i2c-INT347A:00-VCM"), > + REGULATOR_SUPPLY("vddd", "i2c-INT347E:00"), > +}; > + > +static struct regulator_consumer_supply int347a_aux1_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdda", "i2c-INT347E:00"), > +}; > + > +static struct regulator_consumer_supply int347a_aux2_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdddo", "i2c-INT347E:00"), > }; > > static const struct regulator_init_data surface_go_tps68470_core_reg_init_data = { > @@ -86,6 +95,28 @@ static const struct regulator_init_data surface_go_tps68470_vsio_reg_init_data = > .consumer_supplies = int347a_vsio_consumer_supplies, > }; > > +static const struct regulator_init_data surface_go_tps68470_aux1_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int347a_aux1_consumer_supplies), > + .consumer_supplies = int347a_aux1_consumer_supplies, > +}; > + > +static const struct regulator_init_data surface_go_tps68470_aux2_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int347a_aux2_consumer_supplies), > + .consumer_supplies = int347a_aux2_consumer_supplies, > +}; > + > static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = { > .reg_init_data = { > [TPS68470_CORE] = &surface_go_tps68470_core_reg_init_data, > @@ -93,6 +124,8 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = > [TPS68470_VCM] = &surface_go_tps68470_vcm_reg_init_data, > [TPS68470_VIO] = &surface_go_tps68470_vio_reg_init_data, > [TPS68470_VSIO] = &surface_go_tps68470_vsio_reg_init_data, > + [TPS68470_AUX1] = &surface_go_tps68470_aux1_reg_init_data, > + [TPS68470_AUX2] = &surface_go_tps68470_aux2_reg_init_data, > }, > }; >
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c index 442a8a2de224..49a3591c6d85 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -30,6 +30,15 @@ static struct regulator_consumer_supply int347a_vcm_consumer_supplies[] = { static struct regulator_consumer_supply int347a_vsio_consumer_supplies[] = { REGULATOR_SUPPLY("dovdd", "i2c-INT347A:00"), REGULATOR_SUPPLY("vsio", "i2c-INT347A:00-VCM"), + REGULATOR_SUPPLY("vddd", "i2c-INT347E:00"), +}; + +static struct regulator_consumer_supply int347a_aux1_consumer_supplies[] = { + REGULATOR_SUPPLY("vdda", "i2c-INT347E:00"), +}; + +static struct regulator_consumer_supply int347a_aux2_consumer_supplies[] = { + REGULATOR_SUPPLY("vdddo", "i2c-INT347E:00"), }; static const struct regulator_init_data surface_go_tps68470_core_reg_init_data = { @@ -86,6 +95,28 @@ static const struct regulator_init_data surface_go_tps68470_vsio_reg_init_data = .consumer_supplies = int347a_vsio_consumer_supplies, }; +static const struct regulator_init_data surface_go_tps68470_aux1_reg_init_data = { + .constraints = { + .min_uV = 2815200, + .max_uV = 2815200, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(int347a_aux1_consumer_supplies), + .consumer_supplies = int347a_aux1_consumer_supplies, +}; + +static const struct regulator_init_data surface_go_tps68470_aux2_reg_init_data = { + .constraints = { + .min_uV = 1800600, + .max_uV = 1800600, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(int347a_aux2_consumer_supplies), + .consumer_supplies = int347a_aux2_consumer_supplies, +}; + static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = { .reg_init_data = { [TPS68470_CORE] = &surface_go_tps68470_core_reg_init_data, @@ -93,6 +124,8 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = [TPS68470_VCM] = &surface_go_tps68470_vcm_reg_init_data, [TPS68470_VIO] = &surface_go_tps68470_vio_reg_init_data, [TPS68470_VSIO] = &surface_go_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] = &surface_go_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] = &surface_go_tps68470_aux2_reg_init_data, }, };
Add the board data describing the regulators for the Microsoft Surface Go line's IR camera. Signed-off-by: Daniel Scally <djrscally@gmail.com> --- .../x86/intel/int3472/tps68470_board_data.c | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+)