mbox series

[kvm-unit-tests,v2,0/8] s390x: Extend instruction interception tests

Message ID 20220221130746.1754410-1-nrb@linux.ibm.com (mailing list archive)
Headers show
Series s390x: Extend instruction interception tests | expand

Message

Nico Boehr Feb. 21, 2022, 1:07 p.m. UTC 
This series extends the instruction interception tests for s390x.

For most instructions, there is already coverage in existing tests, but they are
not covering some failure cases, e.g. bad alignment. In this case, the existing
tests were extended.

SCK was not under test anywhere yet, hence a new test file was added.

The EPSW test gets it's own file, too, because it requires a I/O device, more
details in the respective commit. 

Changelog from v1:
----
- Reset pmcw flags at test end
- Rebase

Nico Boehr (8):
  s390x: Add more tests for MSCH
  s390x: Add test for PFMF low-address protection
  s390x: Add sck tests
  s390x: Add tests for STCRW
  s390x: Add more tests for SSCH
  s390x: Add more tests for STSCH
  s390x: Add tests for TSCH
  s390x: Add EPSW test

 lib/s390x/css.h     |  17 +++
 lib/s390x/css_lib.c |  60 ++++++++++
 s390x/Makefile      |   2 +
 s390x/css.c         | 278 ++++++++++++++++++++++++++++++++++++++++++++
 s390x/epsw.c        | 113 ++++++++++++++++++
 s390x/pfmf.c        |  29 +++++
 s390x/sck.c         | 127 ++++++++++++++++++++
 s390x/unittests.cfg |   7 ++
 8 files changed, 633 insertions(+)
 create mode 100644 s390x/epsw.c
 create mode 100644 s390x/sck.c

Comments

Janosch Frank Feb. 21, 2022, 3:30 p.m. UTC | #1 
On 2/21/22 14:07, Nico Boehr wrote:
> This series extends the instruction interception tests for s390x.
> 
> For most instructions, there is already coverage in existing tests, but they are
> not covering some failure cases, e.g. bad alignment. In this case, the existing
> tests were extended.
> 
> SCK was not under test anywhere yet, hence a new test file was added.
> 
> The EPSW test gets it's own file, too, because it requires a I/O device, more
> details in the respective commit.

Could you please push this to devel so we can get CI data?

To me it seems like only STSCH needs review so we should be done with 
this soonish.


> 
> Changelog from v1:
> ----
> - Reset pmcw flags at test end
> - Rebase
> 
> Nico Boehr (8):
>    s390x: Add more tests for MSCH
>    s390x: Add test for PFMF low-address protection
>    s390x: Add sck tests
>    s390x: Add tests for STCRW
>    s390x: Add more tests for SSCH
>    s390x: Add more tests for STSCH
>    s390x: Add tests for TSCH
>    s390x: Add EPSW test
> 
>   lib/s390x/css.h     |  17 +++
>   lib/s390x/css_lib.c |  60 ++++++++++
>   s390x/Makefile      |   2 +
>   s390x/css.c         | 278 ++++++++++++++++++++++++++++++++++++++++++++
>   s390x/epsw.c        | 113 ++++++++++++++++++
>   s390x/pfmf.c        |  29 +++++
>   s390x/sck.c         | 127 ++++++++++++++++++++
>   s390x/unittests.cfg |   7 ++
>   8 files changed, 633 insertions(+)
>   create mode 100644 s390x/epsw.c
>   create mode 100644 s390x/sck.c
>
Nico Boehr Feb. 23, 2022, 9:18 a.m. UTC | #2 
On Mon, 2022-02-21 at 16:30 +0100, Janosch Frank wrote:
> Could you please push this to devel so we can get CI data?

Thanks Janosch, we found an issue in the CI. A fix is in the making.