| Message ID | 1643178713-17178-9-git-send-email-quic_fenglinw@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | A bunch of fix and optimization patches in spmi-pmic-arb.c | expand |
On Wed, Jan 26, 2022 at 02:31:50PM +0800, Fenglin Wu wrote: > From: David Collins <collinsd@codeaurora.org> > > Mark all interrupt related properties as optional instead of > required. Some boards do not required PMIC IRQ support and it > isn't needed to handle SPMI bus transactions, so specify it as > optional. > > Signed-off-by: David Collins <collinsd@codeaurora.org> > Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> > --- > Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt | 2 ++ > 1 file changed, 2 insertions(+) This will collide with converting it to DT schema[1]. Rob [1] https://lore.kernel.org/all/20220131172450.2528065-2-vkoul@kernel.org/
On 2022/2/5 6:36, Rob Herring wrote: > On Wed, Jan 26, 2022 at 02:31:50PM +0800, Fenglin Wu wrote: >> From: David Collins <collinsd@codeaurora.org> >> >> Mark all interrupt related properties as optional instead of >> required. Some boards do not required PMIC IRQ support and it >> isn't needed to handle SPMI bus transactions, so specify it as >> optional. >> >> Signed-off-by: David Collins <collinsd@codeaurora.org> >> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com> >> --- >> Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt | 2 ++ >> 1 file changed, 2 insertions(+) > > This will collide with converting it to DT schema[1]. > > Rob > > [1] https://lore.kernel.org/all/20220131172450.2528065-2-vkoul@kernel.org/ Noticed that, I just didn't know which one would get merged 1st. I can update it once the DT schema change get accepted and be present in spmi-next branch.
diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt index ca645e2..6332507 100644 --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.txt @@ -29,6 +29,8 @@ Required properties: - #size-cells : must be set to 0 - qcom,ee : indicates the active Execution Environment identifier (0-5) - qcom,channel : which of the PMIC Arb provided channels to use for accesses (0-5) + +Optional properties: - interrupts : interrupt list for the PMIC Arb controller, must contain a single interrupt entry for the peripheral interrupt - interrupt-names : corresponding interrupt names for the interrupts