diff mbox series

mips: setup: fix setnocoherentio() boolean setting

Message ID 20220221175029.6046-1-rdunlap@infradead.org (mailing list archive)
State Accepted
Commit 1e6ae0e46e32749b130f1823da30cea9aa2a59a0
Headers show
Series mips: setup: fix setnocoherentio() boolean setting | expand

Commit Message

Randy Dunlap Feb. 21, 2022, 5:50 p.m. UTC
Correct a typo/pasto: setnocoherentio() should set
dma_default_coherent to false, not true.

Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
---
 arch/mips/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Feb. 22, 2022, 8:04 a.m. UTC | #1
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Thomas Bogendoerfer Feb. 22, 2022, 8:43 a.m. UTC | #2
On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote:
> Correct a typo/pasto: setnocoherentio() should set
> dma_default_coherent to false, not true.
> 
> Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> ---
>  arch/mips/kernel/setup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20220217.orig/arch/mips/kernel/setup.c
> +++ linux-next-20220217/arch/mips/kernel/setup.c
> @@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio)
>  
>  static int __init setnocoherentio(char *str)
>  {
> -	dma_default_coherent = true;
> +	dma_default_coherent = false;
>  	pr_info("Software DMA cache coherency (command line)\n");
>  	return 0;
>  }

applied to mips-fixes.

Thomas.
diff mbox series

Patch

--- linux-next-20220217.orig/arch/mips/kernel/setup.c
+++ linux-next-20220217/arch/mips/kernel/setup.c
@@ -803,7 +803,7 @@  early_param("coherentio", setcoherentio)
 
 static int __init setnocoherentio(char *str)
 {
-	dma_default_coherent = true;
+	dma_default_coherent = false;
 	pr_info("Software DMA cache coherency (command line)\n");
 	return 0;
 }