| Message ID | 20220221092740.25511-2-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/3] iio:amplifiers:ada4250: add support for ADA4250 | expand |
On 21/02/2022 10:27, Antoniu Miclaus wrote: > Add device tree bindings for the ADA4250 driver. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > changes in v4: > - add `spi-max-frequency` property > - use generic node naming > .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml > Please do not resend without fixing pointed out issues. It just looks you ignore comments. Please fix or respond to previous comments. Please also fix all common issues recently pointed out for all Analog devices - folks from Analog are making the same mistakes. Reviewing the same mistake is a bit a waste of time. Much more appreciated is when team applies one feedback to all its submissions. IOW, do not repeat the same mistake second time. Best regards, Krzysztof
-- Antoniu Miclăuş > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Monday, February 21, 2022 6:36 PM > To: Miclaus, Antoniu <Antoniu.Miclaus@analog.com>; jic23@kernel.org; > robh+dt@kernel.org; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 2/3] dt-bindings:iio:amplifiers: add ada4250 doc > > [External] > > On 21/02/2022 10:27, Antoniu Miclaus wrote: > > Add device tree bindings for the ADA4250 driver. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > --- > > changes in v4: > > - add `spi-max-frequency` property > > - use generic node naming > > .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml > > > > Please do not resend without fixing pointed out issues. It just looks > you ignore comments. > > Please fix or respond to previous comments. Please also fix all common > issues recently pointed out for all Analog devices - folks from Analog > are making the same mistakes. Reviewing the same mistake is a bit a > waste of time. Much more appreciated is when team applies one feedback > to all its submissions. IOW, do not repeat the same mistake second time. > > > Best regards, > Krzysztof I had a look over the previous comments and I saw that some of them were replied by Jonathan already, therefore I fixed only those that were still valid. Indeed I missed the "Please put the bindings patch as first in the series", my bad on that. Let me know if I missed anything else. Regards, Antoniu
On 22/02/2022 10:21, Miclaus, Antoniu wrote: >> >> Please do not resend without fixing pointed out issues. It just looks >> you ignore comments. >> >> Please fix or respond to previous comments. Please also fix all common >> issues recently pointed out for all Analog devices - folks from Analog >> are making the same mistakes. Reviewing the same mistake is a bit a >> waste of time. Much more appreciated is when team applies one feedback >> to all its submissions. IOW, do not repeat the same mistake second time. >> >> >> Best regards, >> Krzysztof > > I had a look over the previous comments and I saw that some of them were > replied by Jonathan already, therefore I fixed only those that were still valid. > Indeed I missed the "Please put the bindings patch as first in the series", > my bad on that. Let me know if I missed anything else. In this patchset you also missed spaces in the subject (after every ':' character). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml new file mode 100644 index 000000000000..3bb9539e2b49 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ADA4250 Programmable Gain Instrumentation Amplifier + +maintainers: + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: | + Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier. + +properties: + compatible: + enum: + - adi,ada4250 + + reg: + maxItems: 1 + + avdd-supply: true + + adi,refbuf-enable: + description: + Enable internal buffer to drive the reference pin. + type: boolean + + spi-max-frequency: true + +required: + - compatible + - reg + - avdd-supply + +additionalProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + amplifier@0{ + compatible = "adi,ada4250"; + reg = <0>; + avdd-supply = <&avdd>; + }; + }; +...
Add device tree bindings for the ADA4250 driver. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v4: - add `spi-max-frequency` property - use generic node naming .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml