| Message ID | a1e9902e84595a2088bcf4882691a8330640246b.1645558375.git.riteshh@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ext4: Improve FC trace events and discuss one FC failure | expand |
On Wed 23-02-22 02:04:09, Ritesh Harjani wrote: > Below commit removed all references of EXT4_FC_COMMIT_FAILED. > commit 0915e464cb274 ("ext4: simplify updating of fast commit stats") > > Just remove it since it is not used anymore. > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/fast_commit.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/fast_commit.h b/fs/ext4/fast_commit.h > index 02afa52e8e41..80414dcba6e1 100644 > --- a/fs/ext4/fast_commit.h > +++ b/fs/ext4/fast_commit.h > @@ -93,7 +93,6 @@ enum { > EXT4_FC_REASON_RENAME_DIR, > EXT4_FC_REASON_FALLOC_RANGE, > EXT4_FC_REASON_INODE_JOURNAL_DATA, > - EXT4_FC_COMMIT_FAILED, > EXT4_FC_REASON_MAX > }; > > -- > 2.31.1 >
Looks good. Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com> - Harshad On Wed, 23 Feb 2022 at 01:37, Jan Kara <jack@suse.cz> wrote: > > On Wed 23-02-22 02:04:09, Ritesh Harjani wrote: > > Below commit removed all references of EXT4_FC_COMMIT_FAILED. > > commit 0915e464cb274 ("ext4: simplify updating of fast commit stats") > > > > Just remove it since it is not used anymore. > > > > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> > > Sure. Feel free to add: > > Reviewed-by: Jan Kara <jack@suse.cz> > > Honza > > > --- > > fs/ext4/fast_commit.h | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/ext4/fast_commit.h b/fs/ext4/fast_commit.h > > index 02afa52e8e41..80414dcba6e1 100644 > > --- a/fs/ext4/fast_commit.h > > +++ b/fs/ext4/fast_commit.h > > @@ -93,7 +93,6 @@ enum { > > EXT4_FC_REASON_RENAME_DIR, > > EXT4_FC_REASON_FALLOC_RANGE, > > EXT4_FC_REASON_INODE_JOURNAL_DATA, > > - EXT4_FC_COMMIT_FAILED, > > EXT4_FC_REASON_MAX > > }; > > > > -- > > 2.31.1 > > > -- > Jan Kara <jack@suse.com> > SUSE Labs, CR
diff --git a/fs/ext4/fast_commit.h b/fs/ext4/fast_commit.h index 02afa52e8e41..80414dcba6e1 100644 --- a/fs/ext4/fast_commit.h +++ b/fs/ext4/fast_commit.h @@ -93,7 +93,6 @@ enum { EXT4_FC_REASON_RENAME_DIR, EXT4_FC_REASON_FALLOC_RANGE, EXT4_FC_REASON_INODE_JOURNAL_DATA, - EXT4_FC_COMMIT_FAILED, EXT4_FC_REASON_MAX };
Below commit removed all references of EXT4_FC_COMMIT_FAILED. commit 0915e464cb274 ("ext4: simplify updating of fast commit stats") Just remove it since it is not used anymore. Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com> --- fs/ext4/fast_commit.h | 1 - 1 file changed, 1 deletion(-)