| Message ID | 20220214200507.2500693-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint | expand |
Gentle ping for this patch :). It's an important fix to get the display working again on mt8183-kukui-jacuzzi, and also one of the requirements for us to get IGT running on that platform in KernelCI :). Thanks, Nícolas On Mon, Feb 14, 2022 at 03:05:07PM -0500, Nícolas F. R. A. Prado wrote: > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of > its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625: > add MIPI DPI input feature"), a bus-type property started being required > in the endpoint node by the driver to indicate whether it is DSI or DPI. > > Add the missing bus-type property and set it to 5 > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input > configured to DSI and the display pipeline can probe correctly. > > While at it, also set the data-lanes property that was also introduced > in that same commit, so that we don't rely on the default value. > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > v2: https://lore.kernel.org/all/20220201174643.843102-1-nfraprado@collabora.com > v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com > > Changes in v3: > - Added missing Reviewed-by > > Changes in v2: > - (thanks Rob) Use proper format when refering to commit in commit > message as pointed out by checkpatch > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 8f7bf33f607d..e8f133dc96b9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -171,6 +171,8 @@ port@0 { > > anx7625_in: endpoint { > remote-endpoint = <&dsi_out>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; > > -- > 2.35.1 > > > -- > To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
On 14/02/2022 21:05, Nícolas F. R. A. Prado wrote: > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of > its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625: > add MIPI DPI input feature"), a bus-type property started being required > in the endpoint node by the driver to indicate whether it is DSI or DPI. > > Add the missing bus-type property and set it to 5 > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input > configured to DSI and the display pipeline can probe correctly. > > While at it, also set the data-lanes property that was also introduced > in that same commit, so that we don't rely on the default value. > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > applied to to tree v5.17-fixes Thanks Matthias > --- > v2: https://lore.kernel.org/all/20220201174643.843102-1-nfraprado@collabora.com > v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com > > Changes in v3: > - Added missing Reviewed-by > > Changes in v2: > - (thanks Rob) Use proper format when refering to commit in commit > message as pointed out by checkpatch > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 8f7bf33f607d..e8f133dc96b9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -171,6 +171,8 @@ port@0 { > > anx7625_in: endpoint { > remote-endpoint = <&dsi_out>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; >
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 8f7bf33f607d..e8f133dc96b9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -171,6 +171,8 @@ port@0 { anx7625_in: endpoint { remote-endpoint = <&dsi_out>; + bus-type = <5>; + data-lanes = <0 1 2 3>; }; };
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of its DSI host. However, after commit fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature"), a bus-type property started being required in the endpoint node by the driver to indicate whether it is DSI or DPI. Add the missing bus-type property and set it to 5 (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input configured to DSI and the display pipeline can probe correctly. While at it, also set the data-lanes property that was also introduced in that same commit, so that we don't rely on the default value. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- v2: https://lore.kernel.org/all/20220201174643.843102-1-nfraprado@collabora.com v1: https://lore.kernel.org/all/20220120224204.773117-1-nfraprado@collabora.com Changes in v3: - Added missing Reviewed-by Changes in v2: - (thanks Rob) Use proper format when refering to commit in commit message as pointed out by checkpatch arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ 1 file changed, 2 insertions(+)