| Message ID | 20220222163144.1782447-4-kbusch@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | 64-bit data integrity field support | expand |
On 2/22/22 08:31, Keith Busch wrote: > The NVMe protocol extended the data integrity fields with unaligned > 48-bit reference tags. Provide some helper accessors in > preparation for these. > > Reviewed-by: Hannes Reinecke <hare@suse.de> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Keith Busch <kbusch@kernel.org> > --- Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Tue, Feb 22, 2022 at 08:31:37AM -0800, Keith Busch wrote: > The NVMe protocol extended the data integrity fields with unaligned > 48-bit reference tags. Provide some helper accessors in > preparation for these. > > Reviewed-by: Hannes Reinecke <hare@suse.de> > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Keith Busch <kbusch@kernel.org> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, 2022-02-25 at 17:03 +0100, Christoph Hellwig wrote: > On Tue, Feb 22, 2022 at 08:31:37AM -0800, Keith Busch wrote: > > The NVMe protocol extended the data integrity fields with unaligned > > 48-bit reference tags. Provide some helper accessors in > > preparation for these. > > > > Reviewed-by: Hannes Reinecke <hare@suse.de> > > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Keith Busch <kbusch@kernel.org> > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> Perhaps for completeness this should also add the le48 variants like the 24 bit accessors above this.
On Fri, Feb 25, 2022 at 09:53:11AM -0800, Joe Perches wrote: > On Fri, 2022-02-25 at 17:03 +0100, Christoph Hellwig wrote: > > On Tue, Feb 22, 2022 at 08:31:37AM -0800, Keith Busch wrote: > > > The NVMe protocol extended the data integrity fields with unaligned > > > 48-bit reference tags. Provide some helper accessors in > > > preparation for these. > > > > > > Reviewed-by: Hannes Reinecke <hare@suse.de> > > > Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > Signed-off-by: Keith Busch <kbusch@kernel.org> > > > > Looks good, > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Perhaps for completeness this should also add the le48 variants > like the 24 bit accessors above this. I don't know of a user for le48 at this time, and kernel API's without users often get culled. If you think it's useful, though, I can certainly include it.
diff --git a/include/asm-generic/unaligned.h b/include/asm-generic/unaligned.h index 1c4242416c9f..8fc637379899 100644 --- a/include/asm-generic/unaligned.h +++ b/include/asm-generic/unaligned.h @@ -126,4 +126,30 @@ static inline void put_unaligned_le24(const u32 val, void *p) __put_unaligned_le24(val, p); } +static inline void __put_unaligned_be48(const u64 val, __u8 *p) +{ + *p++ = val >> 40; + *p++ = val >> 32; + *p++ = val >> 24; + *p++ = val >> 16; + *p++ = val >> 8; + *p++ = val; +} + +static inline void put_unaligned_be48(const u64 val, void *p) +{ + __put_unaligned_be48(val, p); +} + +static inline u64 __get_unaligned_be48(const u8 *p) +{ + return (u64)p[0] << 40 | (u64)p[1] << 32 | p[2] << 24 | + p[3] << 16 | p[4] << 8 | p[5]; +} + +static inline u64 get_unaligned_be48(const void *p) +{ + return __get_unaligned_be48(p); +} + #endif /* __ASM_GENERIC_UNALIGNED_H */