diff mbox series

soc: microchip: make mpfs_sys_controller_put static

Message ID 20220226124826.1564871-1-mail@conchuod.ie (mailing list archive)
State New, archived
Headers show
Series soc: microchip: make mpfs_sys_controller_put static | expand

Commit Message

Conor Dooley Feb. 26, 2022, 12:48 p.m. UTC 
From: Conor Dooley <conor.dooley@microchip.com>

dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
incorrectly exported mpfs_sys_controller_put. Remove the export and make
the function static instead. This fixes the "no previous prototype
for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot.

Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system
controller")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Conor Dooley <mail@conchuod.ie>
---
 drivers/soc/microchip/mpfs-sys-controller.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Arnd Bergmann Feb. 28, 2022, 3:42 p.m. UTC | #1 
On Sat, Feb 26, 2022 at 1:48 PM Conor Dooley <mail@conchuod.ie> wrote:
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
> incorrectly exported mpfs_sys_controller_put. Remove the export and make
> the function static instead. This fixes the "no previous prototype
> for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot.
>
> Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system
> controller")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Conor Dooley <mail@conchuod.ie>

For reference, I saw the same report and added a different fix for  this
at first, but replaced it with this patch now. No need to add it to the at91
tree. Nicolas, in case there is another problem with this patch, let me know.

       Arnd
Nicolas Ferre Feb. 28, 2022, 4:25 p.m. UTC | #2 
On 28/02/2022 at 16:42, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Sat, Feb 26, 2022 at 1:48 PM Conor Dooley <mail@conchuod.ie> wrote:
>>
>> From: Conor Dooley <conor.dooley@microchip.com>
>>
>> dsafsdfd0054 ("soc: add microchip polarfire soc system controller")
>> incorrectly exported mpfs_sys_controller_put. Remove the export and make
>> the function static instead. This fixes the "no previous prototype
>> for 'mpfs_sys_controller_put'" warning spotted by the kernel test robot.
>>
>> Fixes: dsafsdfd0054 ("soc: add microchip polarfire soc system
>> controller")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
>> Signed-off-by: Conor Dooley <mail@conchuod.ie>
> 
> For reference, I saw the same report and added a different fix for  this
> at first, but replaced it with this patch now. No need to add it to the at91
> tree. Nicolas, in case there is another problem with this patch, let me know.

Ok Arnd, thanks.

For the record:
Reviewed-by: Nicolas Ferre <nicolas.ferre@microchip.com>
diff mbox series

Patch

diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/microchip/mpfs-sys-controller.c
index 2f4535929762..31f3f29fc1ae 100644
--- a/drivers/soc/microchip/mpfs-sys-controller.c
+++ b/drivers/soc/microchip/mpfs-sys-controller.c
@@ -73,13 +73,12 @@  static void mpfs_sys_controller_delete(struct kref *kref)
 	kfree(sys_controller);
 }
 
-void mpfs_sys_controller_put(void *data)
+static void mpfs_sys_controller_put(void *data)
 {
 	struct mpfs_sys_controller *sys_controller = data;
 
 	kref_put(&sys_controller->consumers, mpfs_sys_controller_delete);
 }
-EXPORT_SYMBOL(mpfs_sys_controller_put);
 
 static struct platform_device subdevs[] = {
 	{