| Message ID | 20220215005040.52697-1-akrowiak@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | s390/vfio-ap: dynamic configuration support | expand |
PING!! On 2/14/22 19:50, Tony Krowiak wrote: > The current design for AP pass-through does not support making dynamic > changes to the AP matrix of a running guest resulting in a few > deficiencies this patch series is intended to mitigate: > > 1. Adapters, domains and control domains can not be added to or removed > from a running guest. In order to modify a guest's AP configuration, > the guest must be terminated; only then can AP resources be assigned > to or unassigned from the guest's matrix mdev. The new AP > configuration becomes available to the guest when it is subsequently > restarted. > > 2. The AP bus's /sys/bus/ap/apmask and /sys/bus/ap/aqmask interfaces can > be modified by a root user without any restrictions. A change to > either mask can result in AP queue devices being unbound from the > vfio_ap device driver and bound to a zcrypt device driver even if a > guest is using the queues, thus giving the host access to the guest's > private crypto data and vice versa. > > 3. The APQNs derived from the Cartesian product of the APIDs of the > adapters and APQIs of the domains assigned to a matrix mdev must > reference an AP queue device bound to the vfio_ap device driver. The > AP architecture allows assignment of AP resources that are not > available to the system, so this artificial restriction is not > compliant with the architecture. > > 4. The AP configuration profile can be dynamically changed for the linux > host after a KVM guest is started. For example, a new domain can be > dynamically added to the configuration profile via the SE or an HMC > connected to a DPM enabled lpar. Likewise, AP adapters can be > dynamically configured (online state) and deconfigured (standby state) > using the SE, an SCLP command or an HMC connected to a DPM enabled > lpar. This can result in inadvertent sharing of AP queues between the > guest and host. > > 5. A root user can manually unbind an AP queue device representing a > queue in use by a KVM guest via the vfio_ap device driver's sysfs > unbind attribute. In this case, the guest will be using a queue that > is not bound to the driver which violates the device model. > > This patch series introduces the following changes to the current design > to alleviate the shortcomings described above as well as to implement > more of the AP architecture: > > 1. A root user will be prevented from making edits to the AP bus's > /sys/bus/ap/apmask or /sys/bus/ap/aqmask if the change would transfer > ownership of an APQN from the vfio_ap device driver to a zcrypt driver > while the APQN is assigned to a matrix mdev. > > 2. Allow a root user to hot plug/unplug AP adapters, domains and control > domains for a KVM guest using the matrix mdev via its sysfs > assign/unassign attributes. > > 4. Allow assignment of an AP adapter or domain to a matrix mdev even if > it results in assignment of an APQN that does not reference an AP > queue device bound to the vfio_ap device driver, as long as the APQN > is not reserved for use by the default zcrypt drivers (also known as > over-provisioning of AP resources). Allowing over-provisioning of AP > resources better models the architecture which does not preclude > assigning AP resources that are not yet available in the system. Such > APQNs, however, will not be assigned to the guest using the matrix > mdev; only APQNs referencing AP queue devices bound to the vfio_ap > device driver will actually get assigned to the guest. > > 5. Handle dynamic changes to the AP device model. > > 1. Rationale for changes to AP bus's apmask/aqmask interfaces: > ---------------------------------------------------------- > Due to the extremely sensitive nature of cryptographic data, it is > imperative that great care be taken to ensure that such data is secured. > Allowing a root user, either inadvertently or maliciously, to configure > these masks such that a queue is shared between the host and a guest is > not only avoidable, it is advisable. It was suggested that this scenario > is better handled in user space with management software, but that does > not preclude a malicious administrator from using the sysfs interfaces > to gain access to a guest's crypto data. It was also suggested that this > scenario could be avoided by taking access to the adapter away from the > guest and zeroing out the queues prior to the vfio_ap driver releasing the > device; however, stealing an adapter in use from a guest as a by-product > of an operation is bad and will likely cause problems for the guest > unnecessarily. It was decided that the most effective solution with the > least number of negative side effects is to prevent the situation at the > source. > > 2. Rationale for hot plug/unplug using matrix mdev sysfs interfaces: > ---------------------------------------------------------------- > Allowing a user to hot plug/unplug AP resources using the matrix mdev > sysfs interfaces circumvents the need to terminate the guest in order to > modify its AP configuration. Allowing dynamic configuration makes > reconfiguring a guest's AP matrix much less disruptive. > > 3. Rationale for allowing over-provisioning of AP resources: > ----------------------------------------------------------- > Allowing assignment of AP resources to a matrix mdev and ultimately to a > guest better models the AP architecture. The architecture does not > preclude assignment of unavailable AP resources. If a queue subsequently > becomes available while a guest using the matrix mdev to which its APQN > is assigned, the guest will be given access to it. If an APQN > is dynamically unassigned from the underlying host system, it will > automatically become unavailable to the guest. > > Change log v17-v18: > ------------------ > * Added a new document, Documentation/s390/vfio-ap-locking.rst to describe > the locking design for this series. This included a patch for adding the > new doc to the MAITAINERS file for the VFIO AP maintainers. > > > * Added Reviewed-by for Halil in patch 6 > > * Restore filtering in the queue remove callback. (Halil) > > * Added patch s390/vfio-ap: hot unplug of AP devices when mdev removed to > unplug all AP devices from the guest when the mdev is removed. > > * Split patch 9 (s390/vfio-ap: allow hot plug/unplug of AP resources using > mdev device) into xx patches: > - allow hot plug/unplug of AP devices when assigned/unassigned > > * Replaced v17 patch 08/15, s390/vfio-ap: keep track of active guests with > s390/vfio-ap: introduce new mutex to control access to the KVM pointer. > No longer tracking guests with a list of struct ap_guest objects. Added a > global mutex called kvm_lock which must be held whenever the kvm->lock is > taken. (Halil) > > * Changed signature of the filtering function to limit the APQNs > examined. This change resulted in a cascade of changes to patches 5, 8 > and 12. (Halil) > > * Removed v17 patch 01/15 (s390/vfio-ap: Set pqap hook when vfio_ap module > is loaded). (Halil, Jason). > > * Split patch 14 (notify drivers on config changed and scan complete > callbacks) into two patches: One to make the AP bus changes and the other > to implement the callbacks in the vfio_ap device driver. This was done > to facilitate merging the AP bus changes separately from the vfio_ap > driver changes. (Harald) > > * Removed check of driver flags in the __verify_card_reservations and > __verify_queue_reservations functions in ap_bus.c to balance the > weighting between the default and vfio_ap drivers. (Harald) > > > Tony Krowiak (17): > s390/ap: driver callback to indicate resource in use > s390/ap: notify drivers on config changed and scan complete callbacks > s390/vfio-ap: use new AP bus interface to search for queue devices > s390/vfio-ap: move probe and remove callbacks to vfio_ap_ops.c > s390/vfio-ap: manage link between queue struct and matrix mdev > s390/vfio-ap: introduce shadow APCB > s390/vfio-ap: refresh guest's APCB by filtering APQNs assigned to mdev > s390/vfio-ap: allow assignment of unavailable AP queues to mdev device > s390/vfio-ap: introduce new mutex to control access to the KVM pointer > s390/vfio-ap: allow hot plug/unplug of AP devices when > assigned/unassigned > s390/vfio-ap: hot plug/unplug of AP devices when probed/removed > s390/vfio-ap: reset queues after adapter/domain unassignment > s390/vfio-ap: implement in-use callback for vfio_ap driver > s390/vfio-ap: sysfs attribute to display the guest's matrix > s390/vfio-ap: handle config changed and scan complete notification > s390/vfio-ap: update docs to include dynamic config support > s390/Docs: new doc describing lock usage by the vfio_ap device driver > MAINTAINERS: pick up all vfio_ap docs for VFIO AP maintainers > > Documentation/s390/vfio-ap-locking.rst | 389 +++++++ > Documentation/s390/vfio-ap.rst | 492 ++++++--- > MAINTAINERS | 2 +- > drivers/s390/crypto/ap_bus.c | 226 +++- > drivers/s390/crypto/ap_bus.h | 16 + > drivers/s390/crypto/vfio_ap_drv.c | 71 +- > drivers/s390/crypto/vfio_ap_ops.c | 1347 ++++++++++++++++++------ > drivers/s390/crypto/vfio_ap_private.h | 57 +- > 8 files changed, 2058 insertions(+), 542 deletions(-) > create mode 100644 Documentation/s390/vfio-ap-locking.rst >
PING!! Any takers? On 2/14/22 19:50, Tony Krowiak wrote: > The current design for AP pass-through does not support making dynamic > changes to the AP matrix of a running guest resulting in a few > deficiencies this patch series is intended to mitigate: > > 1. Adapters, domains and control domains can not be added to or removed > from a running guest. In order to modify a guest's AP configuration, > the guest must be terminated; only then can AP resources be assigned > to or unassigned from the guest's matrix mdev. The new AP > configuration becomes available to the guest when it is subsequently > restarted. > > 2. The AP bus's /sys/bus/ap/apmask and /sys/bus/ap/aqmask interfaces can > be modified by a root user without any restrictions. A change to > either mask can result in AP queue devices being unbound from the > vfio_ap device driver and bound to a zcrypt device driver even if a > guest is using the queues, thus giving the host access to the guest's > private crypto data and vice versa. > > 3. The APQNs derived from the Cartesian product of the APIDs of the > adapters and APQIs of the domains assigned to a matrix mdev must > reference an AP queue device bound to the vfio_ap device driver. The > AP architecture allows assignment of AP resources that are not > available to the system, so this artificial restriction is not > compliant with the architecture. > > 4. The AP configuration profile can be dynamically changed for the linux > host after a KVM guest is started. For example, a new domain can be > dynamically added to the configuration profile via the SE or an HMC > connected to a DPM enabled lpar. Likewise, AP adapters can be > dynamically configured (online state) and deconfigured (standby state) > using the SE, an SCLP command or an HMC connected to a DPM enabled > lpar. This can result in inadvertent sharing of AP queues between the > guest and host. > > 5. A root user can manually unbind an AP queue device representing a > queue in use by a KVM guest via the vfio_ap device driver's sysfs > unbind attribute. In this case, the guest will be using a queue that > is not bound to the driver which violates the device model. > > This patch series introduces the following changes to the current design > to alleviate the shortcomings described above as well as to implement > more of the AP architecture: > > 1. A root user will be prevented from making edits to the AP bus's > /sys/bus/ap/apmask or /sys/bus/ap/aqmask if the change would transfer > ownership of an APQN from the vfio_ap device driver to a zcrypt driver > while the APQN is assigned to a matrix mdev. > > 2. Allow a root user to hot plug/unplug AP adapters, domains and control > domains for a KVM guest using the matrix mdev via its sysfs > assign/unassign attributes. > > 4. Allow assignment of an AP adapter or domain to a matrix mdev even if > it results in assignment of an APQN that does not reference an AP > queue device bound to the vfio_ap device driver, as long as the APQN > is not reserved for use by the default zcrypt drivers (also known as > over-provisioning of AP resources). Allowing over-provisioning of AP > resources better models the architecture which does not preclude > assigning AP resources that are not yet available in the system. Such > APQNs, however, will not be assigned to the guest using the matrix > mdev; only APQNs referencing AP queue devices bound to the vfio_ap > device driver will actually get assigned to the guest. > > 5. Handle dynamic changes to the AP device model. > > 1. Rationale for changes to AP bus's apmask/aqmask interfaces: > ---------------------------------------------------------- > Due to the extremely sensitive nature of cryptographic data, it is > imperative that great care be taken to ensure that such data is secured. > Allowing a root user, either inadvertently or maliciously, to configure > these masks such that a queue is shared between the host and a guest is > not only avoidable, it is advisable. It was suggested that this scenario > is better handled in user space with management software, but that does > not preclude a malicious administrator from using the sysfs interfaces > to gain access to a guest's crypto data. It was also suggested that this > scenario could be avoided by taking access to the adapter away from the > guest and zeroing out the queues prior to the vfio_ap driver releasing the > device; however, stealing an adapter in use from a guest as a by-product > of an operation is bad and will likely cause problems for the guest > unnecessarily. It was decided that the most effective solution with the > least number of negative side effects is to prevent the situation at the > source. > > 2. Rationale for hot plug/unplug using matrix mdev sysfs interfaces: > ---------------------------------------------------------------- > Allowing a user to hot plug/unplug AP resources using the matrix mdev > sysfs interfaces circumvents the need to terminate the guest in order to > modify its AP configuration. Allowing dynamic configuration makes > reconfiguring a guest's AP matrix much less disruptive. > > 3. Rationale for allowing over-provisioning of AP resources: > ----------------------------------------------------------- > Allowing assignment of AP resources to a matrix mdev and ultimately to a > guest better models the AP architecture. The architecture does not > preclude assignment of unavailable AP resources. If a queue subsequently > becomes available while a guest using the matrix mdev to which its APQN > is assigned, the guest will be given access to it. If an APQN > is dynamically unassigned from the underlying host system, it will > automatically become unavailable to the guest. > > Change log v17-v18: > ------------------ > * Added a new document, Documentation/s390/vfio-ap-locking.rst to describe > the locking design for this series. This included a patch for adding the > new doc to the MAITAINERS file for the VFIO AP maintainers. > > > * Added Reviewed-by for Halil in patch 6 > > * Restore filtering in the queue remove callback. (Halil) > > * Added patch s390/vfio-ap: hot unplug of AP devices when mdev removed to > unplug all AP devices from the guest when the mdev is removed. > > * Split patch 9 (s390/vfio-ap: allow hot plug/unplug of AP resources using > mdev device) into xx patches: > - allow hot plug/unplug of AP devices when assigned/unassigned > > * Replaced v17 patch 08/15, s390/vfio-ap: keep track of active guests with > s390/vfio-ap: introduce new mutex to control access to the KVM pointer. > No longer tracking guests with a list of struct ap_guest objects. Added a > global mutex called kvm_lock which must be held whenever the kvm->lock is > taken. (Halil) > > * Changed signature of the filtering function to limit the APQNs > examined. This change resulted in a cascade of changes to patches 5, 8 > and 12. (Halil) > > * Removed v17 patch 01/15 (s390/vfio-ap: Set pqap hook when vfio_ap module > is loaded). (Halil, Jason). > > * Split patch 14 (notify drivers on config changed and scan complete > callbacks) into two patches: One to make the AP bus changes and the other > to implement the callbacks in the vfio_ap device driver. This was done > to facilitate merging the AP bus changes separately from the vfio_ap > driver changes. (Harald) > > * Removed check of driver flags in the __verify_card_reservations and > __verify_queue_reservations functions in ap_bus.c to balance the > weighting between the default and vfio_ap drivers. (Harald) > > > Tony Krowiak (17): > s390/ap: driver callback to indicate resource in use > s390/ap: notify drivers on config changed and scan complete callbacks > s390/vfio-ap: use new AP bus interface to search for queue devices > s390/vfio-ap: move probe and remove callbacks to vfio_ap_ops.c > s390/vfio-ap: manage link between queue struct and matrix mdev > s390/vfio-ap: introduce shadow APCB > s390/vfio-ap: refresh guest's APCB by filtering APQNs assigned to mdev > s390/vfio-ap: allow assignment of unavailable AP queues to mdev device > s390/vfio-ap: introduce new mutex to control access to the KVM pointer > s390/vfio-ap: allow hot plug/unplug of AP devices when > assigned/unassigned > s390/vfio-ap: hot plug/unplug of AP devices when probed/removed > s390/vfio-ap: reset queues after adapter/domain unassignment > s390/vfio-ap: implement in-use callback for vfio_ap driver > s390/vfio-ap: sysfs attribute to display the guest's matrix > s390/vfio-ap: handle config changed and scan complete notification > s390/vfio-ap: update docs to include dynamic config support > s390/Docs: new doc describing lock usage by the vfio_ap device driver > MAINTAINERS: pick up all vfio_ap docs for VFIO AP maintainers > > Documentation/s390/vfio-ap-locking.rst | 389 +++++++ > Documentation/s390/vfio-ap.rst | 492 ++++++--- > MAINTAINERS | 2 +- > drivers/s390/crypto/ap_bus.c | 226 +++- > drivers/s390/crypto/ap_bus.h | 16 + > drivers/s390/crypto/vfio_ap_drv.c | 71 +- > drivers/s390/crypto/vfio_ap_ops.c | 1347 ++++++++++++++++++------ > drivers/s390/crypto/vfio_ap_private.h | 57 +- > 8 files changed, 2058 insertions(+), 542 deletions(-) > create mode 100644 Documentation/s390/vfio-ap-locking.rst >
On 2/28/22 10:53, Tony Krowiak wrote:
> PING!! Any takers?
I'm taking a look, starting where I left off on v17, patch #7.
The current design for AP pass-through does not support making dynamic changes to the AP matrix of a running guest resulting in a few deficiencies this patch series is intended to mitigate: 1. Adapters, domains and control domains can not be added to or removed from a running guest. In order to modify a guest's AP configuration, the guest must be terminated; only then can AP resources be assigned to or unassigned from the guest's matrix mdev. The new AP configuration becomes available to the guest when it is subsequently restarted. 2. The AP bus's /sys/bus/ap/apmask and /sys/bus/ap/aqmask interfaces can be modified by a root user without any restrictions. A change to either mask can result in AP queue devices being unbound from the vfio_ap device driver and bound to a zcrypt device driver even if a guest is using the queues, thus giving the host access to the guest's private crypto data and vice versa. 3. The APQNs derived from the Cartesian product of the APIDs of the adapters and APQIs of the domains assigned to a matrix mdev must reference an AP queue device bound to the vfio_ap device driver. The AP architecture allows assignment of AP resources that are not available to the system, so this artificial restriction is not compliant with the architecture. 4. The AP configuration profile can be dynamically changed for the linux host after a KVM guest is started. For example, a new domain can be dynamically added to the configuration profile via the SE or an HMC connected to a DPM enabled lpar. Likewise, AP adapters can be dynamically configured (online state) and deconfigured (standby state) using the SE, an SCLP command or an HMC connected to a DPM enabled lpar. This can result in inadvertent sharing of AP queues between the guest and host. 5. A root user can manually unbind an AP queue device representing a queue in use by a KVM guest via the vfio_ap device driver's sysfs unbind attribute. In this case, the guest will be using a queue that is not bound to the driver which violates the device model. This patch series introduces the following changes to the current design to alleviate the shortcomings described above as well as to implement more of the AP architecture: 1. A root user will be prevented from making edits to the AP bus's /sys/bus/ap/apmask or /sys/bus/ap/aqmask if the change would transfer ownership of an APQN from the vfio_ap device driver to a zcrypt driver while the APQN is assigned to a matrix mdev. 2. Allow a root user to hot plug/unplug AP adapters, domains and control domains for a KVM guest using the matrix mdev via its sysfs assign/unassign attributes. 4. Allow assignment of an AP adapter or domain to a matrix mdev even if it results in assignment of an APQN that does not reference an AP queue device bound to the vfio_ap device driver, as long as the APQN is not reserved for use by the default zcrypt drivers (also known as over-provisioning of AP resources). Allowing over-provisioning of AP resources better models the architecture which does not preclude assigning AP resources that are not yet available in the system. Such APQNs, however, will not be assigned to the guest using the matrix mdev; only APQNs referencing AP queue devices bound to the vfio_ap device driver will actually get assigned to the guest. 5. Handle dynamic changes to the AP device model. 1. Rationale for changes to AP bus's apmask/aqmask interfaces: ---------------------------------------------------------- Due to the extremely sensitive nature of cryptographic data, it is imperative that great care be taken to ensure that such data is secured. Allowing a root user, either inadvertently or maliciously, to configure these masks such that a queue is shared between the host and a guest is not only avoidable, it is advisable. It was suggested that this scenario is better handled in user space with management software, but that does not preclude a malicious administrator from using the sysfs interfaces to gain access to a guest's crypto data. It was also suggested that this scenario could be avoided by taking access to the adapter away from the guest and zeroing out the queues prior to the vfio_ap driver releasing the device; however, stealing an adapter in use from a guest as a by-product of an operation is bad and will likely cause problems for the guest unnecessarily. It was decided that the most effective solution with the least number of negative side effects is to prevent the situation at the source. 2. Rationale for hot plug/unplug using matrix mdev sysfs interfaces: ---------------------------------------------------------------- Allowing a user to hot plug/unplug AP resources using the matrix mdev sysfs interfaces circumvents the need to terminate the guest in order to modify its AP configuration. Allowing dynamic configuration makes reconfiguring a guest's AP matrix much less disruptive. 3. Rationale for allowing over-provisioning of AP resources: ----------------------------------------------------------- Allowing assignment of AP resources to a matrix mdev and ultimately to a guest better models the AP architecture. The architecture does not preclude assignment of unavailable AP resources. If a queue subsequently becomes available while a guest using the matrix mdev to which its APQN is assigned, the guest will be given access to it. If an APQN is dynamically unassigned from the underlying host system, it will automatically become unavailable to the guest. Change log v17-v18: ------------------ * Added a new document, Documentation/s390/vfio-ap-locking.rst to describe the locking design for this series. This included a patch for adding the new doc to the MAITAINERS file for the VFIO AP maintainers. * Added Reviewed-by for Halil in patch 6 * Restore filtering in the queue remove callback. (Halil) * Added patch s390/vfio-ap: hot unplug of AP devices when mdev removed to unplug all AP devices from the guest when the mdev is removed. * Split patch 9 (s390/vfio-ap: allow hot plug/unplug of AP resources using mdev device) into xx patches: - allow hot plug/unplug of AP devices when assigned/unassigned * Replaced v17 patch 08/15, s390/vfio-ap: keep track of active guests with s390/vfio-ap: introduce new mutex to control access to the KVM pointer. No longer tracking guests with a list of struct ap_guest objects. Added a global mutex called kvm_lock which must be held whenever the kvm->lock is taken. (Halil) * Changed signature of the filtering function to limit the APQNs examined. This change resulted in a cascade of changes to patches 5, 8 and 12. (Halil) * Removed v17 patch 01/15 (s390/vfio-ap: Set pqap hook when vfio_ap module is loaded). (Halil, Jason). * Split patch 14 (notify drivers on config changed and scan complete callbacks) into two patches: One to make the AP bus changes and the other to implement the callbacks in the vfio_ap device driver. This was done to facilitate merging the AP bus changes separately from the vfio_ap driver changes. (Harald) * Removed check of driver flags in the __verify_card_reservations and __verify_queue_reservations functions in ap_bus.c to balance the weighting between the default and vfio_ap drivers. (Harald) Tony Krowiak (17): s390/ap: driver callback to indicate resource in use s390/ap: notify drivers on config changed and scan complete callbacks s390/vfio-ap: use new AP bus interface to search for queue devices s390/vfio-ap: move probe and remove callbacks to vfio_ap_ops.c s390/vfio-ap: manage link between queue struct and matrix mdev s390/vfio-ap: introduce shadow APCB s390/vfio-ap: refresh guest's APCB by filtering APQNs assigned to mdev s390/vfio-ap: allow assignment of unavailable AP queues to mdev device s390/vfio-ap: introduce new mutex to control access to the KVM pointer s390/vfio-ap: allow hot plug/unplug of AP devices when assigned/unassigned s390/vfio-ap: hot plug/unplug of AP devices when probed/removed s390/vfio-ap: reset queues after adapter/domain unassignment s390/vfio-ap: implement in-use callback for vfio_ap driver s390/vfio-ap: sysfs attribute to display the guest's matrix s390/vfio-ap: handle config changed and scan complete notification s390/vfio-ap: update docs to include dynamic config support s390/Docs: new doc describing lock usage by the vfio_ap device driver MAINTAINERS: pick up all vfio_ap docs for VFIO AP maintainers Documentation/s390/vfio-ap-locking.rst | 389 +++++++ Documentation/s390/vfio-ap.rst | 492 ++++++--- MAINTAINERS | 2 +- drivers/s390/crypto/ap_bus.c | 226 +++- drivers/s390/crypto/ap_bus.h | 16 + drivers/s390/crypto/vfio_ap_drv.c | 71 +- drivers/s390/crypto/vfio_ap_ops.c | 1347 ++++++++++++++++++------ drivers/s390/crypto/vfio_ap_private.h | 57 +- 8 files changed, 2058 insertions(+), 542 deletions(-) create mode 100644 Documentation/s390/vfio-ap-locking.rst