| Message ID | 20220302110508.69053-3-bhupesh.sharma@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add ethernet support for Qualcomm SA8155p-ADP board | expand |
On Wed, 2 Mar 2022 at 14:05, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > Add the EMAC GDSC defines and driver structures for SM8150. > > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > drivers/clk/qcom/gcc-sm8150.c | 34 +++++++++++++-------- > include/dt-bindings/clock/qcom,gcc-sm8150.h | 1 + > 2 files changed, 23 insertions(+), 12 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > index 245794485719..08ba29e3a835 100644 > --- a/drivers/clk/qcom/gcc-sm8150.c > +++ b/drivers/clk/qcom/gcc-sm8150.c > @@ -3448,22 +3448,31 @@ static struct clk_branch gcc_video_xo_clk = { > }, > }; > > +static struct gdsc emac_gdsc = { > + .gdscr = 0x6004, > + .pd = { > + .name = "emac_gdsc", > + }, > + .pwrsts = PWRSTS_OFF_ON, > + .flags = POLL_CFG_GDSCR, > +}; > + > static struct gdsc usb30_prim_gdsc = { > - .gdscr = 0xf004, > - .pd = { > - .name = "usb30_prim_gdsc", > - }, > - .pwrsts = PWRSTS_OFF_ON, > - .flags = POLL_CFG_GDSCR, > + .gdscr = 0xf004, > + .pd = { > + .name = "usb30_prim_gdsc", > + }, > + .pwrsts = PWRSTS_OFF_ON, > + .flags = POLL_CFG_GDSCR, Please move alignment changes to a separate patch > }; > > static struct gdsc usb30_sec_gdsc = { > - .gdscr = 0x10004, > - .pd = { > - .name = "usb30_sec_gdsc", > - }, > - .pwrsts = PWRSTS_OFF_ON, > - .flags = POLL_CFG_GDSCR, > + .gdscr = 0x10004, > + .pd = { > + .name = "usb30_sec_gdsc", > + }, > + .pwrsts = PWRSTS_OFF_ON, > + .flags = POLL_CFG_GDSCR, > }; > > static struct clk_regmap *gcc_sm8150_clocks[] = { > @@ -3714,6 +3723,7 @@ static const struct qcom_reset_map gcc_sm8150_resets[] = { > }; > > static struct gdsc *gcc_sm8150_gdscs[] = { > + [EMAC_GDSC] = &emac_gdsc, > [USB30_PRIM_GDSC] = &usb30_prim_gdsc, > [USB30_SEC_GDSC] = &usb30_sec_gdsc, > }; > diff --git a/include/dt-bindings/clock/qcom,gcc-sm8150.h b/include/dt-bindings/clock/qcom,gcc-sm8150.h > index 3e1a91876610..40596b9ded06 100644 > --- a/include/dt-bindings/clock/qcom,gcc-sm8150.h > +++ b/include/dt-bindings/clock/qcom,gcc-sm8150.h > @@ -243,5 +243,6 @@ > /* GCC GDSCRs */ > #define USB30_PRIM_GDSC 4 > #define USB30_SEC_GDSC 5 > +#define EMAC_GDSC 6 > > #endif > -- > 2.35.1 >
Hi Dmitry, On Wed, 2 Mar 2022 at 18:00, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Wed, 2 Mar 2022 at 14:05, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote: > > > > Add the EMAC GDSC defines and driver structures for SM8150. > > > > Cc: Stephen Boyd <sboyd@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > drivers/clk/qcom/gcc-sm8150.c | 34 +++++++++++++-------- > > include/dt-bindings/clock/qcom,gcc-sm8150.h | 1 + > > 2 files changed, 23 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > > index 245794485719..08ba29e3a835 100644 > > --- a/drivers/clk/qcom/gcc-sm8150.c > > +++ b/drivers/clk/qcom/gcc-sm8150.c > > @@ -3448,22 +3448,31 @@ static struct clk_branch gcc_video_xo_clk = { > > }, > > }; > > > > +static struct gdsc emac_gdsc = { > > + .gdscr = 0x6004, > > + .pd = { > > + .name = "emac_gdsc", > > + }, > > + .pwrsts = PWRSTS_OFF_ON, > > + .flags = POLL_CFG_GDSCR, > > +}; > > + > > static struct gdsc usb30_prim_gdsc = { > > - .gdscr = 0xf004, > > - .pd = { > > - .name = "usb30_prim_gdsc", > > - }, > > - .pwrsts = PWRSTS_OFF_ON, > > - .flags = POLL_CFG_GDSCR, > > + .gdscr = 0xf004, > > + .pd = { > > + .name = "usb30_prim_gdsc", > > + }, > > + .pwrsts = PWRSTS_OFF_ON, > > + .flags = POLL_CFG_GDSCR, > > Please move alignment changes to a separate patch Right, Will fix it in v3. Regards, Bhupesh > > }; > > > > static struct gdsc usb30_sec_gdsc = { > > - .gdscr = 0x10004, > > - .pd = { > > - .name = "usb30_sec_gdsc", > > - }, > > - .pwrsts = PWRSTS_OFF_ON, > > - .flags = POLL_CFG_GDSCR, > > + .gdscr = 0x10004, > > + .pd = { > > + .name = "usb30_sec_gdsc", > > + }, > > + .pwrsts = PWRSTS_OFF_ON, > > + .flags = POLL_CFG_GDSCR, > > }; > > > > static struct clk_regmap *gcc_sm8150_clocks[] = { > > @@ -3714,6 +3723,7 @@ static const struct qcom_reset_map gcc_sm8150_resets[] = { > > }; > > > > static struct gdsc *gcc_sm8150_gdscs[] = { > > + [EMAC_GDSC] = &emac_gdsc, > > [USB30_PRIM_GDSC] = &usb30_prim_gdsc, > > [USB30_SEC_GDSC] = &usb30_sec_gdsc, > > }; > > diff --git a/include/dt-bindings/clock/qcom,gcc-sm8150.h b/include/dt-bindings/clock/qcom,gcc-sm8150.h > > index 3e1a91876610..40596b9ded06 100644 > > --- a/include/dt-bindings/clock/qcom,gcc-sm8150.h > > +++ b/include/dt-bindings/clock/qcom,gcc-sm8150.h > > @@ -243,5 +243,6 @@ > > /* GCC GDSCRs */ > > #define USB30_PRIM_GDSC 4 > > #define USB30_SEC_GDSC 5 > > +#define EMAC_GDSC 6 > > > > #endif > > -- > > 2.35.1 > > > > > -- > With best wishes > Dmitry
diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c index 245794485719..08ba29e3a835 100644 --- a/drivers/clk/qcom/gcc-sm8150.c +++ b/drivers/clk/qcom/gcc-sm8150.c @@ -3448,22 +3448,31 @@ static struct clk_branch gcc_video_xo_clk = { }, }; +static struct gdsc emac_gdsc = { + .gdscr = 0x6004, + .pd = { + .name = "emac_gdsc", + }, + .pwrsts = PWRSTS_OFF_ON, + .flags = POLL_CFG_GDSCR, +}; + static struct gdsc usb30_prim_gdsc = { - .gdscr = 0xf004, - .pd = { - .name = "usb30_prim_gdsc", - }, - .pwrsts = PWRSTS_OFF_ON, - .flags = POLL_CFG_GDSCR, + .gdscr = 0xf004, + .pd = { + .name = "usb30_prim_gdsc", + }, + .pwrsts = PWRSTS_OFF_ON, + .flags = POLL_CFG_GDSCR, }; static struct gdsc usb30_sec_gdsc = { - .gdscr = 0x10004, - .pd = { - .name = "usb30_sec_gdsc", - }, - .pwrsts = PWRSTS_OFF_ON, - .flags = POLL_CFG_GDSCR, + .gdscr = 0x10004, + .pd = { + .name = "usb30_sec_gdsc", + }, + .pwrsts = PWRSTS_OFF_ON, + .flags = POLL_CFG_GDSCR, }; static struct clk_regmap *gcc_sm8150_clocks[] = { @@ -3714,6 +3723,7 @@ static const struct qcom_reset_map gcc_sm8150_resets[] = { }; static struct gdsc *gcc_sm8150_gdscs[] = { + [EMAC_GDSC] = &emac_gdsc, [USB30_PRIM_GDSC] = &usb30_prim_gdsc, [USB30_SEC_GDSC] = &usb30_sec_gdsc, }; diff --git a/include/dt-bindings/clock/qcom,gcc-sm8150.h b/include/dt-bindings/clock/qcom,gcc-sm8150.h index 3e1a91876610..40596b9ded06 100644 --- a/include/dt-bindings/clock/qcom,gcc-sm8150.h +++ b/include/dt-bindings/clock/qcom,gcc-sm8150.h @@ -243,5 +243,6 @@ /* GCC GDSCRs */ #define USB30_PRIM_GDSC 4 #define USB30_SEC_GDSC 5 +#define EMAC_GDSC 6 #endif
Add the EMAC GDSC defines and driver structures for SM8150. Cc: Stephen Boyd <sboyd@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- drivers/clk/qcom/gcc-sm8150.c | 34 +++++++++++++-------- include/dt-bindings/clock/qcom,gcc-sm8150.h | 1 + 2 files changed, 23 insertions(+), 12 deletions(-)