| Message ID | 20220303090158.30834-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: dma: rz-dmac: Update compatible string for RZ/G2UL SoC | expand |
Hi Biju, On Thu, Mar 3, 2022 at 10:02 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Both RZ/G2UL and RZ/Five SoC's have SoC ID starting with R9A07G043. > To distinguish between them update the compatible string to > "renesas,r9a07g043u-dmac" for RZ/G2UL SoC. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > @@ -16,9 +16,9 @@ properties: > compatible: > items: > - enum: > - - renesas,r9a07g043-dmac # RZ/G2UL > - - renesas,r9a07g044-dmac # RZ/G2{L,LC} > - - renesas,r9a07g054-dmac # RZ/V2L > + - renesas,r9a07g043u-dmac # RZ/G2UL Is this really needed? As far as we know, RZ/Five and RZ/G2UL do use the same I/O blocks? > + - renesas,r9a07g044-dmac # RZ/G2{L,LC} > + - renesas,r9a07g054-dmac # RZ/V2L > - const: renesas,rz-dmac > > reg: Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH] dt-bindings: dma: rz-dmac: Update compatible string > for RZ/G2UL SoC > > Hi Biju, > > On Thu, Mar 3, 2022 at 10:02 AM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Both RZ/G2UL and RZ/Five SoC's have SoC ID starting with R9A07G043. > > To distinguish between them update the compatible string to > > "renesas,r9a07g043u-dmac" for RZ/G2UL SoC. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > > @@ -16,9 +16,9 @@ properties: > > compatible: > > items: > > - enum: > > - - renesas,r9a07g043-dmac # RZ/G2UL > > - - renesas,r9a07g044-dmac # RZ/G2{L,LC} > > - - renesas,r9a07g054-dmac # RZ/V2L > > + - renesas,r9a07g043u-dmac # RZ/G2UL > > Is this really needed? As far as we know, RZ/Five and RZ/G2UL do use the > same I/O blocks? OK, Just thought their DEVID is different and they use RISC-V instead of ARM64 And also the CPU caches are different. I agree it uses identical IP blocks. May be I can drop this patch, if it is not really needed. Please let me know. Cheers, Biju > > > + - renesas,r9a07g044-dmac # RZ/G2{L,LC} > > + - renesas,r9a07g054-dmac # RZ/V2L > > - const: renesas,rz-dmac > > > > reg: > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
Hi Biju, On Thu, Mar 3, 2022 at 10:59 AM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Subject: Re: [PATCH] dt-bindings: dma: rz-dmac: Update compatible string > > for RZ/G2UL SoC > > On Thu, Mar 3, 2022 at 10:02 AM Biju Das <biju.das.jz@bp.renesas.com> > > wrote: > > > Both RZ/G2UL and RZ/Five SoC's have SoC ID starting with R9A07G043. > > > To distinguish between them update the compatible string to > > > "renesas,r9a07g043u-dmac" for RZ/G2UL SoC. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > > > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > > > @@ -16,9 +16,9 @@ properties: > > > compatible: > > > items: > > > - enum: > > > - - renesas,r9a07g043-dmac # RZ/G2UL > > > - - renesas,r9a07g044-dmac # RZ/G2{L,LC} > > > - - renesas,r9a07g054-dmac # RZ/V2L > > > + - renesas,r9a07g043u-dmac # RZ/G2UL > > > > Is this really needed? As far as we know, RZ/Five and RZ/G2UL do use the > > same I/O blocks? > > OK, Just thought their DEVID is different and they use RISC-V instead of ARM64 > And also the CPU caches are different. > > I agree it uses identical IP blocks. > > May be I can drop this patch, if it is not really needed. Please let me know. Please see my response in https://lore.kernel.org/r/CAMuHMdUZw5bxUgEif=pT-2Gm1ha-Z01r+AJ6ieC62SwkfMYD5Q@mail.gmail.com/ Let's continue the discussion there... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml index 1e25c5b0fb4d..9e367f51d621 100644 --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml @@ -16,9 +16,9 @@ properties: compatible: items: - enum: - - renesas,r9a07g043-dmac # RZ/G2UL - - renesas,r9a07g044-dmac # RZ/G2{L,LC} - - renesas,r9a07g054-dmac # RZ/V2L + - renesas,r9a07g043u-dmac # RZ/G2UL + - renesas,r9a07g044-dmac # RZ/G2{L,LC} + - renesas,r9a07g054-dmac # RZ/V2L - const: renesas,rz-dmac reg: