| Message ID | 20220126071932.32615-1-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Mediatek Soc DRM (vdosys0) support for mt8195 | expand |
Hello Matthias, The DRM parts are all reviewed by Chun-Kuang. Can you spare some time to give us some suggestion for mmsys parts? Or do you think we should separate the driver of mmsys related patches to another series and resend again? Would it be better to combine mmsys related patches from vdosys0 [1] and vdosys1 [2] series? e.g. [v1,0/7] soc: mediatek: mmsys: add mt8195 mmsys support [v1,1/7] dt-bindings: arm: mediatek: mmsys: add power and gce properties [v1,2/7] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding [v1,3/7] dt-bindings: reset: mt8195: add vdosys1 reset control bit [v1,4/7] soc: mediatek: mmsys: add mtk-mmsys support for mt8195 vdosys0 [v1,5/7] soc: mediatek: mmsys: add mtk-mmsys support for mt8195 vdosys1 [v1,6/7] soc: mediatek: mmsys: add mtk-mmsys config API for mt8195 vdosys1 [v1,7/7] soc: mediatek: mmsys: modify reset controller for MT8195 vdosys1 --- [1] Add Mediatek Soc DRM (vdosys0) support for mt8195 - https://patchwork.kernel.org/project/linux-mediatek/list/?series=608548 [2] Add MediaTek SoC DRM (vdosys1) support for mt8195 - https://patchwork.kernel.org/project/linux-mediatek/list/?series=604065 --- Regards, Jason-JH.Lin On Wed, 2022-01-26 at 15:19 +0800, jason-jh.lin wrote: > Change in v15: > - remove mt8195-mmsys.h comment for mux settings > - define the mask macro to replace using value as mask > to fix zero mask problem > - add EOF setting comment for MUTEX sof register > > Change in v14: > - rebase on mediatek-drm-next-5.17 > - rebase on "Add mmsys and mutex support for MDP" series > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=602528 > - rebase on "media: mediatek: support mdp3 on mt8183 platform" series > > https://patchwork.kernel.org/project/linux-mediatek/list/?series=602834 > [snip] ... > > jason-jh.lin (12): > dt-bindings: arm: mediatek: mmsys: add power and gce properties > dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding > dt-bindings: display: mediatek: disp: split each block to > individual > yaml > dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC > binding > dt-bindings: display: mediatek: merge: add additional prop for > mt8195 > dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0 > dt-bindings: arm: mediatek: move out common module from display > folder > soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 > soc: mediatek: add mtk-mutex support for mt8195 vdosys0 > drm/mediatek: add DSC support for mediatek-drm > drm/mediatek: add MERGE support for mediatek-drm > drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 32 ++- > .../display/mediatek/mediatek,disp.txt | 219 ---------------- > .../display/mediatek/mediatek,dither.yaml | 76 ++++++ > .../display/mediatek/mediatek,dsc.yaml | 71 +++++ > .../display/mediatek/mediatek,gamma.yaml | 77 ++++++ > .../display/mediatek/mediatek,merge.yaml | 106 ++++++++ > .../display/mediatek/mediatek,od.yaml | 53 ++++ > .../display/mediatek/mediatek,ovl-2l.yaml | 88 +++++++ > .../display/mediatek/mediatek,ovl.yaml | 103 ++++++++ > .../display/mediatek/mediatek,postmask.yaml | 69 +++++ > .../display/mediatek/mediatek,rdma.yaml | 117 +++++++++ > .../display/mediatek/mediatek,split.yaml | 58 +++++ > .../display/mediatek/mediatek,ufoe.yaml | 61 +++++ > .../bindings/soc/mediatek/mediatek,aal.yaml | 72 +++++ > .../bindings/soc/mediatek/mediatek,ccorr.yaml | 46 +++- > .../bindings/soc/mediatek/mediatek,color.yaml | 81 ++++++ > .../bindings/soc/mediatek/mediatek,mutex.yaml | 77 ++++++ > .../bindings/soc/mediatek/mediatek,wdma.yaml | 47 +++- > drivers/gpu/drm/mediatek/Makefile | 1 + > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 246 > ++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 63 +++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 + > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 ++- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + > drivers/soc/mediatek/mt8195-mmsys.h | 130 +++++++++ > drivers/soc/mediatek/mtk-mmsys.c | 11 + > drivers/soc/mediatek/mtk-mutex.c | 103 +++++++- > include/linux/soc/mediatek/mtk-mmsys.h | 9 + > 30 files changed, 1832 insertions(+), 233 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,dither.ya > ml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yam > l > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yam > l > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl- > 2l.yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,postmask. > yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,split.yam > l > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml > create mode 100644 > Documentation/devicetree/bindings/soc/mediatek/mediatek,aal.yaml > create mode 100644 > Documentation/devicetree/bindings/soc/mediatek/mediatek,color.yaml > create mode 100644 > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_merge.c > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h >
Il 14/02/22 11:13, Jason-JH Lin ha scritto: > Hello Matthias, > > The DRM parts are all reviewed by Chun-Kuang. > Can you spare some time to give us some suggestion for mmsys parts? > > Or do you think we should separate the driver of mmsys related patches > to another series and resend again? > Would it be better to combine mmsys related patches from vdosys0 [1] > and vdosys1 [2] series? > > e.g. > [v1,0/7] soc: mediatek: mmsys: add mt8195 mmsys support > [v1,1/7] dt-bindings: arm: mediatek: mmsys: add power and gce > properties > [v1,2/7] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding > [v1,3/7] dt-bindings: reset: mt8195: add vdosys1 reset control bit > [v1,4/7] soc: mediatek: mmsys: add mtk-mmsys support for mt8195 vdosys0 > [v1,5/7] soc: mediatek: mmsys: add mtk-mmsys support for mt8195 vdosys1 > [v1,6/7] soc: mediatek: mmsys: add mtk-mmsys config API for mt8195 > vdosys1 > [v1,7/7] soc: mediatek: mmsys: modify reset controller for MT8195 > vdosys1 > > --- > [1] Add Mediatek Soc DRM (vdosys0) support for mt8195 > - > https://patchwork.kernel.org/project/linux-mediatek/list/?series=608548 > [2] Add MediaTek SoC DRM (vdosys1) support for mt8195 > - > https://patchwork.kernel.org/project/linux-mediatek/list/?series=604065 > --- > > Regards, > Jason-JH.Lin > Hello everyone, I think that all the drm/mediatek and soc/mediatek patches in this series are safe and ready (and also tested for regressions on older SoCs). Feel free to pick them in your trees. Cheers, Angelo
On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin <jason-jh.lin@mediatek.com> wrote: > > Change in v15: > - remove mt8195-mmsys.h comment for mux settings > - define the mask macro to replace using value as mask > to fix zero mask problem > - add EOF setting comment for MUTEX sof register > > Change in v14: > - rebase on mediatek-drm-next-5.17 > - rebase on "Add mmsys and mutex support for MDP" series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=602528 > - rebase on "media: mediatek: support mdp3 on mt8183 platform" series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=602834 > > Change in v13: > - remove dts patch > - rebase on kernel-5.16-rc1 > - rebase on mediatek-drm-next > > Change in v12: > - add clock-names property to merge yaml > - using BIT(nr) macro to define the settings of mmsys routing table > - fix clk_get and clk_prepare_enable error handling issue > > Change in v11: > - rebase on kernel-5.15-rc1 > - change mbox label to gce0 for dts node of vdosys0 > - change ovl compatibale to mt8192 to set smi_id_en=true in driver data > - move common module from display folder to common folder, > such as AAL, COCLOR, CCORR and MUTEX > > Change in v10: > - rebase on "drm/mediatek: add support for mediatek SOC MT8192" series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=529489 > - rebase on "soc: mediatek: mmsys: add mt8192 mmsys support" series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=524857 > - fix some typo and "mediatek" start with capital in every dt-bindings > - move mutex yaml from dfisplay folder to soc folder > - separate merge additional propoerties to an individual dt-bindings patch > > Change in v9: > - separate power and gce properties of mmsys into another dt-binding patch > - rebase on "Separate aal module" series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=516463 > - keep mtk_ddp_clk_enable/disable in the same place > - change mtk_dsc_start config register to mtk_drm_ddp_write_mask > - remove the 0 setting of merge fifo config function > - add CCORR driver data for mt8195 > > Change in v8: > - add DP_INTF0 mux into mmsys routing table > - add DP_INTF0 mutex mod and enum into add/remove comp function > - remove bypass DSC enum in mtk_ddp_comp_init > > Change in v7: > - add dt=binding of mmsys and disp path into this series > - separate th modidfication of alphabetic order, remove unused define and > rename the define of register offset to individual patch > - add comment for MERGE ultra and preultra setting > > Change in v6: > - adjust alphabetic order for mediatek-drm > - move the patch that add mt8195 support for mediatek-drm as > the lastest patch > - add MERGE define for const varriable > > Change in v5: > - add power-domain property into vdosys0 and vdosys1 dts node. > - add MT8195 prifix and remove unused VDO1 define in mt8195-mmsys.h > > Change in v4: > - extract dt-binding patches to another patch series > https://patchwork.kernel.org/project/linux-mediatek/list/?series=519597 > - squash DSC module into mtk_drm_ddp_comp.c > - add coment and simplify MERGE config function > > Change in v3: > - change mmsys and display dt-bindings document from txt to yaml > - add MERGE additional description in display dt-bindings document > - fix mboxes-cells number of vdosys0 node in dts > - drop mutex eof convert define > - remove pm_runtime apis in DSC and MERGE > - change DSC and MERGE enum to alphabetic order > > Change in v2: > - add DSC yaml file > - add mt8195 drm driver porting parts in to one patch > - remove useless define, variable, structure member and function > - simplify DSC and MERGE file and switch threre order > > jason-jh.lin (12): > dt-bindings: arm: mediatek: mmsys: add power and gce properties > dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding > dt-bindings: display: mediatek: disp: split each block to individual > yaml > dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC binding > dt-bindings: display: mediatek: merge: add additional prop for mt8195 > dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0 > dt-bindings: arm: mediatek: move out common module from display folder > soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 > soc: mediatek: add mtk-mutex support for mt8195 vdosys0 > drm/mediatek: add DSC support for mediatek-drm > drm/mediatek: add MERGE support for mediatek-drm > drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 32 ++- > .../display/mediatek/mediatek,disp.txt | 219 ---------------- > .../display/mediatek/mediatek,dither.yaml | 76 ++++++ > .../display/mediatek/mediatek,dsc.yaml | 71 +++++ > .../display/mediatek/mediatek,gamma.yaml | 77 ++++++ > .../display/mediatek/mediatek,merge.yaml | 106 ++++++++ > .../display/mediatek/mediatek,od.yaml | 53 ++++ > .../display/mediatek/mediatek,ovl-2l.yaml | 88 +++++++ > .../display/mediatek/mediatek,ovl.yaml | 103 ++++++++ > .../display/mediatek/mediatek,postmask.yaml | 69 +++++ > .../display/mediatek/mediatek,rdma.yaml | 117 +++++++++ > .../display/mediatek/mediatek,split.yaml | 58 +++++ > .../display/mediatek/mediatek,ufoe.yaml | 61 +++++ > .../bindings/soc/mediatek/mediatek,aal.yaml | 72 +++++ > .../bindings/soc/mediatek/mediatek,ccorr.yaml | 46 +++- > .../bindings/soc/mediatek/mediatek,color.yaml | 81 ++++++ > .../bindings/soc/mediatek/mediatek,mutex.yaml | 77 ++++++ > .../bindings/soc/mediatek/mediatek,wdma.yaml | 47 +++- > drivers/gpu/drm/mediatek/Makefile | 1 + > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 246 ++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 63 +++++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 + > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 ++- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + > drivers/soc/mediatek/mt8195-mmsys.h | 130 +++++++++ > drivers/soc/mediatek/mtk-mmsys.c | 11 + > drivers/soc/mediatek/mtk-mutex.c | 103 +++++++- > include/linux/soc/mediatek/mtk-mmsys.h | 9 + > 30 files changed, 1832 insertions(+), 233 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml > create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,aal.yaml > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,color.yaml > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_merge.c > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h Looks like this is in linux-next and now: Error: Documentation/devicetree/bindings/display/mediatek/mediatek,aal.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,aal.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,dither.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,dither.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,od.example.dts:24.30-31 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,od.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,color.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,color.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.example.dts:35.50-51 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,split.example.dts:24.35-36 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,split.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,merge.example.dts:27.35-36 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,merge.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.example.dt.yaml] Error 1 Error: Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.example.dts:27.27-28 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:386: Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.example.dt.yaml] Error 1 Please fix 'make dt_binding_check'. Rob
Hi Rob, Thanks for the reviews. On Wed, 2022-03-02 at 17:50 -0600, Rob Herring wrote: > On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin < > jason-jh.lin@mediatek.com> wrote: > > [snip] > > jason-jh.lin (12): > > dt-bindings: arm: mediatek: mmsys: add power and gce properties > > dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding > > dt-bindings: display: mediatek: disp: split each block to > > individual > > yaml > > dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC > > binding > > dt-bindings: display: mediatek: merge: add additional prop for > > mt8195 > > dt-bindings: display: mediatek: add mt8195 SoC binding for > > vdosys0 > > dt-bindings: arm: mediatek: move out common module from display > > folder > > soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 > > soc: mediatek: add mtk-mutex support for mt8195 vdosys0 > > drm/mediatek: add DSC support for mediatek-drm > > drm/mediatek: add MERGE support for mediatek-drm > > drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 > > > > .../bindings/arm/mediatek/mediatek,mmsys.yaml | 32 ++- > > .../display/mediatek/mediatek,disp.txt | 219 -------------- > > -- > > .../display/mediatek/mediatek,dither.yaml | 76 ++++++ > > .../display/mediatek/mediatek,dsc.yaml | 71 +++++ > > .../display/mediatek/mediatek,gamma.yaml | 77 ++++++ > > .../display/mediatek/mediatek,merge.yaml | 106 ++++++++ > > .../display/mediatek/mediatek,od.yaml | 53 ++++ > > .../display/mediatek/mediatek,ovl-2l.yaml | 88 +++++++ > > .../display/mediatek/mediatek,ovl.yaml | 103 ++++++++ > > .../display/mediatek/mediatek,postmask.yaml | 69 +++++ > > .../display/mediatek/mediatek,rdma.yaml | 117 +++++++++ > > .../display/mediatek/mediatek,split.yaml | 58 +++++ > > .../display/mediatek/mediatek,ufoe.yaml | 61 +++++ > > .../bindings/soc/mediatek/mediatek,aal.yaml | 72 +++++ > > .../bindings/soc/mediatek/mediatek,ccorr.yaml | 46 +++- > > .../bindings/soc/mediatek/mediatek,color.yaml | 81 ++++++ > > .../bindings/soc/mediatek/mediatek,mutex.yaml | 77 ++++++ > > .../bindings/soc/mediatek/mediatek,wdma.yaml | 47 +++- > > drivers/gpu/drm/mediatek/Makefile | 1 + > > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + > > drivers/gpu/drm/mediatek/mtk_disp_merge.c | 246 > > ++++++++++++++++++ > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 63 +++++ > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 + > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 ++- > > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + > > drivers/soc/mediatek/mt8195-mmsys.h | 130 +++++++++ > > drivers/soc/mediatek/mtk-mmsys.c | 11 + > > drivers/soc/mediatek/mtk-mutex.c | 103 +++++++- > > include/linux/soc/mediatek/mtk-mmsys.h | 9 + > > 30 files changed, 1832 insertions(+), 233 deletions(-) > > delete mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.tx > > t > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,dither. > > yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yam > > l > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y > > aml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,merge.y > > aml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl- > > 2l.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam > > l > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,postmas > > k.yaml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya > > ml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,split.y > > aml > > create mode 100644 > > Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.ya > > ml > > create mode 100644 > > Documentation/devicetree/bindings/soc/mediatek/mediatek,aal.yaml > > create mode 100644 > > Documentation/devicetree/bindings/soc/mediatek/mediatek,color.yaml > > create mode 100644 > > Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml > > create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_merge.c > > create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h > > Looks like this is in linux-next and now: > > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,aal.examp > le.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,aal.examp > le.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.exam > ple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,wdma.exam > ple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.exa > mple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,dither.ex > ample.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,dither.ex > ample.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,postmask. > example.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,postmask. > example.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.exam > ple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.exam > ple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.exa > mple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.exam > ple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.exam > ple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,od.exampl > e.dts:24.30-31 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,od.exampl > e.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,color.exa > mple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,color.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.exa > mple.dts:35.50-51 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,split.exa > mple.dts:24.35-36 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,split.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,merge.exa > mple.dts:27.35-36 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,merge.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.exa > mple.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,mutex.exa > mple.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.examp > le.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.examp > le.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl- > 2l.example.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl- > 2l.example.dt.yaml] > Error 1 > Error: > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.examp > le.dts:27.27-28 > syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:386: > Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.examp > le.dt.yaml] > Error 1 > > Please fix 'make dt_binding_check'. > > Rob
Il 03/03/22 05:25, Jason-JH Lin ha scritto: > Hi Rob, > > Thanks for the reviews. > > On Wed, 2022-03-02 at 17:50 -0600, Rob Herring wrote: >> On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin < >> jason-jh.lin@mediatek.com> wrote: >>> > > [snip] > Hello Rob, Jason-JH, I have just crafted a patch that fixes everything mentioned here, if it's easier like this, I can either send it for the maintainer(s) to apply on top, or squash in Jason-JH's original patch. If you'd like to get my patch, though, I have one question: this is touching literally all of the YAML files that Jason-JH is introducing, so, should I send this as one patch per file (which would be something around 16 patches) or is just one fixing them all fine? Cheers, Angelo
Hi Angelo, Because linux-next has applied these patches: [v15,04/12] dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC binding [v15,05/12] dt-bindings: display: mediatek: merge: add additional prop for mt8195 [v15,06/12] dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0 [v15,03/12] dt-bindings: display: mediatek: disp: split each block to individual yaml I'll rebase on the latest linux-next, and then send 1 path + 1 series: [1] a fix up patch for all dt-schema error in each display dt-bindings (If Rob wants me to split this patch into separate patches for each file, then I'll resend it.) [2] a series of remaining patches of this series I would appreciate it if you would take the time to send [1] for me. If you can help me to send [1], please let me know. Thank you very much ;-) Regards, Jason-JH.Lin On Thu, 2022-03-03 at 10:31 +0100, AngeloGioacchino Del Regno wrote: > Il 03/03/22 05:25, Jason-JH Lin ha scritto: > > Hi Rob, > > > > Thanks for the reviews. > > > > On Wed, 2022-03-02 at 17:50 -0600, Rob Herring wrote: > > > On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin < > > > jason-jh.lin@mediatek.com> wrote: > > > > > > > > [snip] > > > > Hello Rob, Jason-JH, > > I have just crafted a patch that fixes everything mentioned here, > if it's easier like this, I can either send it for the maintainer(s) > to apply on top, or squash in Jason-JH's original patch. > > If you'd like to get my patch, though, I have one question: > this is touching literally all of the YAML files that Jason-JH is > introducing, so, should I send this as one patch per file (which > would be > something around 16 patches) or is just one fixing them all fine? > > Cheers, > Angelo > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!3tXE3T-t6I2GMILAOHpkTXhrLHwFAQtmhGqTBtKSY2SLWM2qBBMULlM17TtG6VwNR5yn$ >
Il 04/03/22 06:26, Jason-JH Lin ha scritto: > Hi Angelo, > > Because linux-next has applied these patches: > > [v15,04/12] dt-bindings: display: mediatek: dsc: add yaml for mt8195 > SoC binding > [v15,05/12] dt-bindings: display: mediatek: merge: add additional prop > for mt8195 > [v15,06/12] dt-bindings: display: mediatek: add mt8195 SoC binding for > vdosys0 > [v15,03/12] dt-bindings: display: mediatek: disp: split each block to > individual yaml > > > I'll rebase on the latest linux-next, and then send 1 path + 1 series: > [1] a fix up patch for all dt-schema error in each display dt-bindings > (If Rob wants me to split this patch into separate patches for each > file, then I'll resend it.) > [2] a series of remaining patches of this series > > > I would appreciate it if you would take the time to send [1] for me. > If you can help me to send [1], please let me know. > Thank you very much ;-) > > I will send fixes for [1] later today. Cheers, Angelo > Regards, > Jason-JH.Lin > > On Thu, 2022-03-03 at 10:31 +0100, AngeloGioacchino Del Regno wrote: >> Il 03/03/22 05:25, Jason-JH Lin ha scritto: >>> Hi Rob, >>> >>> Thanks for the reviews. >>> >>> On Wed, 2022-03-02 at 17:50 -0600, Rob Herring wrote: >>>> On Wed, Jan 26, 2022 at 1:19 AM jason-jh.lin < >>>> jason-jh.lin@mediatek.com> wrote: >>>>> >>> >>> [snip] >>> >> >> Hello Rob, Jason-JH, >> >> I have just crafted a patch that fixes everything mentioned here, >> if it's easier like this, I can either send it for the maintainer(s) >> to apply on top, or squash in Jason-JH's original patch. >> >> If you'd like to get my patch, though, I have one question: >> this is touching literally all of the YAML files that Jason-JH is >> introducing, so, should I send this as one patch per file (which >> would be >> something around 16 patches) or is just one fixing them all fine? >> >> Cheers, >> Angelo >> >> _______________________________________________ >> Linux-mediatek mailing list >> Linux-mediatek@lists.infradead.org >> > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!3tXE3T-t6I2GMILAOHpkTXhrLHwFAQtmhGqTBtKSY2SLWM2qBBMULlM17TtG6VwNR5yn$ >>
Change in v15: - remove mt8195-mmsys.h comment for mux settings - define the mask macro to replace using value as mask to fix zero mask problem - add EOF setting comment for MUTEX sof register Change in v14: - rebase on mediatek-drm-next-5.17 - rebase on "Add mmsys and mutex support for MDP" series https://patchwork.kernel.org/project/linux-mediatek/list/?series=602528 - rebase on "media: mediatek: support mdp3 on mt8183 platform" series https://patchwork.kernel.org/project/linux-mediatek/list/?series=602834 Change in v13: - remove dts patch - rebase on kernel-5.16-rc1 - rebase on mediatek-drm-next Change in v12: - add clock-names property to merge yaml - using BIT(nr) macro to define the settings of mmsys routing table - fix clk_get and clk_prepare_enable error handling issue Change in v11: - rebase on kernel-5.15-rc1 - change mbox label to gce0 for dts node of vdosys0 - change ovl compatibale to mt8192 to set smi_id_en=true in driver data - move common module from display folder to common folder, such as AAL, COCLOR, CCORR and MUTEX Change in v10: - rebase on "drm/mediatek: add support for mediatek SOC MT8192" series https://patchwork.kernel.org/project/linux-mediatek/list/?series=529489 - rebase on "soc: mediatek: mmsys: add mt8192 mmsys support" series https://patchwork.kernel.org/project/linux-mediatek/list/?series=524857 - fix some typo and "mediatek" start with capital in every dt-bindings - move mutex yaml from dfisplay folder to soc folder - separate merge additional propoerties to an individual dt-bindings patch Change in v9: - separate power and gce properties of mmsys into another dt-binding patch - rebase on "Separate aal module" series https://patchwork.kernel.org/project/linux-mediatek/list/?series=516463 - keep mtk_ddp_clk_enable/disable in the same place - change mtk_dsc_start config register to mtk_drm_ddp_write_mask - remove the 0 setting of merge fifo config function - add CCORR driver data for mt8195 Change in v8: - add DP_INTF0 mux into mmsys routing table - add DP_INTF0 mutex mod and enum into add/remove comp function - remove bypass DSC enum in mtk_ddp_comp_init Change in v7: - add dt=binding of mmsys and disp path into this series - separate th modidfication of alphabetic order, remove unused define and rename the define of register offset to individual patch - add comment for MERGE ultra and preultra setting Change in v6: - adjust alphabetic order for mediatek-drm - move the patch that add mt8195 support for mediatek-drm as the lastest patch - add MERGE define for const varriable Change in v5: - add power-domain property into vdosys0 and vdosys1 dts node. - add MT8195 prifix and remove unused VDO1 define in mt8195-mmsys.h Change in v4: - extract dt-binding patches to another patch series https://patchwork.kernel.org/project/linux-mediatek/list/?series=519597 - squash DSC module into mtk_drm_ddp_comp.c - add coment and simplify MERGE config function Change in v3: - change mmsys and display dt-bindings document from txt to yaml - add MERGE additional description in display dt-bindings document - fix mboxes-cells number of vdosys0 node in dts - drop mutex eof convert define - remove pm_runtime apis in DSC and MERGE - change DSC and MERGE enum to alphabetic order Change in v2: - add DSC yaml file - add mt8195 drm driver porting parts in to one patch - remove useless define, variable, structure member and function - simplify DSC and MERGE file and switch threre order jason-jh.lin (12): dt-bindings: arm: mediatek: mmsys: add power and gce properties dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding dt-bindings: display: mediatek: disp: split each block to individual yaml dt-bindings: display: mediatek: dsc: add yaml for mt8195 SoC binding dt-bindings: display: mediatek: merge: add additional prop for mt8195 dt-bindings: display: mediatek: add mt8195 SoC binding for vdosys0 dt-bindings: arm: mediatek: move out common module from display folder soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 soc: mediatek: add mtk-mutex support for mt8195 vdosys0 drm/mediatek: add DSC support for mediatek-drm drm/mediatek: add MERGE support for mediatek-drm drm/mediatek: add mediatek-drm of vdosys0 support for mt8195 .../bindings/arm/mediatek/mediatek,mmsys.yaml | 32 ++- .../display/mediatek/mediatek,disp.txt | 219 ---------------- .../display/mediatek/mediatek,dither.yaml | 76 ++++++ .../display/mediatek/mediatek,dsc.yaml | 71 +++++ .../display/mediatek/mediatek,gamma.yaml | 77 ++++++ .../display/mediatek/mediatek,merge.yaml | 106 ++++++++ .../display/mediatek/mediatek,od.yaml | 53 ++++ .../display/mediatek/mediatek,ovl-2l.yaml | 88 +++++++ .../display/mediatek/mediatek,ovl.yaml | 103 ++++++++ .../display/mediatek/mediatek,postmask.yaml | 69 +++++ .../display/mediatek/mediatek,rdma.yaml | 117 +++++++++ .../display/mediatek/mediatek,split.yaml | 58 +++++ .../display/mediatek/mediatek,ufoe.yaml | 61 +++++ .../bindings/soc/mediatek/mediatek,aal.yaml | 72 +++++ .../bindings/soc/mediatek/mediatek,ccorr.yaml | 46 +++- .../bindings/soc/mediatek/mediatek,color.yaml | 81 ++++++ .../bindings/soc/mediatek/mediatek,mutex.yaml | 77 ++++++ .../bindings/soc/mediatek/mediatek,wdma.yaml | 47 +++- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + drivers/gpu/drm/mediatek/mtk_disp_merge.c | 246 ++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 63 +++++ drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 32 ++- drivers/gpu/drm/mediatek/mtk_drm_drv.h | 1 + drivers/soc/mediatek/mt8195-mmsys.h | 130 +++++++++ drivers/soc/mediatek/mtk-mmsys.c | 11 + drivers/soc/mediatek/mtk-mutex.c | 103 +++++++- include/linux/soc/mediatek/mtk-mmsys.h | 9 + 30 files changed, 1832 insertions(+), 233 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dither.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dsc.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,od.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,postmask.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,ufoe.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,aal.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,color.yaml create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml create mode 100644 drivers/gpu/drm/mediatek/mtk_disp_merge.c create mode 100644 drivers/soc/mediatek/mt8195-mmsys.h