| Message ID | 20220304115257.1816983-4-ani@anisinha.ca (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table | expand |
On Fri, Mar 04, 2022 at 05:22:57PM +0530, Ani Sinha wrote: > From: Liav Albani <liavalb@gmail.com> > > After changing the IAPC boot flags register to indicate support of i8042 > in the machine chipset to help the guest OS to determine its existence > "faster", we need to have the updated FACP ACPI binary images in tree. > > The ASL changes introduced are shown by the following diff: > > @@ -42,35 +42,35 @@ > [059h 0089 1] PM1 Control Block Length : 02 > [05Ah 0090 1] PM2 Control Block Length : 00 > [05Bh 0091 1] PM Timer Block Length : 04 > [05Ch 0092 1] GPE0 Block Length : 10 > [05Dh 0093 1] GPE1 Block Length : 00 > [05Eh 0094 1] GPE1 Base Offset : 00 > [05Fh 0095 1] _CST Support : 00 > [060h 0096 2] C2 Latency : 0FFF > [062h 0098 2] C3 Latency : 0FFF > [064h 0100 2] CPU Cache Size : 0000 > [066h 0102 2] Cache Flush Stride : 0000 > [068h 0104 1] Duty Cycle Offset : 00 > [069h 0105 1] Duty Cycle Width : 00 > [06Ah 0106 1] RTC Day Alarm Index : 00 > [06Bh 0107 1] RTC Month Alarm Index : 00 > [06Ch 0108 1] RTC Century Index : 32 > -[06Dh 0109 2] Boot Flags (decoded below) : 0000 > +[06Dh 0109 2] Boot Flags (decoded below) : 0002 > Legacy Devices Supported (V2) : 0 > - 8042 Present on ports 60/64 (V2) : 0 > + 8042 Present on ports 60/64 (V2) : 1 > VGA Not Present (V4) : 0 > MSI Not Supported (V4) : 0 > PCIe ASPM Not Supported (V4) : 0 > CMOS RTC Not Present (V5) : 0 > [06Fh 0111 1] Reserved : 00 > [070h 0112 4] Flags (decoded below) : 000084A5 > WBINVD instruction is operational (V1) : 1 > WBINVD flushes all caches (V1) : 0 > All CPUs support C1 (V1) : 1 > C2 works on MP system (V1) : 0 > Control Method Power Button (V1) : 0 > Control Method Sleep Button (V1) : 1 > RTC wake not in fixed reg space (V1) : 0 > RTC can wake system from S4 (V1) : 1 > 32-bit PM Timer (V1) : 0 > Docking Supported (V1) : 0 > > Signed-off-by: Liav Albani <liavalb@gmail.com> > Acked-by: Ani Sinha <ani@anisinha.ca> Fails make check: ▶ 3/60 ERROR:../tests/qtest/bios-tables-test.c:532:test_acpi_asl: assertion failed: (all_tables_match) ERROR > --- > tests/data/acpi/q35/FACP | Bin 244 -> 244 bytes > tests/data/acpi/q35/FACP.nosmm | Bin 244 -> 244 bytes > tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes > tests/data/acpi/q35/FACP.xapic | Bin 244 -> 244 bytes > tests/qtest/bios-tables-test-allowed-diff.h | 4 ---- > 5 files changed, 4 deletions(-) > > diff --git a/tests/data/acpi/q35/FACP b/tests/data/acpi/q35/FACP > index f6a864cc863c7763f6c09d3814ad184a658fa0a0..a8f6a8961109d01059aceef9f1869cde09a2f10c 100644 > GIT binary patch > delta 23 > ecmeyu_=S<n&CxmF3j+fK^Y)2c$&5@B^V$GgGY3Ne > > delta 23 > ecmeyu_=S<n&CxmF3j+fK^UjG}$&3sW^V$GgJqJSo > > diff --git a/tests/data/acpi/q35/FACP.nosmm b/tests/data/acpi/q35/FACP.nosmm > index 6a9aa5f370eb9af6a03dc739d8a159be58fdee01..c4e6d18ee5fc64159160d4589aa96b4d648c913a 100644 > GIT binary patch > delta 23 > ecmeyu_=S<n&CxmF3j+fKbKXR*WJacmd2Ik#q6Yc^ > > delta 23 > ecmeyu_=S<n&CxmF3j+fKbHPNeWJZRGd2Ik#tOoi3 > > diff --git a/tests/data/acpi/q35/FACP.slic b/tests/data/acpi/q35/FACP.slic > index 15986e095cf2db7ee92f7ce113c1d46d54018c62..48bbb1cf5ad0ceda1d2f6d56edf5c1e207bd1a04 100644 > GIT binary patch > delta 23 > ecmeyu_=S<n&CxmF3j+fK^M#3A$&5@B^V$Gh6bD=Y > > delta 23 > ecmeyu_=S<n&CxmF3j+fK^QDPg$&3sW^V$Gh9tT_i > > diff --git a/tests/data/acpi/q35/FACP.xapic b/tests/data/acpi/q35/FACP.xapic > index 2d3659c9c6753d07c3d48742343cb8e8cc034de7..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644 > GIT binary patch > delta 23 > ecmeyu_=S<n&CxmF3j+fK^X7?M$&5@B^V$Gg4+lR0 > > delta 23 > ecmeyu_=S<n&CxmF3j+fK^VW%6$&3sW^V$Gg83#WA > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index 7570e39369..dfb8523c8b 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1,5 +1 @@ > /* List of comma-separated changed AML files to ignore */ > -"tests/data/acpi/q35/FACP", > -"tests/data/acpi/q35/FACP.nosmm", > -"tests/data/acpi/q35/FACP.slic", > -"tests/data/acpi/q35/FACP.xapic", > -- > 2.25.1
On Fri, Mar 4, 2022 at 6:49 PM Michael S. Tsirkin <mst@redhat.com> wrote: > > On Fri, Mar 04, 2022 at 05:22:57PM +0530, Ani Sinha wrote: > > From: Liav Albani <liavalb@gmail.com> > > > > After changing the IAPC boot flags register to indicate support of i8042 > > in the machine chipset to help the guest OS to determine its existence > > "faster", we need to have the updated FACP ACPI binary images in tree. > > > > The ASL changes introduced are shown by the following diff: > > > > @@ -42,35 +42,35 @@ > > [059h 0089 1] PM1 Control Block Length : 02 > > [05Ah 0090 1] PM2 Control Block Length : 00 > > [05Bh 0091 1] PM Timer Block Length : 04 > > [05Ch 0092 1] GPE0 Block Length : 10 > > [05Dh 0093 1] GPE1 Block Length : 00 > > [05Eh 0094 1] GPE1 Base Offset : 00 > > [05Fh 0095 1] _CST Support : 00 > > [060h 0096 2] C2 Latency : 0FFF > > [062h 0098 2] C3 Latency : 0FFF > > [064h 0100 2] CPU Cache Size : 0000 > > [066h 0102 2] Cache Flush Stride : 0000 > > [068h 0104 1] Duty Cycle Offset : 00 > > [069h 0105 1] Duty Cycle Width : 00 > > [06Ah 0106 1] RTC Day Alarm Index : 00 > > [06Bh 0107 1] RTC Month Alarm Index : 00 > > [06Ch 0108 1] RTC Century Index : 32 > > -[06Dh 0109 2] Boot Flags (decoded below) : 0000 > > +[06Dh 0109 2] Boot Flags (decoded below) : 0002 > > Legacy Devices Supported (V2) : 0 > > - 8042 Present on ports 60/64 (V2) : 0 > > + 8042 Present on ports 60/64 (V2) : 1 > > VGA Not Present (V4) : 0 > > MSI Not Supported (V4) : 0 > > PCIe ASPM Not Supported (V4) : 0 > > CMOS RTC Not Present (V5) : 0 > > [06Fh 0111 1] Reserved : 00 > > [070h 0112 4] Flags (decoded below) : 000084A5 > > WBINVD instruction is operational (V1) : 1 > > WBINVD flushes all caches (V1) : 0 > > All CPUs support C1 (V1) : 1 > > C2 works on MP system (V1) : 0 > > Control Method Power Button (V1) : 0 > > Control Method Sleep Button (V1) : 1 > > RTC wake not in fixed reg space (V1) : 0 > > RTC can wake system from S4 (V1) : 1 > > 32-bit PM Timer (V1) : 0 > > Docking Supported (V1) : 0 > > > > Signed-off-by: Liav Albani <liavalb@gmail.com> > > Acked-by: Ani Sinha <ani@anisinha.ca> > > Fails make check: > ▶ 3/60 ERROR:../tests/qtest/bios-tables-test.c:532:test_acpi_asl: assertion failed: (all_tables_match) ERROR Unable to repro this even after rebasing to latest master.
diff --git a/tests/data/acpi/q35/FACP b/tests/data/acpi/q35/FACP index f6a864cc863c7763f6c09d3814ad184a658fa0a0..a8f6a8961109d01059aceef9f1869cde09a2f10c 100644 GIT binary patch delta 23 ecmeyu_=S<n&CxmF3j+fK^Y)2c$&5@B^V$GgGY3Ne delta 23 ecmeyu_=S<n&CxmF3j+fK^UjG}$&3sW^V$GgJqJSo diff --git a/tests/data/acpi/q35/FACP.nosmm b/tests/data/acpi/q35/FACP.nosmm index 6a9aa5f370eb9af6a03dc739d8a159be58fdee01..c4e6d18ee5fc64159160d4589aa96b4d648c913a 100644 GIT binary patch delta 23 ecmeyu_=S<n&CxmF3j+fKbKXR*WJacmd2Ik#q6Yc^ delta 23 ecmeyu_=S<n&CxmF3j+fKbHPNeWJZRGd2Ik#tOoi3 diff --git a/tests/data/acpi/q35/FACP.slic b/tests/data/acpi/q35/FACP.slic index 15986e095cf2db7ee92f7ce113c1d46d54018c62..48bbb1cf5ad0ceda1d2f6d56edf5c1e207bd1a04 100644 GIT binary patch delta 23 ecmeyu_=S<n&CxmF3j+fK^M#3A$&5@B^V$Gh6bD=Y delta 23 ecmeyu_=S<n&CxmF3j+fK^QDPg$&3sW^V$Gh9tT_i diff --git a/tests/data/acpi/q35/FACP.xapic b/tests/data/acpi/q35/FACP.xapic index 2d3659c9c6753d07c3d48742343cb8e8cc034de7..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644 GIT binary patch delta 23 ecmeyu_=S<n&CxmF3j+fK^X7?M$&5@B^V$Gg4+lR0 delta 23 ecmeyu_=S<n&CxmF3j+fK^VW%6$&3sW^V$Gg83#WA diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index 7570e39369..dfb8523c8b 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1,5 +1 @@ /* List of comma-separated changed AML files to ignore */ -"tests/data/acpi/q35/FACP", -"tests/data/acpi/q35/FACP.nosmm", -"tests/data/acpi/q35/FACP.slic", -"tests/data/acpi/q35/FACP.xapic",