| Message ID | 20220303201312.3255347-1-kbusch@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | 64-bit data integrity field support | expand |
Hi Jens, I believe this is looking ready at this point. Would it be too ambitious to see this applied ahead of 5.18? The block layer provides the focal point for new capabilities in this series, so I feel it should go through that tree if you're okay with this. Thanks, Keith
On Thu, 3 Mar 2022 12:13:04 -0800, Keith Busch wrote: > The NVM Express protocol added enhancements to the data integrity field > formats beyond the T10 defined protection information. A detailed > description of the new formats can be found in the NVMe's NVM Command > Set Specification, section 5.2, available at: > > https://nvmexpress.org/wp-content/uploads/NVM-Command-Set-Specification-1.0b-2021.12.18-Ratified.pdf > > [...] Applied, thanks! [1/8] block: support pi with extended metadata commit: c340b990d58c856c1636e0c10abb9e4351ad852a [2/8] nvme: allow integrity on extended metadata formats commit: 84b735429f5fe6f57fc0b3fff3932dce1471e668 [3/8] asm-generic: introduce be48 unaligned accessors commit: c2ea5fcf53d5f21e6aff0de11d55bc202822df6a [4/8] linux/kernel: introduce lower_48_bits function commit: 7ee8809df990d1de379002973baee1681e8d7dd3 [5/8] lib: add rocksoft model crc64 commit: cbc0a40e17da361a2ada8d669413ccfbd2028f2d [6/8] crypto: add rocksoft 64b crc guard tag framework commit: f3813f4b287e480b1fcd62ca798d8556644b8278 [7/8] block: add pi for extended integrity commit: a7d4383f17e10f338ea757a849f02298790d24fb [8/8] nvme: add support for enhanced metadata commit: 4020aad85c6785ddac8d51f345ff9e3328ce773a Best regards,
On 3/7/22 12:34 PM, Keith Busch wrote: > Hi Jens, > > I believe this is looking ready at this point. Would it be too ambitious > to see this applied ahead of 5.18? The block layer provides the focal > point for new capabilities in this series, so I feel it should go > through that tree if you're okay with this. Layered it on top of the write-streams changes to avoid a silly conflict.
The NVM Express protocol added enhancements to the data integrity field formats beyond the T10 defined protection information. A detailed description of the new formats can be found in the NVMe's NVM Command Set Specification, section 5.2, available at: https://nvmexpress.org/wp-content/uploads/NVM-Command-Set-Specification-1.0b-2021.12.18-Ratified.pdf This series implements one possible new format: the CRC64 guard with 48-bit reference tags. This does not add support for the variable "storage tag" field, or any potential hardware acceleration. Changes since v3: - Replaced lower_48_bits() macro with inline function, and replaced 0xffffffffffffull with the equivalent (1ull << 48) - 1 - Replaced crc64 test module with new entry in crypto/testmgr.c - Renamed nvme_ function prefixes with ext_pi_ - Placed bit inversion within crc64 calculation rather than rely on the caller to pass in an inverted initial value. This is necessary to update the crc value when its buffer is discontiguous, or updated in chunks. - Removed 'inline' from nvme driver's ref tag setup. - Added Review's for unchanged patches, removed reviews for the ones that changed. - lib/Kconfig dependency fix - Dropped the x86_64 PCLMULQDQ accelerated calculation. This task will be completed by people more experienced in this area, so expect a follow up soon. Keith Busch (8): block: support pi with extended metadata nvme: allow integrity on extended metadata formats asm-generic: introduce be48 unaligned accessors linux/kernel: introduce lower_48_bits function lib: add rocksoft model crc64 crypto: add rocksoft 64b crc guard tag framework block: add pi for nvme enhanced integrity nvme: add support for enhanced metadata block/Kconfig | 1 + block/bio-integrity.c | 1 + block/t10-pi.c | 198 +++++++++++++++++++++++++++++++- crypto/Kconfig | 5 + crypto/Makefile | 1 + crypto/crc64_rocksoft_generic.c | 89 ++++++++++++++ crypto/testmgr.c | 7 ++ crypto/testmgr.h | 15 +++ drivers/nvme/host/core.c | 165 +++++++++++++++++++++----- drivers/nvme/host/nvme.h | 4 +- include/asm-generic/unaligned.h | 26 +++++ include/linux/blk-integrity.h | 1 + include/linux/crc64.h | 7 ++ include/linux/kernel.h | 9 ++ include/linux/nvme.h | 53 ++++++++- include/linux/t10-pi.h | 20 ++++ lib/Kconfig | 9 ++ lib/Makefile | 1 + lib/crc64-rocksoft.c | 129 +++++++++++++++++++++ lib/crc64.c | 28 +++++ lib/gen_crc64table.c | 51 ++++++-- 21 files changed, 773 insertions(+), 47 deletions(-) create mode 100644 crypto/crc64_rocksoft_generic.c create mode 100644 lib/crc64-rocksoft.c