| Message ID | 20220308023325.31702-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5575f7f49134c7386a684335c9007737c606d3b5 |
| Headers | show |
| Series | ASoC: SOF: Add missing of_node_put() in imx8m_probe | expand |
On 08/03/2022 04:33, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> > Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > sound/soc/sof/imx/imx8m.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c > index 788e77bcb603..60251486b24b 100644 > --- a/sound/soc/sof/imx/imx8m.c > +++ b/sound/soc/sof/imx/imx8m.c > @@ -224,6 +224,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev) > } > > ret = of_address_to_resource(res_node, 0, &res); > + of_node_put(res_node); > if (ret) { > dev_err(&pdev->dev, "failed to get reserved region address\n"); > goto exit_pdev_unregister;
On Tue, 8 Mar 2022 02:33:23 +0000, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: Add missing of_node_put() in imx8m_probe commit: 5575f7f49134c7386a684335c9007737c606d3b5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c index 788e77bcb603..60251486b24b 100644 --- a/sound/soc/sof/imx/imx8m.c +++ b/sound/soc/sof/imx/imx8m.c @@ -224,6 +224,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev) } ret = of_address_to_resource(res_node, 0, &res); + of_node_put(res_node); if (ret) { dev_err(&pdev->dev, "failed to get reserved region address\n"); goto exit_pdev_unregister;
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- sound/soc/sof/imx/imx8m.c | 1 + 1 file changed, 1 insertion(+)