| Message ID | 20220308024751.2320-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b19ab4b38b06aae12442b2de95ccf58b5dc53584 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ethernet: Fix error handling in xemaclite_of_probe | expand |
On Tue, Mar 08, 2022 at 02:47:49AM +0000, Miaoqian Lin wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. Calling of_node_put() to avoid the > refcount leak. As the remove function do. > > Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 8 Mar 2022 02:47:49 +0000 you wrote: > This node pointer is returned by of_parse_phandle() with refcount > incremented in this function. Calling of_node_put() to avoid the > refcount leak. As the remove function do. > > Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > > [...] Here is the summary with links: - ethernet: Fix error handling in xemaclite_of_probe https://git.kernel.org/netdev/net/c/b19ab4b38b06 You are awesome, thank you!
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 519599480b15..77fa2cb03aca 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -1183,7 +1183,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) if (rc) { dev_err(dev, "Cannot register network device, aborting\n"); - goto error; + goto put_node; } dev_info(dev, @@ -1191,6 +1191,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev) (unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq); return 0; +put_node: + of_node_put(lp->phy_node); error: free_netdev(ndev); return rc;
This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. As the remove function do. Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)