mbox series

[iproute2-next,V2,0/4] Add support for locked bridge ports (for 802.1X)

Message ID 20220228133650.31358-1-schultz.hans+netdev@gmail.com (mailing list archive)
Headers show
Series Add support for locked bridge ports (for 802.1X) | expand

Message

Hans S Feb. 28, 2022, 1:36 p.m. UTC
This patch set is to complement the kernel locked port patches, such
that iproute2 can be used to lock/unlock a port and check if a port
is locked or not. To lock or unlock a port use the command:

bridge link set dev DEV locked {on | off}


To show the detailed setting of a port, including if the locked flag is
enabled for the port(s), use the command:

bridge -d link show [dev DEV]


Hans Schultz (4):
  bridge: link: add command to set port in locked mode
  ip: iplink_bridge_slave: add locked port flag support
  man8/bridge.8: add locked port feature description and cmd syntax
  man8/ip-link.8: add locked port feature description and cmd syntax

 bridge/link.c                | 13 +++++++++++++
 include/uapi/linux/if_link.h |  1 +
 ip/iplink_bridge_slave.c     |  9 +++++++++
 man/man8/bridge.8            | 11 +++++++++++
 man/man8/ip-link.8.in        |  6 ++++++
 5 files changed, 40 insertions(+)

Comments

patchwork-bot+netdevbpf@kernel.org March 4, 2022, 4:20 p.m. UTC | #1
Hello:

This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Mon, 28 Feb 2022 14:36:46 +0100 you wrote:
> This patch set is to complement the kernel locked port patches, such
> that iproute2 can be used to lock/unlock a port and check if a port
> is locked or not. To lock or unlock a port use the command:
> 
> bridge link set dev DEV locked {on | off}
> 
> 
> [...]

Here is the summary with links:
  - [iproute2-next,V2,1/4] bridge: link: add command to set port in locked mode
    (no matching commit)
  - [iproute2-next,V2,2/4] ip: iplink_bridge_slave: add locked port flag support
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=092af16b7eed
  - [iproute2-next,V2,3/4] man8/bridge.8: add locked port feature description and cmd syntax
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=d4fe36736dfb
  - [iproute2-next,V2,4/4] man8/ip-link.8: add locked port feature description and cmd syntax
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=0a685b987c06

You are awesome, thank you!
Hans S March 11, 2022, 8:54 a.m. UTC | #2
On mån, feb 28, 2022 at 14:36, Hans Schultz <schultz.hans@gmail.com> wrote:
> This patch set is to complement the kernel locked port patches, such
> that iproute2 can be used to lock/unlock a port and check if a port
> is locked or not. To lock or unlock a port use the command:
>
> bridge link set dev DEV locked {on | off}
>
>
> To show the detailed setting of a port, including if the locked flag is
> enabled for the port(s), use the command:
>
> bridge -d link show [dev DEV]
>
>
> Hans Schultz (4):
>   bridge: link: add command to set port in locked mode
>   ip: iplink_bridge_slave: add locked port flag support
>   man8/bridge.8: add locked port feature description and cmd syntax
>   man8/ip-link.8: add locked port feature description and cmd syntax
>
>  bridge/link.c                | 13 +++++++++++++
>  include/uapi/linux/if_link.h |  1 +
>  ip/iplink_bridge_slave.c     |  9 +++++++++
>  man/man8/bridge.8            | 11 +++++++++++
>  man/man8/ip-link.8.in        |  6 ++++++
>  5 files changed, 40 insertions(+)
>
> -- 
> 2.30.2

Hi!

Would it be an idea to add a switch to iproute2 commands that would list
the supported features of the current version of the command (or all of
iproute2)  instead of having to deduce it indirectly?

F.ex. a feature I am adding will only work indirectly with iproute2, and
thus it will be difficult to determine if the feature is available or
not.

Hans