| Message ID | 20220311143941.9628-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: remove reference to the removed config NFSD_V3 | expand |
> On Mar 11, 2022, at 9:39 AM, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config > NFSD_V3, but misses one reference in fs/Kconfig. > > Remove this remaining reference to the removed config symbol. > > This issue was discovered with ./scripts/checkkconfigsymbols.py. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > Chuck, please pick this quick fix to your commit in linux-next. > > fs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/Kconfig b/fs/Kconfig > index 7f2455e8e18a..ec2cf8ccd170 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -344,7 +344,7 @@ config LOCKD > > config LOCKD_V4 > bool > - depends on NFSD_V3 || NFS_V3 > + depends on NFS_V3 Actually, I think: depends on NFSD || NFS_V3 is more correct. LOCKD_V4 now needs to be enabled whenever the server is enabled, since NFSv3 support in the server is now always enabled. > depends on FILE_LOCKING > default y > > -- > 2.17.1 > -- Chuck Lever
> On Mar 11, 2022, at 10:23 AM, Chuck Lever III <chuck.lever@oracle.com> wrote: > > > >> On Mar 11, 2022, at 9:39 AM, Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: >> >> Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config >> NFSD_V3, but misses one reference in fs/Kconfig. >> >> Remove this remaining reference to the removed config symbol. >> >> This issue was discovered with ./scripts/checkkconfigsymbols.py. >> >> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> >> --- >> Chuck, please pick this quick fix to your commit in linux-next. >> >> fs/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/Kconfig b/fs/Kconfig >> index 7f2455e8e18a..ec2cf8ccd170 100644 >> --- a/fs/Kconfig >> +++ b/fs/Kconfig >> @@ -344,7 +344,7 @@ config LOCKD >> >> config LOCKD_V4 >> bool >> - depends on NFSD_V3 || NFS_V3 >> + depends on NFS_V3 > > Actually, I think: > > depends on NFSD || NFS_V3 > > is more correct. LOCKD_V4 now needs to be enabled whenever > the server is enabled, since NFSv3 support in the server is > now always enabled. I've squashed this change into "NFSD: Remove CONFIG_NFSD_V3". Thanks for reporting it, Lukas! >> depends on FILE_LOCKING >> default y >> >> -- >> 2.17.1 >> > > -- > Chuck Lever -- Chuck Lever
diff --git a/fs/Kconfig b/fs/Kconfig index 7f2455e8e18a..ec2cf8ccd170 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -344,7 +344,7 @@ config LOCKD config LOCKD_V4 bool - depends on NFSD_V3 || NFS_V3 + depends on NFS_V3 depends on FILE_LOCKING default y
Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config NFSD_V3, but misses one reference in fs/Kconfig. Remove this remaining reference to the removed config symbol. This issue was discovered with ./scripts/checkkconfigsymbols.py. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Chuck, please pick this quick fix to your commit in linux-next. fs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)