diff mbox series

[net-next,01/13] can: vxcan: vxcan_xmit(): use kfree_skb() instead of kfree() to free skb

Message ID 20220313085138.507062-2-mkl@pengutronix.de (mailing list archive)
State Accepted
Commit fc7dcd05f4c2660cf665bb1c2b9cd82e8d9d8bd8
Delegated to: Netdev Maintainers
Headers show
Series [net-next,01/13] can: vxcan: vxcan_xmit(): use kfree_skb() instead of kfree() to free skb | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Pull request is its own cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: wg@grandegger.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Marc Kleine-Budde March 13, 2022, 8:51 a.m. UTC
This patch fixes the freeing of the "oskb", by using kfree_skb()
instead of kfree().

Fixes: 1574481bb3de ("vxcan: remove sk reference in peer skb")
Link: https://lore.kernel.org/all/20220311123741.382618-1-mkl@pengutronix.de
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/vxcan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 97aeb877de7f14f819fc2cf8388d7a2d8090489d

Comments

patchwork-bot+netdevbpf@kernel.org March 13, 2022, 10:30 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Marc Kleine-Budde <mkl@pengutronix.de>:

On Sun, 13 Mar 2022 09:51:26 +0100 you wrote:
> This patch fixes the freeing of the "oskb", by using kfree_skb()
> instead of kfree().
> 
> Fixes: 1574481bb3de ("vxcan: remove sk reference in peer skb")
> Link: https://lore.kernel.org/all/20220311123741.382618-1-mkl@pengutronix.de
> Cc: Oliver Hartkopp <socketcan@hartkopp.net>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> [...]

Here is the summary with links:
  - [net-next,01/13] can: vxcan: vxcan_xmit(): use kfree_skb() instead of kfree() to free skb
    https://git.kernel.org/netdev/net-next/c/fc7dcd05f4c2
  - [net-next,02/13] can: mcp251xfd: mcp251xfd_ring_init(): use %d to print free RAM
    https://git.kernel.org/netdev/net-next/c/c47675b11ba1
  - [net-next,03/13] can: mcp251xfd: ram: add helper function for runtime ring size calculation
    https://git.kernel.org/netdev/net-next/c/a1439a5add62
  - [net-next,04/13] can: mcp251xfd: ram: coalescing support
    https://git.kernel.org/netdev/net-next/c/b8123d94f58c
  - [net-next,05/13] can: mcp251xfd: ethtool: add support
    https://git.kernel.org/netdev/net-next/c/d86ba8db6af3
  - [net-next,06/13] can: mcp251xfd: ring: prepare support for runtime configurable RX/TX ring parameters
    https://git.kernel.org/netdev/net-next/c/0a1f2e6502a1
  - [net-next,07/13] can: mcp251xfd: update macros describing ring, FIFO and RAM layout
    https://git.kernel.org/netdev/net-next/c/c9e6b80dfd48
  - [net-next,08/13] can: mcp251xfd: ring: add support for runtime configurable RX/TX ring parameters
    https://git.kernel.org/netdev/net-next/c/9263c2e92be9
  - [net-next,09/13] can: mcp251xfd: add RX IRQ coalescing support
    https://git.kernel.org/netdev/net-next/c/60a848c50d2d
  - [net-next,10/13] can: mcp251xfd: add RX IRQ coalescing ethtool support
    https://git.kernel.org/netdev/net-next/c/846990e0ed82
  - [net-next,11/13] can: mcp251xfd: add TX IRQ coalescing support
    https://git.kernel.org/netdev/net-next/c/169d00a25658
  - [net-next,12/13] can: mcp251xfd: add TX IRQ coalescing ethtool support
    https://git.kernel.org/netdev/net-next/c/656fc12ddaf8
  - [net-next,13/13] can: mcp251xfd: ring: increase number of RX-FIFOs to 3 and increase max TX-FIFO depth to 16
    https://git.kernel.org/netdev/net-next/c/aa66ae9b241e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c
index 94a0c9c6a509..577a80300514 100644
--- a/drivers/net/can/vxcan.c
+++ b/drivers/net/can/vxcan.c
@@ -57,7 +57,7 @@  static netdev_tx_t vxcan_xmit(struct sk_buff *oskb, struct net_device *dev)
 	if (skb) {
 		consume_skb(oskb);
 	} else {
-		kfree(oskb);
+		kfree_skb(oskb);
 		goto out_unlock;
 	}