Resolves: https://gitlab.com/qemu-project/qemu/-/issues/542

Commit Message

zzl March 12, 2022, 8:26 a.m. UTC

---
 hw/audio/intel-hda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth March 14, 2022, 7:57 a.m. UTC | #1

On 12/03/2022 09.26, zzl wrote:
> ---
>   hw/audio/intel-hda.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
> index 5f8a878f20..ff32936cfd 100644
> --- a/hw/audio/intel-hda.c
> +++ b/hw/audio/intel-hda.c
> @@ -328,7 +328,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
>               dprint(d, 2, "%s: corb ring empty\n", __func__);
>               return;
>           }
> -        if (d->rirb_count == d->rirb_cnt) {
> +        if (d->rirb_count >= d->rirb_cnt) {
>               dprint(d, 2, "%s: rirb count reached\n", __func__);
>               return;
>           }

  Hi!

Please see https://www.qemu.org/docs/master/devel/submitting-a-patch.html 
for information how to correclty submit a patch. Especially you need to 
supply a "Signed-off-by" line, too, and please use a proper subject for the 
mail and place the "Resolves:" line into the patch description instead.

Apart from that, the bug ticket already links a patch series with a proposed 
fix ... could you elaborate why this needs a different approach?

  Thomas

Patch

diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index 5f8a878f20..ff32936cfd 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -328,7 +328,7 @@  static void intel_hda_corb_run(IntelHDAState *d)
             dprint(d, 2, "%s: corb ring empty\n", __func__);
             return;
         }
-        if (d->rirb_count == d->rirb_cnt) {
+        if (d->rirb_count >= d->rirb_cnt) {
             dprint(d, 2, "%s: rirb count reached\n", __func__);
             return;
         }