| Message ID | 20220315061031.21642-3-moudy.ho@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add mutex support for MDP | expand |
Il 15/03/22 07:10, Moudy Ho ha scritto: > For the purpose of module independence, related settings should be moved > from MDP to the corresponding driver. > This patch adds 8183 MUTEX MOD settings for MDP. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Hi, Moudy: On Tue, 2022-03-15 at 14:10 +0800, Moudy Ho wrote: > For the purpose of module independence, related settings should be > moved > from MDP to the corresponding driver. > This patch adds 8183 MUTEX MOD settings for MDP. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > --- > drivers/soc/mediatek/mtk-mutex.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > b/drivers/soc/mediatek/mtk-mutex.c > index 778b01ce9e8f..88fb4fc8f216 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -80,6 +80,15 @@ > #define MT8183_MUTEX_MOD_DISP_GAMMA0 16 > #define MT8183_MUTEX_MOD_DISP_DITHER0 17 > > +#define MT8183_MUTEX_MOD_MDP_RDMA0 BIT(2) Display definition is a number, why MDP is bit definition? Regards, CK > +#define MT8183_MUTEX_MOD_MDP_RSZ0 BIT(4) > +#define MT8183_MUTEX_MOD_MDP_RSZ1 BIT(5) > +#define MT8183_MUTEX_MOD_MDP_TDSHP0 BIT(6) > +#define MT8183_MUTEX_MOD_MDP_WROT0 BIT(7) > +#define MT8183_MUTEX_MOD_MDP_WDMA BIT(8) > +#define MT8183_MUTEX_MOD_MDP_AAL0 BIT(23) > +#define MT8183_MUTEX_MOD_MDP_CCORR0 BIT(24) > + > #define MT8173_MUTEX_MOD_DISP_OVL0 11 > #define MT8173_MUTEX_MOD_DISP_OVL1 12 > #define MT8173_MUTEX_MOD_DISP_RDMA0 13 > @@ -244,6 +253,17 @@ static const unsigned int > mt8183_mutex_mod[DDP_COMPONENT_ID_MAX] = { > [DDP_COMPONENT_WDMA0] = MT8183_MUTEX_MOD_DISP_WDMA0, > }; > >
On Wed, 2022-03-16 at 11:31 +0800, CK Hu wrote: > Hi, Moudy: > > On Tue, 2022-03-15 at 14:10 +0800, Moudy Ho wrote: > > For the purpose of module independence, related settings should be > > moved > > from MDP to the corresponding driver. > > This patch adds 8183 MUTEX MOD settings for MDP. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > --- > > drivers/soc/mediatek/mtk-mutex.c | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > b/drivers/soc/mediatek/mtk-mutex.c > > index 778b01ce9e8f..88fb4fc8f216 100644 > > --- a/drivers/soc/mediatek/mtk-mutex.c > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > @@ -80,6 +80,15 @@ > > #define MT8183_MUTEX_MOD_DISP_GAMMA0 16 > > #define MT8183_MUTEX_MOD_DISP_DITHER0 17 > > > > +#define MT8183_MUTEX_MOD_MDP_RDMA0 BIT(2) > > Display definition is a number, why MDP is bit definition? > > Regards, > CK > Hi CK, Thanks for the reminder. * It was intended to apply the new declaration style (ref: https://patchwork.kernel.org/project/linux-mediatek/patch/20220311015506.11232-9-nancy.lin@mediatek.com/ ), but it seems redundant. I should add the new settings in the original way first, then keep the definition changes in the subsequence patch. Thanks, Moudy > > +#define MT8183_MUTEX_MOD_MDP_RSZ0 BIT(4) > > +#define MT8183_MUTEX_MOD_MDP_RSZ1 BIT(5) > > +#define MT8183_MUTEX_MOD_MDP_TDSHP0 BIT(6) > > +#define MT8183_MUTEX_MOD_MDP_WROT0 BIT(7) > > +#define MT8183_MUTEX_MOD_MDP_WDMA BIT(8) > > +#define MT8183_MUTEX_MOD_MDP_AAL0 BIT(23) > > +#define MT8183_MUTEX_MOD_MDP_CCORR0 BIT(24) > > + > > #define MT8173_MUTEX_MOD_DISP_OVL0 11 > > #define MT8173_MUTEX_MOD_DISP_OVL1 12 > > #define MT8173_MUTEX_MOD_DISP_RDMA0 13 > > @@ -244,6 +253,17 @@ static const unsigned int > > mt8183_mutex_mod[DDP_COMPONENT_ID_MAX] = { > > [DDP_COMPONENT_WDMA0] = MT8183_MUTEX_MOD_DISP_WDMA0, > > }; > > > > > >
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index 778b01ce9e8f..88fb4fc8f216 100644 --- a/drivers/soc/mediatek/mtk-mutex.c +++ b/drivers/soc/mediatek/mtk-mutex.c @@ -80,6 +80,15 @@ #define MT8183_MUTEX_MOD_DISP_GAMMA0 16 #define MT8183_MUTEX_MOD_DISP_DITHER0 17 +#define MT8183_MUTEX_MOD_MDP_RDMA0 BIT(2) +#define MT8183_MUTEX_MOD_MDP_RSZ0 BIT(4) +#define MT8183_MUTEX_MOD_MDP_RSZ1 BIT(5) +#define MT8183_MUTEX_MOD_MDP_TDSHP0 BIT(6) +#define MT8183_MUTEX_MOD_MDP_WROT0 BIT(7) +#define MT8183_MUTEX_MOD_MDP_WDMA BIT(8) +#define MT8183_MUTEX_MOD_MDP_AAL0 BIT(23) +#define MT8183_MUTEX_MOD_MDP_CCORR0 BIT(24) + #define MT8173_MUTEX_MOD_DISP_OVL0 11 #define MT8173_MUTEX_MOD_DISP_OVL1 12 #define MT8173_MUTEX_MOD_DISP_RDMA0 13 @@ -244,6 +253,17 @@ static const unsigned int mt8183_mutex_mod[DDP_COMPONENT_ID_MAX] = { [DDP_COMPONENT_WDMA0] = MT8183_MUTEX_MOD_DISP_WDMA0, }; +static const unsigned long long mt8183_mutex_table_mod[MUTEX_TABLE_IDX_MAX] = { + [MUTEX_TABLE_IDX_MDP_RDMA0] = MT8183_MUTEX_MOD_MDP_RDMA0, + [MUTEX_TABLE_IDX_MDP_RSZ0] = MT8183_MUTEX_MOD_MDP_RSZ0, + [MUTEX_TABLE_IDX_MDP_RSZ1] = MT8183_MUTEX_MOD_MDP_RSZ1, + [MUTEX_TABLE_IDX_MDP_TDSHP0] = MT8183_MUTEX_MOD_MDP_TDSHP0, + [MUTEX_TABLE_IDX_MDP_WROT0] = MT8183_MUTEX_MOD_MDP_WROT0, + [MUTEX_TABLE_IDX_MDP_WDMA] = MT8183_MUTEX_MOD_MDP_WDMA, + [MUTEX_TABLE_IDX_MDP_AAL0] = MT8183_MUTEX_MOD_MDP_AAL0, + [MUTEX_TABLE_IDX_MDP_CCORR0] = MT8183_MUTEX_MOD_MDP_CCORR0, +}; + static const unsigned int mt8186_mutex_mod[DDP_COMPONENT_ID_MAX] = { [DDP_COMPONENT_AAL0] = MT8186_MUTEX_MOD_DISP_AAL0, [DDP_COMPONENT_CCORR] = MT8186_MUTEX_MOD_DISP_CCORR0, @@ -335,6 +355,7 @@ static const struct mtk_mutex_data mt8183_mutex_driver_data = { .mutex_sof = mt8183_mutex_sof, .mutex_mod_reg = MT8183_MUTEX0_MOD0, .mutex_sof_reg = MT8183_MUTEX0_SOF0, + .mutex_table_mod = mt8183_mutex_table_mod, .no_clk = true, };
For the purpose of module independence, related settings should be moved from MDP to the corresponding driver. This patch adds 8183 MUTEX MOD settings for MDP. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> --- drivers/soc/mediatek/mtk-mutex.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)