diff mbox series

[net-next] net: sparx5: fix a couple warning messages

Message ID 20220314140327.GB30883@kili (mailing list archive)
State Accepted
Commit c24f657791fd2df9d7a5491ac43b63658ea7187d
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: sparx5: fix a couple warning messages | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 1 maintainers not CCed: linux-arm-kernel@lists.infradead.org
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 16 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Dan Carpenter March 14, 2022, 2:03 p.m. UTC
The WARN_ON() macro takes a condition, not a warning message.

Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 15, 2022, 3:20 p.m. UTC | #1
Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 14 Mar 2022 17:03:27 +0300 you wrote:
> The WARN_ON() macro takes a condition, not a warning message.
> 
> Fixes: 0933bd04047c ("net: sparx5: Add support for ptp clocks")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [net-next] net: sparx5: fix a couple warning messages
    https://git.kernel.org/netdev/net-next/c/c24f657791fd

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
index cd110c31e5a4..0ed1ea7727c5 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
@@ -45,7 +45,7 @@  static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5)
 		res =  920535763834;
 		break;
 	default:
-		WARN_ON("Invalid core clock");
+		WARN(1, "Invalid core clock");
 		break;
 	}
 
@@ -67,7 +67,7 @@  static u64 sparx5_ptp_get_nominal_value(struct sparx5 *sparx5)
 		res = 0x0CC6666666666666;
 		break;
 	default:
-		WARN_ON("Invalid core clock");
+		WARN(1, "Invalid core clock");
 		break;
 	}