| Message ID | 20220315223700.2961660-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor" | expand |
On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: > There are several spelling mistakes in comments, function names > and literal strings. Fix these. I do not think that there are mistakes. Please look at page 29 of the official bq24150 datasheet: https://www.ti.com/lit/ds/symlink/bq24150.pdf > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/power/supply/bq2415x_charger.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c > index 5724001e66b9..b35700071966 100644 > --- a/drivers/power/supply/bq2415x_charger.c > +++ b/drivers/power/supply/bq2415x_charger.c > @@ -71,7 +71,7 @@ > #define BQ2415X_BIT_OTG_PL 1 > #define BQ2415X_BIT_OTG_EN 0 > > -/* vender register */ > +/* vendor register */ > #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) > #define BQ2415X_SHIFT_VENDER 5 > #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) > return -1; > } > > -/* return chip vender code */ > -static int bq2415x_get_vender_code(struct bq2415x_device *bq) > +/* return chip vendor code */ > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) > { > int ret; > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) > sprintf(revstr, "1.%d", ret); > > bq->model = kasprintf(GFP_KERNEL, > - "chip %s, revision %s, vender code %.3d", > + "chip %s, revision %s, vendor code %.3d", > bq2415x_chip_name[chip], revstr, > - bq2415x_get_vender_code(bq)); > + bq2415x_get_vendor_code(bq)); > if (!bq->model) { > dev_err(bq->dev, "failed to allocate model name\n"); > return -ENOMEM; > -- > 2.35.1 >
On 15/03/2022 22:46, Pali Rohár wrote: > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: >> There are several spelling mistakes in comments, function names >> and literal strings. Fix these. > > I do not think that there are mistakes. > > Please look at page 29 of the official bq24150 datasheet: > https://www.ti.com/lit/ds/symlink/bq24150.pdf Looks like TI are redefining the spelling in the language :-) > >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >> --- >> drivers/power/supply/bq2415x_charger.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c >> index 5724001e66b9..b35700071966 100644 >> --- a/drivers/power/supply/bq2415x_charger.c >> +++ b/drivers/power/supply/bq2415x_charger.c >> @@ -71,7 +71,7 @@ >> #define BQ2415X_BIT_OTG_PL 1 >> #define BQ2415X_BIT_OTG_EN 0 >> >> -/* vender register */ >> +/* vendor register */ >> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) >> #define BQ2415X_SHIFT_VENDER 5 >> #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) >> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) >> return -1; >> } >> >> -/* return chip vender code */ >> -static int bq2415x_get_vender_code(struct bq2415x_device *bq) >> +/* return chip vendor code */ >> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) >> { >> int ret; >> >> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) >> sprintf(revstr, "1.%d", ret); >> >> bq->model = kasprintf(GFP_KERNEL, >> - "chip %s, revision %s, vender code %.3d", >> + "chip %s, revision %s, vendor code %.3d", >> bq2415x_chip_name[chip], revstr, >> - bq2415x_get_vender_code(bq)); >> + bq2415x_get_vendor_code(bq)); >> if (!bq->model) { >> dev_err(bq->dev, "failed to allocate model name\n"); >> return -ENOMEM; >> -- >> 2.35.1 >>
On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote: > On 15/03/2022 22:46, Pali Rohár wrote: > > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: > > > There are several spelling mistakes in comments, function names > > > and literal strings. Fix these. > > > > I do not think that there are mistakes. > > > > Please look at page 29 of the official bq24150 datasheet: > > https://www.ti.com/lit/ds/symlink/bq24150.pdf > > Looks like TI are redefining the spelling in the language :-) Well, that could be truth, or maybe it just means something different. It is about 10 years ago and I do not remember more details about it. Anyway, in any case register name is vender and kernel code should match official register naming for which driver was written... > > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > --- > > > drivers/power/supply/bq2415x_charger.c | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c > > > index 5724001e66b9..b35700071966 100644 > > > --- a/drivers/power/supply/bq2415x_charger.c > > > +++ b/drivers/power/supply/bq2415x_charger.c > > > @@ -71,7 +71,7 @@ > > > #define BQ2415X_BIT_OTG_PL 1 > > > #define BQ2415X_BIT_OTG_EN 0 > > > -/* vender register */ > > > +/* vendor register */ > > > #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) > > > #define BQ2415X_SHIFT_VENDER 5 > > > #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) > > > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) > > > return -1; > > > } > > > -/* return chip vender code */ > > > -static int bq2415x_get_vender_code(struct bq2415x_device *bq) > > > +/* return chip vendor code */ > > > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) > > > { > > > int ret; > > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) > > > sprintf(revstr, "1.%d", ret); > > > bq->model = kasprintf(GFP_KERNEL, > > > - "chip %s, revision %s, vender code %.3d", > > > + "chip %s, revision %s, vendor code %.3d", > > > bq2415x_chip_name[chip], revstr, > > > - bq2415x_get_vender_code(bq)); > > > + bq2415x_get_vendor_code(bq)); > > > if (!bq->model) { > > > dev_err(bq->dev, "failed to allocate model name\n"); > > > return -ENOMEM; > > > -- > > > 2.35.1 > > > >
On 15/03/2022 23:07, Pali Rohár wrote: > On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote: >> On 15/03/2022 22:46, Pali Rohár wrote: >>> On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: >>>> There are several spelling mistakes in comments, function names >>>> and literal strings. Fix these. >>> >>> I do not think that there are mistakes. >>> >>> Please look at page 29 of the official bq24150 datasheet: >>> https://www.ti.com/lit/ds/symlink/bq24150.pdf >> >> Looks like TI are redefining the spelling in the language :-) > > Well, that could be truth, or maybe it just means something different. > It is about 10 years ago and I do not remember more details about it. > Anyway, in any case register name is vender and kernel code should match > official register naming for which driver was written... I'm fine with that. Apologies for the noise. > >>> >>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> >>>> --- >>>> drivers/power/supply/bq2415x_charger.c | 10 +++++----- >>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c >>>> index 5724001e66b9..b35700071966 100644 >>>> --- a/drivers/power/supply/bq2415x_charger.c >>>> +++ b/drivers/power/supply/bq2415x_charger.c >>>> @@ -71,7 +71,7 @@ >>>> #define BQ2415X_BIT_OTG_PL 1 >>>> #define BQ2415X_BIT_OTG_EN 0 >>>> -/* vender register */ >>>> +/* vendor register */ >>>> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) >>>> #define BQ2415X_SHIFT_VENDER 5 >>>> #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) >>>> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) >>>> return -1; >>>> } >>>> -/* return chip vender code */ >>>> -static int bq2415x_get_vender_code(struct bq2415x_device *bq) >>>> +/* return chip vendor code */ >>>> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) >>>> { >>>> int ret; >>>> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) >>>> sprintf(revstr, "1.%d", ret); >>>> bq->model = kasprintf(GFP_KERNEL, >>>> - "chip %s, revision %s, vender code %.3d", >>>> + "chip %s, revision %s, vendor code %.3d", >>>> bq2415x_chip_name[chip], revstr, >>>> - bq2415x_get_vender_code(bq)); >>>> + bq2415x_get_vendor_code(bq)); >>>> if (!bq->model) { >>>> dev_err(bq->dev, "failed to allocate model name\n"); >>>> return -ENOMEM; >>>> -- >>>> 2.35.1 >>>> >>
On Tuesday 15 March 2022 23:09:17 Colin King (gmail) wrote: > On 15/03/2022 23:07, Pali Rohár wrote: > > On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote: > > > On 15/03/2022 22:46, Pali Rohár wrote: > > > > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: > > > > > There are several spelling mistakes in comments, function names > > > > > and literal strings. Fix these. > > > > > > > > I do not think that there are mistakes. > > > > > > > > Please look at page 29 of the official bq24150 datasheet: > > > > https://www.ti.com/lit/ds/symlink/bq24150.pdf > > > > > > Looks like TI are redefining the spelling in the language :-) > > > > Well, that could be truth, or maybe it just means something different. > > It is about 10 years ago and I do not remember more details about it. > > Anyway, in any case register name is vender and kernel code should match > > official register naming for which driver was written... > > I'm fine with that. Apologies for the noise. I looked into dictionaries and word vender exists in Cambridge Dictionary: https://dictionary.cambridge.org/dictionary/english/vender Also some details about this word are available in Wiktionary: https://en.wiktionary.org/wiki/vender#English And looking at more internet resources and discussions, it looks like that word vender is just older spelling in American English. But I really do not know, I'm not native speaker. > > > > > > > > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > > > --- > > > > > drivers/power/supply/bq2415x_charger.c | 10 +++++----- > > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c > > > > > index 5724001e66b9..b35700071966 100644 > > > > > --- a/drivers/power/supply/bq2415x_charger.c > > > > > +++ b/drivers/power/supply/bq2415x_charger.c > > > > > @@ -71,7 +71,7 @@ > > > > > #define BQ2415X_BIT_OTG_PL 1 > > > > > #define BQ2415X_BIT_OTG_EN 0 > > > > > -/* vender register */ > > > > > +/* vendor register */ > > > > > #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) > > > > > #define BQ2415X_SHIFT_VENDER 5 > > > > > #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) > > > > > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) > > > > > return -1; > > > > > } > > > > > -/* return chip vender code */ > > > > > -static int bq2415x_get_vender_code(struct bq2415x_device *bq) > > > > > +/* return chip vendor code */ > > > > > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) > > > > > { > > > > > int ret; > > > > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) > > > > > sprintf(revstr, "1.%d", ret); > > > > > bq->model = kasprintf(GFP_KERNEL, > > > > > - "chip %s, revision %s, vender code %.3d", > > > > > + "chip %s, revision %s, vendor code %.3d", > > > > > bq2415x_chip_name[chip], revstr, > > > > > - bq2415x_get_vender_code(bq)); > > > > > + bq2415x_get_vendor_code(bq)); > > > > > if (!bq->model) { > > > > > dev_err(bq->dev, "failed to allocate model name\n"); > > > > > return -ENOMEM; > > > > > -- > > > > > 2.35.1 > > > > > > > > >
On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote: > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: > > There are several spelling mistakes in comments, function names > > and literal strings. Fix these. > > I do not think that there are mistakes. > > Please look at page 29 of the official bq24150 datasheet: > https://www.ti.com/lit/ds/symlink/bq24150.pdf > "Table 8. Vender/Part/Revision Register (Read only)" Just because they spelled it wrong in the hardware spec doesn't mean we have to spell it wrong here. regards, dan carpenter
On Wed, Mar 16, 2022 at 01:35:26PM +0300, Dan Carpenter wrote: > On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote: > > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote: > > > There are several spelling mistakes in comments, function names > > > and literal strings. Fix these. > > > > I do not think that there are mistakes. > > > > Please look at page 29 of the official bq24150 datasheet: > > https://www.ti.com/lit/ds/symlink/bq24150.pdf > > > > "Table 8. Vender/Part/Revision Register (Read only)" > > Just because they spelled it wrong in the hardware spec doesn't mean we > have to spell it wrong here. Of course, there are times where spelling mistakes do have to be preserved forever. I forget the examples. But here I think it's fine to correct them. regards, dan carpenter
This is like "referer links". https://en.wikipedia.org/wiki/HTTP_referer Everyone except the New Yorker considers it a spelling mistake. New Yorker spells it "vender" as well but they're alone in that. Everyone else says "vender is an obsolete American spelling of vendor". New Yorker is crazy with their diaeresis and hyphens. regards, dan carpenter
diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c index 5724001e66b9..b35700071966 100644 --- a/drivers/power/supply/bq2415x_charger.c +++ b/drivers/power/supply/bq2415x_charger.c @@ -71,7 +71,7 @@ #define BQ2415X_BIT_OTG_PL 1 #define BQ2415X_BIT_OTG_EN 0 -/* vender register */ +/* vendor register */ #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7)) #define BQ2415X_SHIFT_VENDER 5 #define BQ2415X_MASK_PN (BIT(3)|BIT(4)) @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq) return -1; } -/* return chip vender code */ -static int bq2415x_get_vender_code(struct bq2415x_device *bq) +/* return chip vendor code */ +static int bq2415x_get_vendor_code(struct bq2415x_device *bq) { int ret; @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq) sprintf(revstr, "1.%d", ret); bq->model = kasprintf(GFP_KERNEL, - "chip %s, revision %s, vender code %.3d", + "chip %s, revision %s, vendor code %.3d", bq2415x_chip_name[chip], revstr, - bq2415x_get_vender_code(bq)); + bq2415x_get_vendor_code(bq)); if (!bq->model) { dev_err(bq->dev, "failed to allocate model name\n"); return -ENOMEM;
There are several spelling mistakes in comments, function names and literal strings. Fix these. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/power/supply/bq2415x_charger.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)