diff mbox series

[v1,1/2] generic/674: check for dedupe support on scratch fs

Message ID 20220317100842.1237893-2-bxue@redhat.com (mailing list archive)
State New, archived
Headers show
Series check for dedupe and security namespace support | expand

Commit Message

Boyang Xue March 17, 2022, 10:08 a.m. UTC 
From: Boyang Xue <bxue@redhat.com>

Signed-off-by: Boyang Xue <bxue@redhat.com>
---
 tests/generic/674 | 1 +
 1 file changed, 1 insertion(+)

Comments

Darrick J. Wong March 17, 2022, 3:11 p.m. UTC | #1 
On Thu, Mar 17, 2022 at 06:08:41PM +0800, bxue@redhat.com wrote:
> From: Boyang Xue <bxue@redhat.com>
> 
> Signed-off-by: Boyang Xue <bxue@redhat.com>
> ---
>  tests/generic/674 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/674 b/tests/generic/674
> index bf0bcffb..7e5e4e29 100755
> --- a/tests/generic/674
> +++ b/tests/generic/674
> @@ -19,6 +19,7 @@ _begin_fstest auto clone quick
>  _supported_fs generic
>  _require_user
>  _require_scratch_reflink
> +_require_scratch_dedupe

I think you could replace the _require_scratch_reflink with
_require_scratch_dedupe here, right?  I probably copypasta'd this.

--D

>  _require_xfs_io_command dedupe
>  
>  _scratch_mkfs >> $seqres.full
> -- 
> 2.27.0
>
Boyang Xue March 17, 2022, 4:32 p.m. UTC | #2 
(Resend due to previous email being rejected. Sorry)

Thanks Darrick. I will replace the "_require_scratch_reflink" with
"_require_scratch_dedupe" in v2 patch.

-Boyang

On Thu, Mar 17, 2022 at 11:11 PM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Thu, Mar 17, 2022 at 06:08:41PM +0800, bxue@redhat.com wrote:
> > From: Boyang Xue <bxue@redhat.com>
> >
> > Signed-off-by: Boyang Xue <bxue@redhat.com>
> > ---
> >  tests/generic/674 | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/generic/674 b/tests/generic/674
> > index bf0bcffb..7e5e4e29 100755
> > --- a/tests/generic/674
> > +++ b/tests/generic/674
> > @@ -19,6 +19,7 @@ _begin_fstest auto clone quick
> >  _supported_fs generic
> >  _require_user
> >  _require_scratch_reflink
> > +_require_scratch_dedupe
>
> I think you could replace the _require_scratch_reflink with
> _require_scratch_dedupe here, right?  I probably copypasta'd this.
>
> --D
>
> >  _require_xfs_io_command dedupe
> >
> >  _scratch_mkfs >> $seqres.full
> > --
> > 2.27.0
> >
>
diff mbox series

Patch

diff --git a/tests/generic/674 b/tests/generic/674
index bf0bcffb..7e5e4e29 100755
--- a/tests/generic/674
+++ b/tests/generic/674
@@ -19,6 +19,7 @@  _begin_fstest auto clone quick
 _supported_fs generic
 _require_user
 _require_scratch_reflink
+_require_scratch_dedupe
 _require_xfs_io_command dedupe
 
 _scratch_mkfs >> $seqres.full