| Message ID | 20220316213109.2352015-1-morbo@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | df4d35e1f01f7a6d50bb098eaeed8b04ef422fdc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | enetc: use correct format characters | expand |
> -----Original Message----- > From: Bill Wendling <morbo@google.com> > Sent: Wednesday, March 16, 2022 11:31 PM [...] > Subject: [PATCH] enetc: use correct format characters > > When compiling with -Wformat, clang emits the following warning: > > drivers/net/ethernet/freescale/enetc/enetc_mdio.c:151:22: warning: > format specifies type 'unsigned char' but the argument has type 'int' > [-Wformat] > phy_id, dev_addr, regnum); > ^~~~~~ > ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' > dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > ./include/linux/dev_printk.h:129:34: note: expanded from macro > 'dev_printk' > _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > > The types of these arguments are unconditionally defined, so this patch > updates the format character to the correct ones for ints and unsigned ints. > > Link: ClangBuiltLinux/linux#378 > Signed-off-by: Bill Wendling <morbo@google.com> Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com> Fixes: ebfcb23d62ab ("enetc: Add ENETC PF level external MDIO support") Can be also net-next material. It's up to you. Thx.
On Thu, Mar 17, 2022 at 10:37 AM Claudiu Manoil <claudiu.manoil@nxp.com> wrote: > > > -----Original Message----- > > From: Bill Wendling <morbo@google.com> > > Sent: Wednesday, March 16, 2022 11:31 PM > [...] > > Subject: [PATCH] enetc: use correct format characters > > > > When compiling with -Wformat, clang emits the following warning: > > > > drivers/net/ethernet/freescale/enetc/enetc_mdio.c:151:22: warning: > > format specifies type 'unsigned char' but the argument has type 'int' > > [-Wformat] > > phy_id, dev_addr, regnum); > > ^~~~~~ > > ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' > > dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > > ~~~ ^~~~~~~~~~~ > > ./include/linux/dev_printk.h:129:34: note: expanded from macro > > 'dev_printk' > > _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > > ~~~ ^~~~~~~~~~~ > > > > The types of these arguments are unconditionally defined, so this patch > > updates the format character to the correct ones for ints and unsigned ints. > > > > Link: ClangBuiltLinux/linux#378 > > Signed-off-by: Bill Wendling <morbo@google.com> > > Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com> > Fixes: ebfcb23d62ab ("enetc: Add ENETC PF level external MDIO support") > Thanks Claudiu. Could you change the Link about to this one? It's a valid URL. Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Can be also net-next material. It's up to you. Thx.
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 16 Mar 2022 14:31:09 -0700 you wrote: > When compiling with -Wformat, clang emits the following warning: > > drivers/net/ethernet/freescale/enetc/enetc_mdio.c:151:22: warning: > format specifies type 'unsigned char' but the argument has type 'int' > [-Wformat] > phy_id, dev_addr, regnum); > ^~~~~~ > ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' > dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > ./include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' > _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > ~~~ ^~~~~~~~~~~ > > [...] Here is the summary with links: - enetc: use correct format characters https://git.kernel.org/netdev/net-next/c/df4d35e1f01f You are awesome, thank you!
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c index 70e6d97b380f..1c8f5cc6dec4 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c @@ -147,7 +147,7 @@ int enetc_mdio_read(struct mii_bus *bus, int phy_id, int regnum) /* return all Fs if nothing was there */ if (enetc_mdio_rd(mdio_priv, ENETC_MDIO_CFG) & MDIO_CFG_RD_ER) { dev_dbg(&bus->dev, - "Error while reading PHY%d reg at %d.%hhu\n", + "Error while reading PHY%d reg at %d.%d\n", phy_id, dev_addr, regnum); return 0xffff; }
When compiling with -Wformat, clang emits the following warning: drivers/net/ethernet/freescale/enetc/enetc_mdio.c:151:22: warning: format specifies type 'unsigned char' but the argument has type 'int' [-Wformat] phy_id, dev_addr, regnum); ^~~~~~ ./include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg' dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ ./include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk' _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ The types of these arguments are unconditionally defined, so this patch updates the format character to the correct ones for ints and unsigned ints. Link: ClangBuiltLinux/linux#378 Signed-off-by: Bill Wendling <morbo@google.com> --- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)