| Message ID | 20220318072728.2659578-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 800c326bfa9cee38f0e173733ce9f93492c84c8b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] nfc: st21nfca: remove unnecessary skb check before kfree_skb() | expand |
On 18/03/2022 08:27, Yang Yingliang wrote: > The skb will be checked in kfree_skb(), so remove the outside check. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/nfc/st21nfca/i2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 18 Mar 2022 15:27:28 +0800 you wrote: > The skb will be checked in kfree_skb(), so remove the outside check. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/nfc/st21nfca/i2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Here is the summary with links: - [-next] nfc: st21nfca: remove unnecessary skb check before kfree_skb() https://git.kernel.org/netdev/net-next/c/800c326bfa9c You are awesome, thank you!
diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index a86b5edfc7ce..42dc0e5eb161 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -570,8 +570,7 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *client) if (phy->powered) st21nfca_hci_i2c_disable(phy); - if (phy->pending_skb) - kfree_skb(phy->pending_skb); + kfree_skb(phy->pending_skb); return 0; }
The skb will be checked in kfree_skb(), so remove the outside check. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/nfc/st21nfca/i2c.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)