| Message ID | 20220214212955.1178947-3-piotr.oniszczuk@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] media: hantro: Add support for Hantro G1 on RK356x | expand |
Hi Piotr, On Mon, Feb 14, 2022 at 10:29:55PM +0100, Piotr Oniszczuk wrote: > From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com> > > RK356x has Hantro G1 video decoder capable to decode MPEG2/H.264/VP8 > video formats. > > This patch adds RK3568 compatible in rockchip-vpu dt-bindings. > > Tested on [1] with FFmpeg v4l2_request code taken from [2] > with MPEG2, H.642 and VP8 samples with results [3]. > > [1] https://github.com/warpme/minimyth2 > [2] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/multimedia/ffmpeg/patches/v4l2-request/ffmpeg-001-v4l2-request.patch > [3] https://github.com/warpme/minimyth2/blob/master/video-test-summary.txt > > Signed-off-by: Piotr Oniszczuk <piotr.oniszczuk@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> This dt-binding change looks trivial, so I guess it's fine taking it directly via the media tree? Thanks, Ezequiel > --- > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index bacb60a34989..6cc4d3e5a61d 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -23,6 +23,7 @@ properties: > - rockchip,rk3328-vpu > - rockchip,rk3399-vpu > - rockchip,px30-vpu > + - rockchip,rk3568-vpu > - items: > - const: rockchip,rk3188-vpu > - const: rockchip,rk3066-vpu > -- > 2.29.2 >
Hi Hans, On Sun, Mar 20, 2022 at 9:39 AM Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > Hi Piotr, > > On Mon, Feb 14, 2022 at 10:29:55PM +0100, Piotr Oniszczuk wrote: > > From: Piotr Oniszczuk <piotr.oniszczuk@gmail.com> > > > > RK356x has Hantro G1 video decoder capable to decode MPEG2/H.264/VP8 > > video formats. > > > > This patch adds RK3568 compatible in rockchip-vpu dt-bindings. > > > > Tested on [1] with FFmpeg v4l2_request code taken from [2] > > with MPEG2, H.642 and VP8 samples with results [3]. > > > > [1] https://github.com/warpme/minimyth2 > > [2] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/multimedia/ffmpeg/patches/v4l2-request/ffmpeg-001-v4l2-request.patch > > [3] https://github.com/warpme/minimyth2/blob/master/video-test-summary.txt > > > > Signed-off-by: Piotr Oniszczuk <piotr.oniszczuk@gmail.com> > > Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > > This dt-binding change looks trivial, so I guess it's fine > taking it directly via the media tree? > I believe this series is ready for you to review. Thanks! Ezequiel > Thanks, > Ezequiel > > > --- > > Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > index bacb60a34989..6cc4d3e5a61d 100644 > > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > > @@ -23,6 +23,7 @@ properties: > > - rockchip,rk3328-vpu > > - rockchip,rk3399-vpu > > - rockchip,px30-vpu > > + - rockchip,rk3568-vpu > > - items: > > - const: rockchip,rk3188-vpu > > - const: rockchip,rk3066-vpu > > -- > > 2.29.2 > >
diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml index bacb60a34989..6cc4d3e5a61d 100644 --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml @@ -23,6 +23,7 @@ properties: - rockchip,rk3328-vpu - rockchip,rk3399-vpu - rockchip,px30-vpu + - rockchip,rk3568-vpu - items: - const: rockchip,rk3188-vpu - const: rockchip,rk3066-vpu