| Message ID | 20220318093153.521634-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8f7544a6cb384c079e3d626b3ee185086a7c0ef |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | qed: remove unnecessary memset in qed_init_fw_funcs | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 18 Mar 2022 17:31:53 +0800 you wrote: > allocated_mem is allocated by kcalloc(). The memory is set to zero. > It is unnecessary to call memset again. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 -- > 1 file changed, 2 deletions(-) Here is the summary with links: - qed: remove unnecessary memset in qed_init_fw_funcs https://git.kernel.org/netdev/net-next/c/b8f7544a6cb3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c index 0ce37f2460a4..407029a36fa1 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c +++ b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c @@ -1835,8 +1835,6 @@ struct phys_mem_desc *qed_fw_overlay_mem_alloc(struct qed_hwfn *p_hwfn, if (!allocated_mem) return NULL; - memset(allocated_mem, 0, NUM_STORMS * sizeof(struct phys_mem_desc)); - /* For each Storm, set physical address in RAM */ while (buf_offset < buf_size) { struct phys_mem_desc *storm_mem_desc;
allocated_mem is allocated by kcalloc(). The memory is set to zero. It is unnecessary to call memset again. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 -- 1 file changed, 2 deletions(-)