diff mbox series

[1/4] generic/459: ensure that the lvm devices have been created

Message ID 164740140920.3371628.4554997239924071993.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: random fixes | expand

Commit Message

Darrick J. Wong March 16, 2022, 3:30 a.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Once in a /very/ long while this test fails because _mkfs_dev can't find
the LVM thinp volume after it's been created.  Since the "solution" du
jour seems to be to sprinkle udevadm settle calls everywhere, do that
here in the hopes that will fix it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/459 |    1 +
 1 file changed, 1 insertion(+)

Comments

Zorro Lang March 22, 2022, 4:50 a.m. UTC | #1
On Tue, Mar 15, 2022 at 08:30:09PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Once in a /very/ long while this test fails because _mkfs_dev can't find
> the LVM thinp volume after it's been created.  Since the "solution" du
> jour seems to be to sprinkle udevadm settle calls everywhere, do that
> here in the hopes that will fix it.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/459 |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/tests/generic/459 b/tests/generic/459
> index cda19e6e..57d58e55 100755
> --- a/tests/generic/459
> +++ b/tests/generic/459
> @@ -70,6 +70,7 @@ $LVM_PROG lvcreate  --virtualsize $virtsize \
>  		    -T $vgname/$poolname \
>  		    -n $lvname >>$seqres.full 2>&1
>  
> +$UDEV_SETTLE_PROG &>/dev/null
>  _mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
>  
>  # Running the test over the original volume doesn't reproduce the problem
>
diff mbox series

Patch

diff --git a/tests/generic/459 b/tests/generic/459
index cda19e6e..57d58e55 100755
--- a/tests/generic/459
+++ b/tests/generic/459
@@ -70,6 +70,7 @@  $LVM_PROG lvcreate  --virtualsize $virtsize \
 		    -T $vgname/$poolname \
 		    -n $lvname >>$seqres.full 2>&1
 
+$UDEV_SETTLE_PROG &>/dev/null
 _mkfs_dev /dev/mapper/$vgname-$lvname >>$seqres.full 2>&1
 
 # Running the test over the original volume doesn't reproduce the problem