| Message ID | 20220325081100.1.I9f06fec63b978699fe62591fec9e5ac31bb3a69d@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: sc7280-herobrine: Audio codec wants 1.8V, not 1.62V | expand |
Quoting Douglas Anderson (2022-03-25 08:11:05) > The L2C rail on herobrine boards is intended to go to the audio > codec. Let's override the 1.62V specified in the qcard.dtsi file to be > 1.8V. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index dc17f2079695..c2075f3e7c4b 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -339,6 +339,16 @@ keyboard_backlight: keyboard-backlight { > ts_avdd: &pp3300_left_in_mlb {}; > vreg_edp_3p3: &pp3300_left_in_mlb {}; > > +/* Regulator overrides from Qcard */ This one isn't in ALL CAPS? :) > + > +/* > + * Herobrine boards only use l2c to power an external audio codec (like > + * alc5682) and we want that to be at 1.8V, not at some slightly lower voltage. > + */ > +&vreg_l2c_1p8 { > + regulator-min-microvolt = <1800000>; > +}; > + > /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */
Hi, On Fri, Mar 25, 2022 at 8:42 AM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-03-25 08:11:05) > > The L2C rail on herobrine boards is intended to go to the audio > > codec. Let's override the 1.62V specified in the qcard.dtsi file to be > > 1.8V. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > > > > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > index dc17f2079695..c2075f3e7c4b 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > > @@ -339,6 +339,16 @@ keyboard_backlight: keyboard-backlight { > > ts_avdd: &pp3300_left_in_mlb {}; > > vreg_edp_3p3: &pp3300_left_in_mlb {}; > > > > +/* Regulator overrides from Qcard */ > > This one isn't in ALL CAPS? :) Yeah, I guess it sorta felt like it was a sub-part of the previous section since it was also adjusting Qcard regulators, but you're right that it's not actually a board-local name. What about if I change the section heading for "BOARD-LOCAL NAMES FOR REGULATORS THAT CONNECT TO QCARD" to: /* * ADJUSTMENTS TO QCARD REGULATORS * * Mostly this is just board-local names for regulators that come from * Qcard, but this also has some minor regulator overrides. * * Names are only listed here if regulators go somewhere other than a * testpoint. */ I'll wait a few days and then send a v2 if that sounds OK. -Doug
Quoting Doug Anderson (2022-03-25 08:47:24) > > Yeah, I guess it sorta felt like it was a sub-part of the previous > section since it was also adjusting Qcard regulators, but you're right > that it's not actually a board-local name. What about if I change the > section heading for "BOARD-LOCAL NAMES FOR REGULATORS THAT CONNECT TO > QCARD" to: > > /* > * ADJUSTMENTS TO QCARD REGULATORS > * > * Mostly this is just board-local names for regulators that come from > * Qcard, but this also has some minor regulator overrides. > * > * Names are only listed here if regulators go somewhere other than a > * testpoint. > */ > > I'll wait a few days and then send a v2 if that sounds OK. Sounds good to me.
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi index dc17f2079695..c2075f3e7c4b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi @@ -339,6 +339,16 @@ keyboard_backlight: keyboard-backlight { ts_avdd: &pp3300_left_in_mlb {}; vreg_edp_3p3: &pp3300_left_in_mlb {}; +/* Regulator overrides from Qcard */ + +/* + * Herobrine boards only use l2c to power an external audio codec (like + * alc5682) and we want that to be at 1.8V, not at some slightly lower voltage. + */ +&vreg_l2c_1p8 { + regulator-min-microvolt = <1800000>; +}; + /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ ap_i2c_tpm: &i2c14 {
The L2C rail on herobrine boards is intended to go to the audio codec. Let's override the 1.62V specified in the qcard.dtsi file to be 1.8V. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)