| Message ID | alpine.DEB.2.22.394.2203260927200.3141@hadrien (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: fix for_each_child.cocci warnings | expand |
On Sat, 26 Mar 2022 09:28:12 +0100 (CET) Julia Lawall <julia.lawall@inria.fr> wrote: > From: kernel test robot <lkp@intel.com> > > For_each_child_of_node should have of_node_put() before return. > > Generated by: scripts/coccinelle/iterators/for_each_child.cocci > > CC: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: kernel test robot <lkp@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@inria.fr> The upstream version (in IIO for now, but I'd imagine will hit Linus' tree in next few days) of this looks rather different (no dt code an more) so I suspect this fix is for a now dead branch... Jonathan > --- > > tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS > head: 1870e0fa79a9d58c6748c34550f3ccea0b515933 > commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/1029] iio: adc: Add Xilinx AMS driver > :::::: branch date: 35 hours ago > :::::: commit date: 8 weeks ago > > Please take the patch only if it's a positive warning. Thanks! > > drivers/iio/adc/xilinx-ams.c | 1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/iio/adc/xilinx-ams.c > +++ b/drivers/iio/adc/xilinx-ams.c > @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev * > ams_channels + num_channels); > if (ret < 0) { > kfree(ams_channels); > + of_node_put(child_node); > return ret; > } >
On Sat, Mar 26, 2022 at 12:28 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> Please take the patch only if it's a positive warning. Thanks!
New code rightfully switched to the fwnode API
https://elixir.bootlin.com/linux/latest/source/drivers/iio/adc/xilinx-ams.c#L1254
Is your stuff only for LTS backports?
--- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev * ams_channels + num_channels); if (ret < 0) { kfree(ams_channels); + of_node_put(child_node); return ret; }